From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09D38C7618F for ; Mon, 22 Jul 2019 22:10:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CE59E21955 for ; Mon, 22 Jul 2019 22:10:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gFRo1gA5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CE59E21955 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UdiePeaRZuQ67FwAOI2Q9vZbbd9vQEqKC8LhK5MplUs=; b=gFRo1gA548P3T2 rZnHauew5RktpaCArgYHMJiycZ208yDHaxZY6PvWwfh1pSneJhzJJP2GNB4tFYxzJHDE6nJIcT+Ed SV5vBTreLuVoF5kU9OHJQZqyOlbNbHffk6t6UOMe3y/tqobfimoSs8X4ywEY8jwJkhfekZfuPCx9p Mxw6yHfzADZoGjGVY4XTKgIHs0dgbIpiUqV2vtGG51NjY+hXw0NF2F3KuL2qum5enQmrV7cOMlA4r pUd0N7SiiwC0Q9SSjda8LKuRUavIx+gtC9IHr7ilNnTLWIMhECyZvkGrw0T2Y0YninLpOy/V5xD64 dDqv1xAGnncj4ZQIUIzg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hpgVS-00044Y-To; Mon, 22 Jul 2019 22:10:06 +0000 Received: from mail-io1-f68.google.com ([209.85.166.68]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hpgUi-0003sm-K4; Mon, 22 Jul 2019 22:09:22 +0000 Received: by mail-io1-f68.google.com with SMTP id q22so77478599iog.4; Mon, 22 Jul 2019 15:09:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=oPO7PdmDzdqi5Fe+NgQYohceRPua/BoALQ80fACcCkI=; b=Jkd568Y1Tzx9gAWI7jSrisNBMLHy4zQ/rr/rXYHiWxnLSm3NG6Vu36CugMwjIF4gtV hS1WmhwHhH2ealfyEZOg8kEfxIPvamh+naifOmZ0xqdqxuIMyVEhwGRbGr9BhZzn+g+K 9VuT0LyzAk1lFzem8wp4O5Wf7c6cjItQb4sYVDbJUy+61r8MhNIejeTWe3bVf3RqUJYt q2DgXtgZN3mWku+fohXY9FLT/3GDj37d1MJTlH+oGAxSlLThbOr/bVYqPqWKGtkBBMji oIm69YN5r7K1s2OqjiKkpQu83UcEsqWQBDy8fLQNzqmALMixyQk1M9P0hkE7yDgOVHd0 aeYg== X-Gm-Message-State: APjAAAUV5WMFChMUsGXJQwgCpjXwDWnUN5NLX34oq33BkZBQqjGWYEbj 7mTcRKYxmXzWfWtV2dZK5Q== X-Google-Smtp-Source: APXvYqwXrVpaoCfl2l8pHwCeHeZHWyE8eKMyGWzfhKD/58sdetuN/smodYWuDL1nzIhyX1pY+xdaTA== X-Received: by 2002:a5e:924d:: with SMTP id z13mr13556881iop.247.1563833359275; Mon, 22 Jul 2019 15:09:19 -0700 (PDT) Received: from localhost ([64.188.179.254]) by smtp.gmail.com with ESMTPSA id m4sm36742519iok.68.2019.07.22.15.09.18 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 22 Jul 2019 15:09:18 -0700 (PDT) Date: Mon, 22 Jul 2019 16:09:18 -0600 From: Rob Herring To: Bibby Hsieh Subject: Re: [PATCH v10 03/12] dt-binding: gce: add binding for gce client reg property Message-ID: <20190722220918.GA24605@bogus> References: <20190701074842.15401-1-bibby.hsieh@mediatek.com> <20190701074842.15401-4-bibby.hsieh@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190701074842.15401-4-bibby.hsieh@mediatek.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190722_150920_669999_4B337531 X-CRM114-Status: GOOD ( 16.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Nicolas Boichat , Philipp Zabel , srv_heupstream@mediatek.com, Daoyuan Huang , Sascha Hauer , Jassi Brar , linux-kernel@vger.kernel.org, Daniel Kurtz , YT Shen , CK HU , Dennis-YC Hsieh , linux-mediatek@lists.infradead.org, Houlong Wei , Sascha Hauer , Matthias Brugger , Jiaguang Zhang , linux-arm-kernel@lists.infradead.org, ginny.chen@mediatek.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 01, 2019 at 03:48:33PM +0800, Bibby Hsieh wrote: > cmdq driver provide a function that get the relationship > of sub system number from device node for client. > add specification for #subsys-cells, mediatek,gce-client-reg. > > Signed-off-by: Bibby Hsieh > --- > .../devicetree/bindings/mailbox/mtk-gce.txt | 18 ++++++++++++++---- > 1 file changed, 14 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mailbox/mtk-gce.txt b/Documentation/devicetree/bindings/mailbox/mtk-gce.txt > index 1f7f8f2a3f49..d48282d6b02d 100644 > --- a/Documentation/devicetree/bindings/mailbox/mtk-gce.txt > +++ b/Documentation/devicetree/bindings/mailbox/mtk-gce.txt > @@ -21,12 +21,21 @@ Required properties: > priority: Priority of GCE thread. > atomic_exec: GCE processing continuous packets of commands in atomic > way. > +- #subsys-cells: Should be 3. You don't need this if it is always 3 and/or is always a single phandle. > + <&phandle subsys_number start_offset size> > + phandle: Label name of a gce node. > + subsys_number: specify the sub-system id which is corresponding > + to the register address. > + start_offset: the start offset of register address that GCE can access. > + size: the total size of register address that GCE can access. > > Required properties for a client device: > - mboxes: Client use mailbox to communicate with GCE, it should have this > property and list of phandle, mailbox specifiers. > -- mediatek,gce-subsys: u32, specify the sub-system id which is corresponding > - to the register address. > +Optional properties for a client device: > +- mediatek,gce-client-reg: Specify the sub-system id which is corresponding > + to the register address, it should have this property and list of phandle, > + sub-system specifiers. > > Some vaules of properties are defined in 'dt-bindings/gce/mt8173-gce.h' > or 'dt-binding/gce/mt8183-gce.h'. Such as sub-system ids, thread priority, event ids. > @@ -40,6 +49,7 @@ Example: > clocks = <&infracfg CLK_INFRA_GCE>; > clock-names = "gce"; > #mbox-cells = <3>; > + #subsys-cells = <3>; > }; > > Example for a client device: > @@ -48,9 +58,9 @@ Example for a client device: > compatible = "mediatek,mt8173-mmsys"; > mboxes = <&gce 0 CMDQ_THR_PRIO_LOWEST 1>, > <&gce 1 CMDQ_THR_PRIO_LOWEST 1>; > - mediatek,gce-subsys = ; > mutex-event-eof = CMDQ_EVENT_MUTEX1_STREAM_EOF>; > - > + mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0x3000 0x1000>, > + <&gce SUBSYS_1401XXXX 0x2000 0x100>; > ... > }; > -- > 2.18.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel