From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1ACCC76186 for ; Tue, 23 Jul 2019 16:34:40 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 84F022184E for ; Tue, 23 Jul 2019 16:34:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="e0iA+rgm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 84F022184E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QG8sOMRaeTGC+kUvZcvYMMgdZblum0Hq8m3FDMmvvCE=; b=e0iA+rgmY1Nopv 5+AYSmZWdNUfwp+iAZu4nPeDCaKaW6nY1Ka7FkjSK05OrQGD91rdDCvLoQemtz7soMzgqf8BkLlIS LXujOLosVvqGLJ30g5E+0VhcLxYh93GNg/UsTy74PrLsDKSJWUVn4d1eB4jyZ+OPYv+xZl2AbTrr8 IaQLdi6CimergI19gnGHQWI2/PUOfhQrQjZmVtAsbh0LZ+AF10xxMBSTeyK+t1pHZk6PAsJN7oiQf dEr27zaMSQtf6vo2KDakAmtdu2PBlMTj15+wtTw4zv6IdzcL0GI4xOhQ/ef9AsrrFztSvwUI4SZBw sS0w9iPsrnWG+PCNz4Bg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hpxkO-0002mo-3Y; Tue, 23 Jul 2019 16:34:40 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hpxkK-0002fl-Ti; Tue, 23 Jul 2019 16:34:38 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 7270068B02; Tue, 23 Jul 2019 18:34:33 +0200 (CEST) Date: Tue, 23 Jul 2019 18:34:33 +0200 From: Christoph Hellwig To: Nicolas Saenz Julienne Subject: Re: [RFC] ARM: bcm2835: register dmabounce on devices hooked to main interconnect Message-ID: <20190723163433.GA2234@lst.de> References: <20190723161934.4590-1-nsaenzjulienne@suse.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190723161934.4590-1-nsaenzjulienne@suse.de> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190723_093437_109740_9ACED587 X-CRM114-Status: UNSURE ( 8.05 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Florian Fainelli , Scott Branden , Ray Jui , Russell King , linux-kernel@vger.kernel.org, Eric Anholt , mbrugger@suse.com, bcm-kernel-feedback-list@broadcom.com, Stefan Wahren , hch@lst.de, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org > +static int bcm2835_needs_bounce(struct device *dev, dma_addr_t dma_addr, size_t size) Too long line.. > +void __init bcm2835_init_early(void) > +{ > + if(of_machine_is_compatible("brcm,bcm2711")) Odd formatting. Otherwise this looks good to me. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel