From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60275C7618B for ; Wed, 24 Jul 2019 14:21:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 363DA22ADB for ; Wed, 24 Jul 2019 14:21:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="svYbM8cw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 363DA22ADB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HT+qkex4+pcQwkQer1owzos3rL+dNa6LxmSbVMHooZw=; b=svYbM8cw+zv/qi qTbojgXyCG878a9a6zIQ8tS5CPkLw2pT4vnaKOPoDID3atsdiq6jFWR8Q3Cj6xm5edyg7bzR/xFtx SLJ8JZqGW+v8hbY08T0lBv+/JfBtbJvTvdxXPzFdBOiTm6XEiZhfH1ng/OjjdkaXeXp/Bp3oWJSNc flFQtjdCFmnoJ0uyLvBerWtngfOtaJEraD/2S8KfwxwG8mtIgvQRQChK00tUP8Z4EdU/SMSb3+U9z mfs69BK10n8eXsbxYRknbbskuUXDB2dvbHPjcDbodgxJjidx9Xtoa4h95M6ieyVwEobwJkrpU4ML/ 8orofsym4PrDLAlhjMkQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hqI8l-0000VJ-9i; Wed, 24 Jul 2019 14:21:11 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hqI8i-0000U4-H4 for linux-arm-kernel@lists.infradead.org; Wed, 24 Jul 2019 14:21:09 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4AFA328; Wed, 24 Jul 2019 07:21:06 -0700 (PDT) Received: from fuggles.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 761323F71A; Wed, 24 Jul 2019 07:21:01 -0700 (PDT) Date: Wed, 24 Jul 2019 15:20:59 +0100 From: Will Deacon To: Andrey Konovalov Subject: Re: [PATCH v19 00/15] arm64: untag user pointers passed to the kernel Message-ID: <20190724142059.GC21234@fuggles.cambridge.arm.com> References: <20190724140212.qzvbcx5j2gi5lcoj@willie-the-truck> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.1+86 (6f28e57d73f2) () X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190724_072108_656494_A075E179 X-CRM114-Status: GOOD ( 20.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , kvm@vger.kernel.org, Christian Koenig , Szabolcs Nagy , Catalin Marinas , dri-devel@lists.freedesktop.org, Kostya Serebryany , Khalid Aziz , Lee Smith , "open list:KERNEL SELFTEST FRAMEWORK" , Vincenzo Frascino , Will Deacon , Jacob Bramley , Leon Romanovsky , linux-rdma@vger.kernel.org, amd-gfx@lists.freedesktop.org, Christoph Hellwig , Jason Gunthorpe , Dmitry Vyukov , Dave Martin , Evgeniy Stepanov , linux-media@vger.kernel.org, Kees Cook , Ruben Ayrapetyan , Kevin Brodsky , Alex Williamson , Mauro Carvalho Chehab , Linux ARM , Linux Memory Management List , Greg Kroah-Hartman , Felix Kuehling , LKML , Jens Wiklander , Ramana Radhakrishnan , Alexander Deucher , Andrew Morton , enh , Robin Murphy , Yishai Hadas , Luc Van Oostenryck Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 24, 2019 at 04:16:49PM +0200, Andrey Konovalov wrote: > On Wed, Jul 24, 2019 at 4:02 PM Will Deacon wrote: > > On Tue, Jul 23, 2019 at 08:03:29PM +0200, Andrey Konovalov wrote: > > > On Tue, Jul 23, 2019 at 7:59 PM Andrey Konovalov wrote: > > > > > > > > === Overview > > > > > > > > arm64 has a feature called Top Byte Ignore, which allows to embed pointer > > > > tags into the top byte of each pointer. Userspace programs (such as > > > > HWASan, a memory debugging tool [1]) might use this feature and pass > > > > tagged user pointers to the kernel through syscalls or other interfaces. > > > > > > > > Right now the kernel is already able to handle user faults with tagged > > > > pointers, due to these patches: > > > > > > > > 1. 81cddd65 ("arm64: traps: fix userspace cache maintenance emulation on a > > > > tagged pointer") > > > > 2. 7dcd9dd8 ("arm64: hw_breakpoint: fix watchpoint matching for tagged > > > > pointers") > > > > 3. 276e9327 ("arm64: entry: improve data abort handling of tagged > > > > pointers") > > > > > > > > This patchset extends tagged pointer support to syscall arguments. > > > > [...] > > > > > Do you think this is ready to be merged? > > > > > > Should this go through the mm or the arm tree? > > > > I would certainly prefer to take at least the arm64 bits via the arm64 tree > > (i.e. patches 1, 2 and 15). We also need a Documentation patch describing > > the new ABI. > > Sounds good! Should I post those patches together with the > Documentation patches from Vincenzo as a separate patchset? Yes, please (although as you say below, we need a new version of those patches from Vincenzo to address the feedback on v5). The other thing I should say is that I'd be happy to queue the other patches in the series too, but some of them are missing acks from the relevant maintainers (e.g. the mm/ and fs/ changes). Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel