From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: patches@arm.linux.org.uk, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: visit mach-* and plat-* directories when cleaning
Date: Thu, 25 Jul 2019 17:46:14 +0100 [thread overview]
Message-ID: <20190725164614.GJ1330@shell.armlinux.org.uk> (raw)
In-Reply-To: <20190718163523.18842-1-yamada.masahiro@socionext.com>
On Fri, Jul 19, 2019 at 01:35:23AM +0900, Masahiro Yamada wrote:
> When you run "make clean" for arm, it never visits mach-* or plat-*
> directories because machine-y and plat-y are just empty.
>
> When cleaning, all machine, plat directories are accumulated to
> machine-, plat-, respectively. So, let's pass them to core- to
> clean up those directories.
You don't say what actual, real-life issue this patch is solving.
Which files are left behind by a "make clean" ?
From what I can see, this only matters if there are extra files that
are generated (and have set extra-* or clean-*). Everything else is
cleaned up via the big find command in the top level makefile.
Or is this a "it would be nice if..." patch?
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> KernelVersion: v5.3-rc1
>
> arch/arm/Makefile | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/Makefile b/arch/arm/Makefile
> index 792f7fa16a24..c3eb0d9a2fdd 100644
> --- a/arch/arm/Makefile
> +++ b/arch/arm/Makefile
> @@ -286,6 +286,10 @@ core-y += arch/arm/net/
> core-y += arch/arm/crypto/
> core-y += $(machdirs) $(platdirs)
>
> +# For cleaning
> +core- += $(patsubst %,arch/arm/mach-%/, $(machine-))
> +core- += $(patsubst %,arch/arm/plat-%/, $(plat-))
> +
> drivers-$(CONFIG_OPROFILE) += arch/arm/oprofile/
>
> libs-y := arch/arm/lib/ $(libs-y)
> --
> 2.17.1
>
>
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-07-25 16:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-18 16:35 [PATCH] ARM: visit mach-* and plat-* directories when cleaning Masahiro Yamada
2019-07-25 16:46 ` Russell King - ARM Linux admin [this message]
2019-07-26 0:20 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190725164614.GJ1330@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@arm.linux.org.uk \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).