From: mirq-test@rere.qmqm.pl
To: Thierry Reding <thierry.reding@gmail.com>
Cc: linux-tegra@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Jon Hunter <jonathanh@nvidia.com>
Subject: Re: [PATCH 1/3] arm64: tegra: Add unit-address for CBB on Tegra194
Date: Fri, 26 Jul 2019 18:04:42 +0200 [thread overview]
Message-ID: <20190726160442.GA22187@qmqm.qmqm.pl> (raw)
In-Reply-To: <20190726101618.26896-1-thierry.reding@gmail.com>
On Fri, Jul 26, 2019 at 12:16:16PM +0200, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> The control back-bone (CBB) starts at physical address 0, so give it a
> unit-address to comply with standard naming practices checked for by the
> device tree compiler.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> .../arm64/boot/dts/nvidia/tegra194-p2888.dtsi | 20 +++++++++----------
> .../boot/dts/nvidia/tegra194-p2972-0000.dts | 2 +-
> arch/arm64/boot/dts/nvidia/tegra194.dtsi | 2 +-
> 3 files changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/nvidia/tegra194-p2888.dtsi b/arch/arm64/boot/dts/nvidia/tegra194-p2888.dtsi
> index 62e07e1197cc..02f6a8f0d741 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra194-p2888.dtsi
> +++ b/arch/arm64/boot/dts/nvidia/tegra194-p2888.dtsi
> @@ -8,17 +8,17 @@
> compatible = "nvidia,p2888", "nvidia,tegra194";
>
> aliases {
> - sdhci0 = "/cbb/sdhci@3460000";
> - sdhci1 = "/cbb/sdhci@3400000";
> + sdhci0 = "/cbb@0/sdhci@3460000";
> + sdhci1 = "/cbb@0/sdhci@3400000";
> serial0 = &tcu;
> i2c0 = "/bpmp/i2c";
> - i2c1 = "/cbb/i2c@3160000";
> - i2c2 = "/cbb/i2c@c240000";
> - i2c3 = "/cbb/i2c@3180000";
> - i2c4 = "/cbb/i2c@3190000";
> - i2c5 = "/cbb/i2c@31c0000";
> - i2c6 = "/cbb/i2c@c250000";
> - i2c7 = "/cbb/i2c@31e0000";
> + i2c1 = "/cbb@0/i2c@3160000";
> + i2c2 = "/cbb@0/i2c@c240000";
> + i2c3 = "/cbb@0/i2c@3180000";
> + i2c4 = "/cbb@0/i2c@3190000";
> + i2c5 = "/cbb@0/i2c@31c0000";
> + i2c6 = "/cbb@0/i2c@c250000";
> + i2c7 = "/cbb@0/i2c@31e0000";
> };
[...]
There are aliases in tegra194.dtsi like gen1_i2c, maybe they could
be used here?
Best Regards,
Michał Mirosław
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-07-26 16:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-26 10:16 [PATCH 1/3] arm64: tegra: Add unit-address for CBB on Tegra194 Thierry Reding
2019-07-26 10:16 ` [PATCH 2/3] arm64: tegra: Add unit-address for ACONNECT " Thierry Reding
2019-07-26 10:16 ` [PATCH 3/3] arm64: tegra: Fix base address for SOR1 " Thierry Reding
2019-07-26 16:04 ` mirq-test [this message]
2019-10-01 14:42 ` [PATCH 1/3] arm64: tegra: Add unit-address for CBB " Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190726160442.GA22187@qmqm.qmqm.pl \
--to=mirq-test@rere.qmqm.pl \
--cc=jonathanh@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox