From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5FFFC7618B for ; Fri, 26 Jul 2019 16:47:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B1A31218B0 for ; Fri, 26 Jul 2019 16:47:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="OI+zL3oQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B1A31218B0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Z6LoFBRfQtwyFUHA7UU4QU4O32iaF0RoSq/7mwx2qmI=; b=OI+zL3oQm5SJ5A 0w8yMZPL9qVHoxsWwZAYCsl9u36ZYg+q7Or3wyHfdEG4pKppsl0mShnZ/VMngtwhTJYBaK8+HvrXD jtE3rWQd0R9nj0qiZ/zf9dXAqVHKpBG/qOOboBZbcEaWAplqNGU4h8GBMHR8GPorTM8lVagR0w9+5 nz+lsq5XAYzXAAeYSGHTG9/YUrbVpIrFAd9Wy5tB/Q1cidsDa9JHfSPqSiKBh41QF6FVYP5FonyWO dU+I+w2GB2bmo+zQhdpgUcoySZl3AXNqgza0QW32hDVLfxO9/+AJiDVXFAWg67c/r/OBa6ISnV/mD 4c3RpO8VItHBjWQMD+ZA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hr3Nr-0008Fr-OV; Fri, 26 Jul 2019 16:47:55 +0000 Received: from relay8-d.mail.gandi.net ([217.70.183.201]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hr3Nn-0008Et-Om for linux-arm-kernel@lists.infradead.org; Fri, 26 Jul 2019 16:47:53 +0000 X-Originating-IP: 109.190.253.11 Received: from localhost (unknown [109.190.253.11]) (Authenticated sender: maxime.ripard@bootlin.com) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 839B91BF207; Fri, 26 Jul 2019 16:47:41 +0000 (UTC) Date: Fri, 26 Jul 2019 18:36:01 +0200 From: Maxime Ripard To: Torsten Duwe Subject: Re: [PATCH v3 6a/7] dt-bindings: Add ANX6345 DP/eDP transmitter binding Message-ID: <20190726163601.o32bxqew5xavjgyi@flea> References: <20190722150414.9F97668B20@verein.lst.de> <20190725151829.DC20968B02@verein.lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190725151829.DC20968B02@verein.lst.de> User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190726_094752_116816_6A114D53 X-CRM114-Status: GOOD ( 20.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, David Airlie , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Andrzej Hajda , Chen-Yu Tsai , Rob Herring , Thierry Reding , Laurent Pinchart , Daniel Vetter , Harald Geyer , Sean Paul , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Icenowy Zheng Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Thu, Jul 25, 2019 at 05:18:29PM +0200, Torsten Duwe wrote: > The anx6345 is an ultra-low power DisplayPort/eDP transmitter designed > for portable devices. > > Add a binding document for it. > > Signed-off-by: Icenowy Zheng > Signed-off-by: Vasily Khoruzhick > Reviewed-by: Rob Herring > Signed-off-by: Torsten Duwe > Reviewed-by: Laurent Pinchart > --- > .../devicetree/bindings/display/bridge/anx6345.yaml | 90 ++++++++++ > 1 file changed, 90 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/bridge/anx6345.yaml > > diff --git a/Documentation/devicetree/bindings/display/bridge/anx6345.yaml b/Documentation/devicetree/bindings/display/bridge/anx6345.yaml > new file mode 100644 > index 000000000000..0af092d101c5 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/bridge/anx6345.yaml > @@ -0,0 +1,90 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/bridge/anx6345.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Analogix ANX6345 eDP Transmitter Device Tree Bindings > + > +maintainers: > + - Torsten Duwe > + > +description: | > + The ANX6345 is an ultra-low power Full-HD eDP transmitter designed for > + portable devices. > + > +properties: > + compatible: > + const: analogix,anx6345 > + > + reg: > + maxItems: 1 > + description: I2C address of the device > + > + reset-gpios: > + maxItems: 1 > + description: active low GPIO to use for reset > + > + dvdd12-supply: > + maxItems: 1 > + description: Regulator for 1.2V digital core power. > + $ref: /schemas/types.yaml#/definitions/phandle > + > + dvdd25-supply: > + maxItems: 1 > + description: Regulator for 2.5V digital core power. > + $ref: /schemas/types.yaml#/definitions/phandle There's no need to specify the type here, all the properties ending in -supply are already checked for that type > + ports: > + type: object > + minItems: 1 > + maxItems: 2 > + description: | > + Video port 0 for LVTTL input, > + Video port 1 for eDP output (panel or connector) > + using the DT bindings defined in > + Documentation/devicetree/bindings/media/video-interfaces.txt You should probably describe the port@0 and port@1 nodes here as well. It would allow you to express that the port 0 is mandatory and the port 1 optional, which got dropped in the conversion. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel