From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF4C0C7618B for ; Mon, 29 Jul 2019 17:50:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A72FD21655 for ; Mon, 29 Jul 2019 17:50:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FPgnv0ly" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A72FD21655 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GCjmBraUp/3S7u2TcVHFifDR4PAlf6UZdkqlVwozGW4=; b=FPgnv0lyMmfQas XFd+MkGBjCvXqyJj38Qz/bJkeFTuaDv+wAgiyZ/TJtSHoUmXbFgeSgwV9HFZ4mTGsJmrp2ts59lpt Gx9H/wVW73ONO3GctwvVrGk9OMqj1iECb0y731CxWUdQiXLSr1Z0JxLmegbj7Ol2zgIWxYmsdP9sN +PprwqVuIlvdz7J7/UIBY0wfKj8bHFqVYC7ajy9USUDKr5dn6R5Pk2cMYrz90P7QR8W6Tia2rpGNQ Me21gxHL//Fg+ocMMsXHaLette8cRcHNIjQxBZ4uvK/+jANpnghENFmP6I2FjnInV3jw0sM9uT28o TAuRdipgneut3pGAXAEQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hs9mx-0003J9-L6; Mon, 29 Jul 2019 17:50:23 +0000 Received: from asavdk3.altibox.net ([109.247.116.14]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hs9mu-0003Ig-88; Mon, 29 Jul 2019 17:50:21 +0000 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 09E6A20037; Mon, 29 Jul 2019 19:50:12 +0200 (CEST) Date: Mon, 29 Jul 2019 19:50:11 +0200 From: Sam Ravnborg To: "Koenig, Christian" Subject: Re: [PATCH v1 02/11] drm: drop uapi dependency from drm_print.h Message-ID: <20190729175011.GA1753@ravnborg.org> References: <20190718161507.2047-1-sam@ravnborg.org> <20190718161507.2047-3-sam@ravnborg.org> <156346840026.24728.936589728458336617@skylake-alporthouse-com> <460bf1e1-a38b-5f79-26e5-93764067f4e1@amd.com> <87tvb5nh5c.fsf@intel.com> <20190729143555.GA16927@ravnborg.org> <67c2807f-582c-49a9-5699-a8baab3d3a0f@amd.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <67c2807f-582c-49a9-5699-a8baab3d3a0f@amd.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=dqr19Wo4 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=z97LkYvmAAAA:8 a=PK4PtuwWHWNUZtMXVD8A:9 a=CjuIK1q_8ugA:10 a=vIYCe-biKPAlS5OZFR2a:22 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190729_105020_470882_7C3FC45B X-CRM114-Status: GOOD ( 15.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Maxime Ripard , Boris Brezillon , Jani Nikula , Daniel Vetter , Intel Graphics Development , Liviu Dudau , "dri-devel@lists.freedesktop.org" , Chris Wilson , David Airlie , "linux-mediatek@lists.infradead.org" , Thomas Zimmermann , Matthias Brugger , Sean Paul , Thierry Reding , Sean Paul , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Christian. On Mon, Jul 29, 2019 at 03:28:15PM +0000, Koenig, Christian wrote: > Am 29.07.19 um 16:35 schrieb Sam Ravnborg: > >>>> Even then it so useless (which drm driver is this message for???) that I > >>>> want to remove them all :( > >>> Yeah, agree. I mean it is nice if the core drm functions use a prefix > >>> for debug output. > >>> > >>> But I actually don't see the point for individual drivers. > >> We should all migrate to the versions with device... > > Just to do an xkdc.com/927 I have considered: > > > > drm_err(const struct drm_device *drm, ...) > > drm_info(const struct drm_device *drm, ...) > > > > drm_kms_err(const struct drm_device *drm, ...) > > drm_kms_info(const struct drm_device *drm, ...)) > > Why not get completely rid of those and just use dev_err, dev_warn, > pr_err, pr_warn etc? > > I mean is it useful to have this extra printing subsystem in DRM while > the standard Linux one actually does a better job? The added functionality of drm_xxx_err would be to keep the current drm.debug=0x1f filtering on the command-line. I do not think we can do this with the standard logging. And then we can prefix every logging with driver name and device name. The idea is to make a thin layer on top of the existing pr_xxx() functions. So not a full subsystem, only a wrapper on top of what we already have. Anyway, idle talk only. We need patches and sample output if we should discuss more. Sam _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel