From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB560C433FF for ; Tue, 30 Jul 2019 11:02:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8116F206E0 for ; Tue, 30 Jul 2019 11:02:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qqGvC4sR"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="II2UQgX8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8116F206E0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=65fwW1f0TAwGXgYStQAYXYzOdhxhCAdekHBgxl99/No=; b=qqGvC4sRr7EttZ Od/AnYUJRi3WfDFnzram4P2foe2XGqM2DFSfrPzRg6LF2nozfI9NSrfkQT0I8WyO0sTXaBHOSGULS TU460jLWJx2Ae9LQ1gmUgiYkpoSb8mcUWAN2heuVYbge8FoVQDbT8zucx3X4oZLpTV0pv8KnQhb5X 5yyHR2EGivazrOd2gkGlU+Keiy/mVKpLzeRO078UZtkYLYFD5xbV5PjvuTgWkFJ2dzD0TKLnmq+OS ok8QWYGgP/rT5r240GFj9PS6YN+qMNOjYmnBzsXXX6t6R0de6vmg9+vyfeFkCzSZed9bQA6j2LkcR tjw+dOVT4bBcwJ40FWRg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hsPtZ-0004QI-47; Tue, 30 Jul 2019 11:02:17 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:3201:214:fdff:fe10:1be6]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hsPtW-0004Pt-DF for linux-arm-kernel@lists.infradead.org; Tue, 30 Jul 2019 11:02:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=8Evoy48nmtUEP14ctAQrisi69YEAvFPcmML655E68VU=; b=II2UQgX8QgyPk2rVNFmil7JY1 uB8ScT1LS9EKcqeuufjFZPGQHBCGq5NDRxZBJBaXqCQ/bj016eTD91oTWLkSHmPkt2E0CxcGMeSDz N0AdSJpiaJScXQ2RHpOC6IvlTccsnrPmLDIeRV9p5zbcqo5SCAK6EwczYqHP2xplWOv4qUo3B/G63 4dCpkKJGFvdkWcv2wNtpJJN3F6hinOlBNxC3vPVeIgvSdvZsqTAbTookueqlGysXz2k8FKBcGmf2w 7pNNW7qAA8ApAhs/2AiMWi+lKlNabz9p0vFBn+RqJzsalZBwUuJ4yYSR29yC4uI635Pns124FYkGE QRyuhmejw==; Received: from shell.armlinux.org.uk ([2001:4d48:ad52:3201:5054:ff:fe00:4ec]:38834) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1hsPtR-0004nx-SN; Tue, 30 Jul 2019 12:02:10 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1hsPtM-00029s-Tn; Tue, 30 Jul 2019 12:02:04 +0100 Date: Tue, 30 Jul 2019 12:02:04 +0100 From: Russell King - ARM Linux admin To: Chunyan Zhang Subject: Re: [PATCH] ARM: check stmfd instruction using right shift Message-ID: <20190730110204.GB1330@shell.armlinux.org.uk> References: <20190722071122.22434-1-zhang.lyra@gmail.com> <20190722071419.22535-1-zhang.lyra@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190730_040214_453847_C58FD646 X-CRM114-Status: GOOD ( 16.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux Kernel Mailing List , Linux ARM , Lvqiang Huang Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 30, 2019 at 03:18:31PM +0800, Chunyan Zhang wrote: > Gentle ping > > probably this patch was missed or entered into spam? Please submit it to the patch system, thanks. > > On Mon, 22 Jul 2019 at 15:14, Chunyan Zhang wrote: > > > > From: Lvqiang Huang > > > > In the commit ef41b5c92498 ("ARM: make kernel oops easier to read"), > > - .word 0xe92d0000 >> 10 @ stmfd sp!, {} > > + .word 0xe92d0000 >> 11 @ stmfd sp!, {} > > then the shift need to change to 11. > > > > Fixes: ef41b5c92498 ("ARM: make kernel oops easier to read") > > Signed-off-by: Lvqiang Huang > > Signed-off-by: Chunyan Zhang > > --- > > arch/arm/lib/backtrace.S | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm/lib/backtrace.S b/arch/arm/lib/backtrace.S > > index 7d7952e..926851b 100644 > > --- a/arch/arm/lib/backtrace.S > > +++ b/arch/arm/lib/backtrace.S > > @@ -70,7 +70,7 @@ for_each_frame: tst frame, mask @ Check for address exceptions > > > > 1003: ldr r2, [sv_pc, #-4] @ if stmfd sp!, {args} exists, > > ldr r3, .Ldsi+4 @ adjust saved 'pc' back one > > - teq r3, r2, lsr #10 @ instruction > > + teq r3, r2, lsr #11 @ instruction > > subne r0, sv_pc, #4 @ allow for mov > > subeq r0, sv_pc, #8 @ allow for mov + stmia > > > > -- > > 1.7.9.5 > > > -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel