From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B92CAC0650F for ; Tue, 30 Jul 2019 17:52:41 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8C31E206A2 for ; Tue, 30 Jul 2019 17:52:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dOkW1bY4"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="PviEB+rS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8C31E206A2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject:To:From: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LINDUcK/hKVOH6e2J7juExjhfjcZxhsned08sLS9ebA=; b=dOkW1bY4xh++Iq lFCNcRn4l34nF/H5F/qNMcK11pX/S9HpXY+Pahm0l/C4iXnm2vPsYWpjBB/qcnQU7c0e53dtrFtVy RjPQlHxtKlpRigpYwXrxVhrCqN4UpKysJw5JcgDADBd6DKqDYsNvzi8/wK7BM5vpDMxCXYFVhMNOI f6cYz60Vxt3w4pVaBZc4VUYdYHfHh1Ry44JoTKV3l8MT0golEk9dsl/jha8ephg0Wod4/O3nsD6kl 4DNfS+qfANLJhccztuM/lu+Fl0QgAng+cEUFW5y9Wv6Q+gv/AIOp1HbrtvR9XzKtMjHtL+PR65QNF TY9oY4GcnegTs92mI+Zw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hsWId-0000Eh-BD; Tue, 30 Jul 2019 17:52:35 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hsWIa-0000EN-8O for linux-arm-kernel@lists.infradead.org; Tue, 30 Jul 2019 17:52:33 +0000 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B05ED206A2; Tue, 30 Jul 2019 17:52:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564509151; bh=mnne8HxkQYHe1hsp9tyTFqKx/kwox+EaL9FZPw5xrLU=; h=In-Reply-To:References:Cc:From:To:Subject:Date:From; b=PviEB+rSjDPmiHO/Yq0dWjVAOp2oJKwQX9me32xE8qnRaY4vcp6VXD9TaqQdYmTiz ln6GlNsOYWGOdRGyDiUhz2drXlXhkkcvjY0ACUNFUINHjE6tXDr653RDKRsPX2TMzK 1/lEHd5bTXmNCc2xx2tT19fNHCOEaM5YMIH1VuSo= MIME-Version: 1.0 In-Reply-To: <1564471375-6736-1-git-send-email-abel.vesa@nxp.com> References: <1564471375-6736-1-git-send-email-abel.vesa@nxp.com> From: Stephen Boyd To: Abel Vesa , Anson Huang , Fabio Estevam , Guido Gunther , Mike Turquette , Sascha Hauer , Shawn Guo Subject: Re: [PATCH v3] clk: imx8mq: Mark AHB clock as critical User-Agent: alot/0.8.1 Date: Tue, 30 Jul 2019 10:52:30 -0700 Message-Id: <20190730175231.B05ED206A2@mail.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190730_105232_319829_A2EC317C X-CRM114-Status: UNSURE ( 9.69 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Abel Vesa , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linux Kernel Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Abel Vesa (2019-07-30 00:22:55) > Initially, the TMU_ROOT clock was marked as critical, which automatically > made the AHB clock to stay always on. Since the TMU_ROOT clock is not > marked as critical anymore, following commit: > > 431bdd1df48e ("clk: imx8mq: Remove CLK_IS_CRITICAL flag for IMX8MQ_CLK_TMU_ROOT") > > all the clocks that derive from ipg_root clock (and implicitly ahb clock) > would also have to enable, along with their own gate, the AHB clock. > > But considering that AHB is actually a bus that has to be always on, we mark > it as critical in the clock provider driver and then all the clocks that > derive from it can be controlled through the dedicated per IP gate which > follows after the ipg_root clock. > > Signed-off-by: Abel Vesa > Tested-by: Daniel Baluta > Fixes: 431bdd1df48e ("clk: imx8mq: Remove CLK_IS_CRITICAL flag for IMX8MQ_CLK_TMU_ROOT") > --- > Should I just apply this to clk-fixes branch? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel