From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4872FC0650F for ; Tue, 30 Jul 2019 18:19:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1D85A2171F for ; Tue, 30 Jul 2019 18:19:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="c6UECS1x"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="mZqGk/cU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1D85A2171F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=251q3DuLuQ+2Zr+mc23YbkHXGFjuKY3UnbfZcDPhMac=; b=c6UECS1xy7h3UW pVYrhjM+inTfyAypTpoTRvUaJJv2EpnN31IH7ESHaFZZt3a2w3SH5++UH1ovWc2qU/Lo/fEPA1dO3 5nr1IRxz1ROEIA0OqrY0ERApI3h+IUfEHcqPCxDh3GGaD78LCp5safGLC9GJe83luQpnVaRDMiOcO KkHxY0Ypj41w9sV1VDbwEk0u9DWqMCLcZIytQ7Z9XZjXbL2+V41upWS9G4VJmUq8PxB4afLt87CzQ /0op8pbhg7wejVB49tlYUqJyDZXCnGPK3S8lvf0A287JF46iONTk2UM1WjFVZb29MOxCNkMMjX6Fn iBchDwmGT/d8IZgWHc9A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hsWiZ-0002jD-LE; Tue, 30 Jul 2019 18:19:23 +0000 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hsWiV-0002i7-Mg for linux-arm-kernel@lists.infradead.org; Tue, 30 Jul 2019 18:19:20 +0000 Received: by mail-pf1-x443.google.com with SMTP id c3so7125767pfa.13 for ; Tue, 30 Jul 2019 11:19:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=WYV3lJkZz1M8QFLTNcbisKstq4q45qxIoF6vMekR4Ik=; b=mZqGk/cUp6ZNJEsrEHgluVspbQqD/bx8uYW6vGDU/FpCW5W4GoxK+4/b1HjJ4bSDCq xyW3ZS0uf0DfYXzWcHQIeKMfCqgFrRDayoLgDTv4QOWbhe8Raxi6hVsR1bQ6j1+njf6I kMOQ/nc0tCcPOfurVrxe/F1hJnYiinkBApcH4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=WYV3lJkZz1M8QFLTNcbisKstq4q45qxIoF6vMekR4Ik=; b=eQ/Js28m+4E1fY+NPY8qD5lm+OcSWdPyoHq5tfG45j6QNLJJGVzNSfPH/no9YKuJBY ICMpAwPmCvlvjwzyOjYXLLBlh4x3y+8ND1TiyCrVKHQN3q7rlR8nl4RNyiTPIjDrt17S oVtcGO+tmBOFiN2QgAGSQQbr01OKOT1OIz6GirqYRpuk/tJBeGngbaB76snUblWva+3R KkI3TGgpJb28d4tAIy77zgwVL5nLEBHAX0D0rKBP1a1TgFl4fHqOZEqkLnmfbbBKB2cB f25JBCNmNMws6g9rRfGJh+yJfucy51KMN9mMNo7ESYXwX1eVBZuI3C6wot5xP3I450HJ dZuw== X-Gm-Message-State: APjAAAWxwXeiPC/oOaKlRDsz6E0RNa4FRS/aiPkDLkAzPuovWEOztC1L 7+o2A5NFDMdqVX2pLmpSqcmTjA== X-Google-Smtp-Source: APXvYqw4/yqmb0Rlt+53Fv5Ar1d4LMo3nzvzPjOQ1bEXUP20GHFA0n4fefD4ezGXYZ/+3e25mhoUqg== X-Received: by 2002:a17:90a:360c:: with SMTP id s12mr120028251pjb.30.1564510759254; Tue, 30 Jul 2019 11:19:19 -0700 (PDT) Received: from localhost ([2620:15c:202:1:75a:3f6e:21d:9374]) by smtp.gmail.com with ESMTPSA id h12sm79833057pje.12.2019.07.30.11.19.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 30 Jul 2019 11:19:18 -0700 (PDT) Date: Tue, 30 Jul 2019 11:19:16 -0700 From: Matthias Kaehlcke To: Doug Anderson Subject: Re: [PATCH] ARM: dts: rockchip: A few fixes for veyron-{fievel, tiger} Message-ID: <20190730181916.GJ250418@google.com> References: <20190730173444.56741-1-mka@chromium.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190730_111919_740057_C63DAF5F X-CRM114-Status: GOOD ( 15.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Heiko Stuebner , LKML , "open list:ARM/Rockchip SoC..." , Rob Herring , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 30, 2019 at 11:01:42AM -0700, Doug Anderson wrote: > Hi, > > On Tue, Jul 30, 2019 at 10:34 AM Matthias Kaehlcke wrote: > > > > @@ -130,12 +138,13 @@ > > regulator-max-microvolt = <1800000>; > > regulator-name = "vdd18_lcdt"; > > regulator-state-mem { > > - regulator-on-in-suspend; > > + regulator-off-in-suspend; > > regulator-suspend-microvolt = <1800000>; > > Please remove "regulator-suspend-microvolt = <1800000>;" which doesn't > make sense once you have "regulator-off-in-suspend". will remove all instances > > }; > > }; > > > > - /* This is not a pwren anymore, but the real power supply, > > + /* > > + * This is not a pwren anymore, but the real power supply, > > * vdd10_lcd for HDMI_AVDD_1V0 > > */ > > vdd10_lcd: LDO_REG7 { > > @@ -145,7 +154,7 @@ > > regulator-max-microvolt = <1000000>; > > regulator-name = "vdd10_lcd"; > > regulator-state-mem { > > - regulator-on-in-suspend; > > + regulator-off-in-suspend; > > regulator-suspend-microvolt = <1000000>; > > Please remove "regulator-suspend-microvolt = <1000000>;" which doesn't > make sense once you have "regulator-off-in-suspend". > > > > }; > > > > @@ -159,7 +168,7 @@ > > regulator-max-microvolt = <3300000>; > > regulator-name = "vcc33_ccd"; > > regulator-state-mem { > > - regulator-on-in-suspend; > > + regulator-off-in-suspend; > > regulator-suspend-microvolt = <3300000>; > > Please remove "regulator-suspend-microvolt = <3300000>;" which doesn't > make sense once you have "regulator-off-in-suspend". > > > Other than those things, this patch looks good to me and feel free to > add my Reviewed-by. Thanks for your review! > NOTE: when I tried applying this to my tree git > complained and I had to apply manually. Could you try sending this > patch atop Heiko's for-next tree? The yell I got: > > error: sha1 information is lacking or useless > (arch/arm/boot/dts/rk3288-veyron-fievel.dts). > error: could not build fake ancestor Ok, I'll rebase v2 on Heiko's for-next _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel