From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8486C32751 for ; Wed, 31 Jul 2019 11:40:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AE12A217D4 for ; Wed, 31 Jul 2019 11:40:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PI5N+O55" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AE12A217D4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=axur0QX/d0izisrsv0JhruJyKervZ8aHPBLkbRgJFo0=; b=PI5N+O55vS95Gm 12N95Eq1eRWpFCAfEIO28HGeIsl4xD2Hlst2GhXG2xzDDMKcNz+21xFfkIgpJQWQDgu3lN29NUplx oBlEugWUm7K7TXPFO40STx/rgBh+LJU2Da42zjZxZkJcsAz11XoPY6QFdmYQvnDY24Vao4mLRNL+J poV5AzSCNulSpRp5QuL6bmDb+XSabeNQgcn5EMuSwmNxtWzMEHh1PofceXgIjqBTPlbLTMPoITqHW kAPnCqDVFsowRnyjsWxQ4yijE9W/Ys5klIuLQvuo82jx8JnTEytMNQY813Bsogq/M7vYe9vxnX7gb 9u/NSbGfuZQCV/jI1xqg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hsmxz-0002be-JS; Wed, 31 Jul 2019 11:40:23 +0000 Received: from mx2.suse.de ([195.135.220.15] helo=mx1.suse.de) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hsmxv-0002U5-Qs for linux-arm-kernel@lists.infradead.org; Wed, 31 Jul 2019 11:40:21 +0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 4AF45AF04; Wed, 31 Jul 2019 11:40:17 +0000 (UTC) Date: Wed, 31 Jul 2019 13:40:16 +0200 From: Michal Hocko To: Mike Rapoport Subject: Re: [PATCH v2 0/5] mm: Enable CONFIG_NODES_SPAN_OTHER_NODES by default for NUMA Message-ID: <20190731114016.GI9330@dhcp22.suse.cz> References: <20190712070247.GM29483@dhcp22.suse.cz> <586ae736-a429-cf94-1520-1a94ffadad88@os.amperecomputing.com> <20190712121223.GR29483@dhcp22.suse.cz> <20190712143730.au3662g4ua2tjudu@willie-the-truck> <20190712150007.GU29483@dhcp22.suse.cz> <730368c5-1711-89ae-e3ef-65418b17ddc9@os.amperecomputing.com> <20190730081415.GN9330@dhcp22.suse.cz> <20190731062420.GC21422@rapoport-lnx> <20190731080309.GZ9330@dhcp22.suse.cz> <20190731111422.GA14538@rapoport-lnx> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190731111422.GA14538@rapoport-lnx> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190731_044020_168671_A45194B3 X-CRM114-Status: GOOD ( 19.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Benjamin Herrenschmidt , Heiko Carstens , "open list:MEMORY MANAGEMENT" , Paul Mackerras , "H . Peter Anvin" , "sparclinux@vger.kernel.org" , Alexander Duyck , Will Deacon , "linux-s390@vger.kernel.org" , Michael Ellerman , "x86@kernel.org" , "willy@infradead.org" , Christian Borntraeger , Ingo Molnar , Hoan Tran OS , Catalin Marinas , Open Source Submission , Pavel Tatashin , Vasily Gorbik , Will Deacon , Borislav Petkov , Thomas Gleixner , Vlastimil Babka , Oscar Salvador , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Andrew Morton , "linuxppc-dev@lists.ozlabs.org" , "David S . Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed 31-07-19 14:14:22, Mike Rapoport wrote: > On Wed, Jul 31, 2019 at 10:03:09AM +0200, Michal Hocko wrote: > > On Wed 31-07-19 09:24:21, Mike Rapoport wrote: > > > [ sorry for a late reply too, somehow I missed this thread before ] > > > > > > On Tue, Jul 30, 2019 at 10:14:15AM +0200, Michal Hocko wrote: > > > > [Sorry for a late reply] > > > > > > > > On Mon 15-07-19 17:55:07, Hoan Tran OS wrote: > > > > > Hi, > > > > > > > > > > On 7/12/19 10:00 PM, Michal Hocko wrote: > > > > [...] > > > > > > Hmm, I thought this was selectable. But I am obviously wrong here. > > > > > > Looking more closely, it seems that this is indeed only about > > > > > > __early_pfn_to_nid and as such not something that should add a config > > > > > > symbol. This should have been called out in the changelog though. > > > > > > > > > > Yes, do you have any other comments about my patch? > > > > > > > > Not really. Just make sure to explicitly state that > > > > CONFIG_NODES_SPAN_OTHER_NODES is only about __early_pfn_to_nid and that > > > > doesn't really deserve it's own config and can be pulled under NUMA. > > > > > > > > > > Also while at it, does HAVE_MEMBLOCK_NODE_MAP fall into a similar > > > > > > bucket? Do we have any NUMA architecture that doesn't enable it? > > > > > > > > > > > > HAVE_MEMBLOCK_NODE_MAP makes huge difference in node/zone initialization > > > sequence so it's not only about a singe function. > > > > The question is whether we want to have this a config option or enable > > it unconditionally for each NUMA system. > > We can make it 'default NUMA', but we can't drop it completely because > microblaze uses sparse_memory_present_with_active_regions() which is > unavailable when HAVE_MEMBLOCK_NODE_MAP=n. I suppose you mean that microblaze is using sparse_memory_present_with_active_regions even without CONFIG_NUMA, right? I have to confess I do not understand that code. What is the deal with setting node id there? -- Michal Hocko SUSE Labs _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel