From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A9E5C32751 for ; Wed, 31 Jul 2019 16:54:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2F8F0206B8 for ; Wed, 31 Jul 2019 16:54:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LrybyTRk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2F8F0206B8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sigxcpu.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ua3soKr+tA2dBWp/JlCtSaOFX1Iyl2ag6Sq+yslH1pA=; b=LrybyTRkQq6Cq7 p8sXQ7P6GheNH1n19QFxPQMaTpCOh5xDNbH4nIvt7RXYxDubn73L7iM0+ihX3WaEX48HDo2XqfTbh f1BDjpn1XrtQ3KK3vdFY29XprTbvjEtOU9abcDMLUGpTNCR4HNYfKf7MqevN8ToSJTsvXYmV1jDop 8lQKYRkv3/A82KTcf92Q95EsGJKYvF/EXvVZAXsXXsyAN0yoC5WoOIn1pHqdDJ5SKmo9esILjOz0w 3kUPQKK9OeKhZ/a+oRn7ShZvBYJrGZZ31vYUVMbinZL8oQdI0tA/pPjf2719p765+Lc+I3Lm9hlFL RyBHAb68BkJm2KtWNv7w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hsrrc-0004WN-Ny; Wed, 31 Jul 2019 16:54:08 +0000 Received: from honk.sigxcpu.org ([24.134.29.49]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hsrrZ-0004Vf-K7 for linux-arm-kernel@lists.infradead.org; Wed, 31 Jul 2019 16:54:07 +0000 Received: from localhost (localhost [127.0.0.1]) by honk.sigxcpu.org (Postfix) with ESMTP id AF4D4FB03; Wed, 31 Jul 2019 18:54:02 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at honk.sigxcpu.org Received: from honk.sigxcpu.org ([127.0.0.1]) by localhost (honk.sigxcpu.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WqV7ea2juLfn; Wed, 31 Jul 2019 18:54:01 +0200 (CEST) Received: by bogon.sigxcpu.org (Postfix, from userid 1000) id 9B60D46D8A; Wed, 31 Jul 2019 18:54:00 +0200 (CEST) Date: Wed, 31 Jul 2019 18:54:00 +0200 From: Guido =?iso-8859-1?Q?G=FCnther?= To: Fabio Estevam Subject: Re: [PATCH 3/3] drm/bridge: Add NWL MIPI DSI host controller support Message-ID: <20190731165400.GA30745@bogon.m.sigxcpu.org> References: <3158f4f8c97c21f98c394e5631d74bc60d796522.1563983037.git.agx@sigxcpu.org> <20190731143532.GA1935@bogon.m.sigxcpu.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190731_095405_821277_F32D7367 X-CRM114-Status: GOOD ( 17.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Jernej Skrabec , Pengutronix Kernel Team , Neil Armstrong , David Airlie , Lee Jones , Sascha Hauer , Jonas Karlman , linux-kernel , DRI mailing list , Andrzej Hajda , Rob Herring , NXP Linux Team , Daniel Vetter , Robert Chiras , Chris Healy , Shawn Guo , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Laurent Pinchart Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Wed, Jul 31, 2019 at 11:43:47AM -0300, Fabio Estevam wrote: > Hi Guido, > = > On Wed, Jul 31, 2019 at 11:35 AM Guido G=FCnther wrote: > = > > The idea is to have > > > > "%sabling platform clocks", enable ? "en" : "dis"); > > > > depending whether clocks are enabled/disabled. > = > Yes, I understood the idea, but this would print: > = > ensabling or dissabling :-) The 's' is from the '%s' format specifier: [ 2610.804174] imx-nwl-dsi 30a00000.mipi_dsi: [drm:imx_nwl_dsi_bridge_disab= le] disabling platform clocks [ 2710.996279] imx-nwl-dsi 30a00000.mipi_dsi: [drm:imx_nwl_dsi_bridge_pre_e= nable] enabling platform clocks I'll change that to use the full strings though since i also had to look twice to be sure there's no double 's'. > = > > > Same here. Please return 'int' instead. > > > > This is from drm_bridge_funcs so the prototype is fixed. I'm not sure > > how what's the best way to bubble up fatal errors through the drm layer? > = > Ok, so let's not change this one. > = > > I went for DRM_DEV_ERROR() since that what i used in the rest of the > > driver and these ones were omission. Hope that's o.k. > = > No strong preferences here. I just think dev_err() easier to type and sho= rter. > = > Thanks for this work! Thanks again for having a look! -- Guido _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel