From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: "Uwe Kleine-König" <uwe@kleine-koenig.org>
Cc: Andrew Lunn <andrew@lunn.ch>, Jason Cooper <jason@lakedaemon.net>,
Oliver Hartkopp <socketcan@hartkopp.net>,
Gregory Clement <gregory.clement@bootlin.com>,
tbm@cyrius.com, linux-arm-kernel@lists.infradead.org,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH v2] ARM: kirkwood: ts219: disable the SoC's RTC
Date: Thu, 1 Aug 2019 22:23:25 +0200 [thread overview]
Message-ID: <20190801202325.GA3237@piout.net> (raw)
In-Reply-To: <20190731223233.GA15900@taurus.defre.kleine-koenig.org>
On 01/08/2019 00:32:33+0200, Uwe Kleine-König wrote:
> The internal RTC doesn't work, loading the driver only yields
>
> rtc-mv f1010300.rtc: internal RTC not ticking
>
> . So disable it.
>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>
Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> ---
> Hello,
>
> This patch is (one) result of a discussion on the rtc list. v1 was sent
> there only. This v2 is just a resend to the mvebu maintainers.
>
> Alexandre Belloni said to v1: Seems good to me then.
>
> This sounds a bit like an ack, but I didn't add it as it was not
> explicit.
>
> Best regards
> Uwe
>
> arch/arm/boot/dts/kirkwood-ts219.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/kirkwood-ts219.dtsi b/arch/arm/boot/dts/kirkwood-ts219.dtsi
> index a88eb22070a1..994cabcf4b51 100644
> --- a/arch/arm/boot/dts/kirkwood-ts219.dtsi
> +++ b/arch/arm/boot/dts/kirkwood-ts219.dtsi
> @@ -104,3 +104,11 @@
> &pcie0 {
> status = "okay";
> };
> +
> +&rtc {
> + /*
> + * There is a s35390a available on the i2c bus, the internal rtc isn't
> + * working (probably no crystal assembled).
> + */
> + status = "disabled";
> +};
> --
> 2.20.1
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-08-01 20:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 22:32 [PATCH v2] ARM: kirkwood: ts219: disable the SoC's RTC Uwe Kleine-König
2019-08-01 15:30 ` Martin Michlmayr
2019-08-01 20:23 ` Alexandre Belloni [this message]
2019-08-27 13:47 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190801202325.GA3237@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=gregory.clement@bootlin.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=socketcan@hartkopp.net \
--cc=tbm@cyrius.com \
--cc=uwe@kleine-koenig.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).