From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6973C19759 for ; Sun, 4 Aug 2019 15:51:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7DB3E2086D for ; Sun, 4 Aug 2019 15:51:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jEX+iVzn"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AFuW0mPA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7DB3E2086D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=WIxOyrGoLyA2wFY4SN6BH+hA38Wi85Jv5k7MwIqQPfw=; b=jEX+iVznoGBzGj kbfO7Yy7fRVmP9tA/zXl/He7Zi/mTXcgyZcsa9OJUsGGFp6GZWqKeqL3+43TCQ27WO9uHqFrr3PDQ E8uWEl2VlXsniPFF8HLUAbFaaV7JbS5jiz/COwnQO/ZXROX2EWun74hRm/23v4WR4UlNsgUXIVF+J F0ARq118qdaN5tcKKjutQFqMKqgJyyimQwFAdbbv6ggvnouv9Wx6Pcn0cgb2Erf+i5zwPB85GWHFX OM/I93AsDE7gMs2uA5YX79X2zXRyA+SH1bPRfNMMiRaQsrR1TRGaOHeS3Uv0fPHvqqC1U6UBp4AKE Zzzr/ZVfPIyaVRMRKMPA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1huInG-0004wg-28; Sun, 04 Aug 2019 15:51:34 +0000 Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1huInD-0004wL-0b for linux-arm-kernel@lists.infradead.org; Sun, 04 Aug 2019 15:51:32 +0000 Received: by mail-pg1-x543.google.com with SMTP id t132so38398056pgb.9 for ; Sun, 04 Aug 2019 08:51:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=G566TvMGpbyrdmyi4hISjE0RUzXp80LgC28v/uH1er0=; b=AFuW0mPAQQYFBknjv5dxX5YJPxWPoJ2Qfe5i7zEZgRxcOeSE6JU2bSdOWbdNT82vWM hUeTP7u40svoS1JlouZgRMA/zB7d0SHasxVXBnJZ/gKcGlDfFrreFBOUV9zkCdYU290d +UPhqSePdCEmAyv9fJEY8ZVo8TM4ByjAO3JB57Dvf96FWtIXGjTTkjG6pg3cADR09gJm QmpXchjOSpbqPSKJXts7fy0Hlz8NW9yDVBsbo8v7cR/HgiVH3Se41hRxvKSHnKem5IHW jUUfI6MZ+BKboqPkq8RqybbyJJ/Tv/xcube2e1ScW2VMIO2ZTZmGtTwv7eyU2VAdHZcS Ii7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=G566TvMGpbyrdmyi4hISjE0RUzXp80LgC28v/uH1er0=; b=a35SXNn6lwdkQC9XET/mqnRGIo9xiiSOaIjharVthQ5f70G0syFAvRGEi9AvwY2uer Mkq5MDm6vqJ2Hq+zdh8KOQNVgQh9CAJU7fMVSF4X4Hoc/L17UiLDwaWES53tuT5kQccy tj/9zi/vE7HbPhgqEXsZubi1VEymosvqj3rXAOeOiEuu0V/GLoqGmnJ7QDKWhHKe29BT 53UPjxXfIbc64UfdgmvCXBZaaAUMx67OgoFYOioPA8RCZ4Ncjkl1v/XtGuxwrzc0JWYH 0G648mt6lySXGJLT0ZQN+hd0sU5k8Zcd+/bdR8Jupzgue2MD9UU03dh6MkpNpQ5/xHdv NSig== X-Gm-Message-State: APjAAAUHqPl/0dx12+hjchOZTEYy9MPDofL2ojK6ash+vA4a9Ybln47q NbnHIrrgWUZcXJbyX3JYUfw= X-Google-Smtp-Source: APXvYqz1/RqGvqOaq+vIHHUhQ3GgCLYpN/7ITTw1Ara3qOA6y2TFX6ICY3SOhJo5Urgs13o+W7g1Iw== X-Received: by 2002:aa7:8641:: with SMTP id a1mr69489669pfo.177.1564933889558; Sun, 04 Aug 2019 08:51:29 -0700 (PDT) Received: from localhost.localdomain ([122.163.105.8]) by smtp.gmail.com with ESMTPSA id t8sm13080369pji.24.2019.08.04.08.51.27 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Sun, 04 Aug 2019 08:51:29 -0700 (PDT) From: Nishka Dasgupta To: linus.walleij@linaro.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org Subject: [PATCH] pinctrl: nomadik: nomadik: Add of_node_put() before return Date: Sun, 4 Aug 2019 21:21:17 +0530 Message-Id: <20190804155117.4753-1-nishkadg.linux@gmail.com> X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190804_085131_055686_41120FDD X-CRM114-Status: UNSURE ( 9.77 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nishka Dasgupta Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Each iteration of for_each_child_of_node puts the previous node, but in the case of a return from the middle of the loop, there is no put, thus causing a memory leak. Hence add an of_node_put before the return. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta --- drivers/pinctrl/nomadik/pinctrl-nomadik.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pinctrl/nomadik/pinctrl-nomadik.c b/drivers/pinctrl/nomadik/pinctrl-nomadik.c index ddd1f466d302..2a8190b11d10 100644 --- a/drivers/pinctrl/nomadik/pinctrl-nomadik.c +++ b/drivers/pinctrl/nomadik/pinctrl-nomadik.c @@ -1508,6 +1508,7 @@ static int nmk_pinctrl_dt_node_to_map(struct pinctrl_dev *pctldev, &reserved_maps, num_maps); if (ret < 0) { pinctrl_utils_free_map(pctldev, *map, *num_maps); + of_node_put(np); return ret; } } -- 2.19.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel