From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94CAEC433FF for ; Mon, 5 Aug 2019 10:54:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6B11A20880 for ; Mon, 5 Aug 2019 10:54:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Ft8ZsFRr"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="o1GVXvYZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6B11A20880 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yhb3UuXga9u/KAPsHx/yl8I8x78Nzo3lNkcXg3aSneY=; b=Ft8ZsFRr+oADHU bmUSTb73gavGlspwt1wsl3+BPNtQVwcMbnpYqlcOXwc1fRLrmbNgJmZmRznd1G8gu+idLB5cDSmKf 3ZwA8T41wYen8Kz+SGjM+bfh8RaqcqGDfaZnccHwmfMsPvsrXf8LwXNLRUm3Yx0Sb68SDPAvuuYSz LtV6PCm1oocL5b4sMSbxfWm/4r64f8Fx+N6tDJcx+otw3T5KVXebbpwsLQKgFiqW/rIEanmTYIMxp +VeoQRGT5/xkih1jfDkTOV6EHOb0gx4kfLutuB8YFYlcwo+z2508Llhf0NStR2ZSC7uUp1tYZ8qBY LCDSH2cIKXFzKZ0DcvXw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1huadO-0005HO-FM; Mon, 05 Aug 2019 10:54:34 +0000 Received: from perceval.ideasonboard.com ([2001:4b98:dc2:55:216:3eff:fef7:d647]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1huadJ-0005Gx-EB for linux-arm-kernel@lists.infradead.org; Mon, 05 Aug 2019 10:54:31 +0000 Received: from pendragon.ideasonboard.com (dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi [IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id C82CF2F9; Mon, 5 Aug 2019 12:54:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1565002467; bh=RwQ5mnU7RUBzTgtf9QVDKC/TD/uPXzpxPEkwiDIp9go=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=o1GVXvYZTbKujwlbSWjhyKHPW4owM5I0zlEmcs35W5UJBLn/uX9Y1tgQEVNlHfCbu /nMXTotTJmqYaQ8CHoaAUSMqptXHOSOgKzy2jlzBudupzdlL+rtr7/MD3KkjGOYseq vW5cLPFJmFIz7+5Iycxf8kVVcCzLg1Lzyt0SrqHE= Date: Mon, 5 Aug 2019 13:54:25 +0300 From: Laurent Pinchart To: Sam Ravnborg Subject: Re: [PATCH v1 12/16] drm/panel: use inline comments in drm_panel.h Message-ID: <20190805105425.GG29747@pendragon.ideasonboard.com> References: <20190804201637.1240-1-sam@ravnborg.org> <20190804201637.1240-13-sam@ravnborg.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190804201637.1240-13-sam@ravnborg.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190805_035429_858425_016ECC59 X-CRM114-Status: GOOD ( 24.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , David Airlie , Linus Walleij , dri-devel@lists.freedesktop.org, Andrzej Hajda , Thierry Reding , Benjamin Gaignard , Fabio Estevam , Marek Vasut , Laurent Pinchart , Joonyoung Shim , Vincent Abriou , Krzysztof Kozlowski , Jonathan Hunter , Maxime Ripard , Kukjin Kim , linux-arm-kernel@lists.infradead.org, Philipp Zabel , NXP Linux Team , Pengutronix Kernel Team , Jonas Karlman , Sascha Hauer , Alison Wang , Maarten Lankhorst , Gwan-gyeong Mun , Inki Dae , Alexios Zavras , linux-samsung-soc@vger.kernel.org, Stefan Agner , linux-tegra@vger.kernel.org, Thomas Gleixner , Sean Paul , Allison Randal , Jernej Skrabec , Shawn Guo , Seung-Woo Kim , Kyungmin Park , Daniel Vetter , Enrico Weigelt Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Sam, Thank you for the patch. On Sun, Aug 04, 2019 at 10:16:33PM +0200, Sam Ravnborg wrote: > Inline comments provide better space for additional comments. > Comments was slightly edited to follow the normal style, > but no change to actual content. > Used the opportuniy to change the order in drm_panel_funcs > to follow the order they will be used by a panel. > > Signed-off-by: Sam Ravnborg > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Sean Paul > Cc: Thierry Reding > Cc: Sam Ravnborg > Cc: David Airlie > Cc: Daniel Vetter Reviewed-by: Laurent Pinchart > --- > include/drm/drm_panel.h | 82 +++++++++++++++++++++++++++++++++-------- > 1 file changed, 66 insertions(+), 16 deletions(-) > > diff --git a/include/drm/drm_panel.h b/include/drm/drm_panel.h > index 053d611656b9..5e62deea49ba 100644 > --- a/include/drm/drm_panel.h > +++ b/include/drm/drm_panel.h > @@ -36,14 +36,6 @@ struct display_timing; > > /** > * struct drm_panel_funcs - perform operations on a given panel > - * @disable: disable panel (turn off back light, etc.) > - * @unprepare: turn off panel > - * @prepare: turn on panel and perform set up > - * @enable: enable panel (turn on back light, etc.) > - * @get_modes: add modes to the connector that the panel is attached to and > - * return the number of modes added > - * @get_timings: copy display timings into the provided array and return > - * the number of display timings available > * > * The .prepare() function is typically called before the display controller > * starts to transmit video data. Panel drivers can use this to turn the panel > @@ -69,31 +61,89 @@ struct display_timing; > * the panel. This is the job of the .unprepare() function. > */ > struct drm_panel_funcs { > - int (*disable)(struct drm_panel *panel); > - int (*unprepare)(struct drm_panel *panel); > + /** > + * @prepare: > + * > + * Turn on panel and perform set up. > + */ > int (*prepare)(struct drm_panel *panel); > + > + /** > + * @enable: > + * > + * Enable panel (turn on back light, etc.). > + */ > int (*enable)(struct drm_panel *panel); > + > + /** > + * @disable: > + * > + * Disable panel (turn off back light, etc.). > + */ > + int (*disable)(struct drm_panel *panel); > + > + /** > + * @unprepare: > + * > + * Turn off panel. > + */ > + int (*unprepare)(struct drm_panel *panel); > + > + /** > + * @get_modes: > + * > + * Add modes to the connector that the panel is attached to and > + * return the number of modes added. > + */ > int (*get_modes)(struct drm_panel *panel); > + > + /** > + * @get_timings: > + * > + * Copy display timings into the provided array and return > + * the number of display timings available. > + */ > int (*get_timings)(struct drm_panel *panel, unsigned int num_timings, > struct display_timing *timings); > }; > > /** > * struct drm_panel - DRM panel object > - * @drm: DRM device owning the panel > - * @connector: DRM connector that the panel is attached to > - * @dev: parent device of the panel > - * @link: link from panel device (supplier) to DRM device (consumer) > - * @funcs: operations that can be performed on the panel > - * @list: panel entry in registry > */ > struct drm_panel { > + /** > + * @drm: > + * > + * DRM device owning the panel. > + */ > struct drm_device *drm; > + > + /** > + * @connector: > + * > + * DRM connector that the panel is attached to. > + */ > struct drm_connector *connector; > + > + /** > + * @dev: > + * > + * Parent device of the panel. > + */ > struct device *dev; > > + /** > + * @funcs: > + * > + * Operations that can be performed on the panel. > + */ > const struct drm_panel_funcs *funcs; > > + /** > + * @list: > + * > + * Panel entry in registry. > + */ > struct list_head list; > }; > -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel