From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60239C433FF for ; Mon, 5 Aug 2019 11:55:01 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 323C2206A2 for ; Mon, 5 Aug 2019 11:55:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="sMgRvSya" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 323C2206A2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SjSnA47Hn6VD9tNo5ImasA8QSS9/oQjuAV1Leb582iY=; b=sMgRvSya3PjUO5 zG4O9A7kcg1i9rgqFjJlYN0lTVY4FyXnzFImse1rxngE9JLbqDeiVoNMKbxgofqoKlOgZTL1IWqQK OgEHxjaSNmFWRriT67hzZJadmcHRjsvR7/4rVGWIpCDFzNUZErTOXSA/j4JBrOp3Hk7nxzxcCT0uC nNdR6Ood6VthyJCYJoEv3n1pFmrS1Qu5LwwKWSq88XcVHJ5SaL0nQ+hH1sEP5u2o8xLC3MCrZ9GWh Pxl+LPiVpJ7J9eFdXdO8/JRqIt+xSUWM7XB21LI2ENdz5QnnQeGKSP+shg9VQ24aW43d0saEPpSso 0hhcMQTo9aj74H7Sh0iA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hubZs-0006QE-Bu; Mon, 05 Aug 2019 11:55:00 +0000 Received: from asavdk3.altibox.net ([109.247.116.14]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hubZo-0006Pp-R2 for linux-arm-kernel@lists.infradead.org; Mon, 05 Aug 2019 11:54:58 +0000 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id F12E320039; Mon, 5 Aug 2019 13:54:51 +0200 (CEST) Date: Mon, 5 Aug 2019 13:54:50 +0200 From: Sam Ravnborg To: Stefan Agner Subject: Re: [PATCH v1 05/16] drm/fsl-dcu: fix opencoded use of drm_panel_* Message-ID: <20190805115450.GB16513@ravnborg.org> References: <20190804201637.1240-1-sam@ravnborg.org> <20190804201637.1240-6-sam@ravnborg.org> <8567eb4c916a0b1d134bd62112a11903@agner.ch> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8567eb4c916a0b1d134bd62112a11903@agner.ch> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=dqr19Wo4 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=7gkXJVJtAAAA:8 a=8AirrxEcAAAA:8 a=PwaXosQhBBzGxnEnWWMA:9 a=AW-sozriLiJjIiio:21 a=XmQ5ioN8wHDAHHl3:21 a=CjuIK1q_8ugA:10 a=E9Po1WZjFZOl8hwRPBS3:22 a=ST-jHhOKWsTCqRlWije3:22 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190805_045457_228106_50E68B0F X-CRM114-Status: GOOD ( 20.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , David Airlie , dri-devel@lists.freedesktop.org, Thierry Reding , Laurent Pinchart , Marek Vasut , linux-samsung-soc@vger.kernel.org, Sean Paul , Allison Randal , Krzysztof Kozlowski , Jonathan Hunter , Maxime Ripard , Kukjin Kim , NXP Linux Team , Sam Ravnborg , Jonas Karlman , Alison Wang , Gwan-gyeong Mun , Alexios Zavras , Laurent Pinchart , linux-tegra@vger.kernel.org, Thomas Gleixner , Vincent Abriou , linux-arm-kernel@lists.infradead.org, Jernej Skrabec , Enrico Weigelt , Seung-Woo Kim , Kyungmin Park , Pengutronix Kernel Team , Shawn Guo Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Stefan. Thanks for the feedback. On Mon, Aug 05, 2019 at 11:16:26AM +0200, Stefan Agner wrote: > On 2019-08-04 22:16, Sam Ravnborg wrote: > > Use drm_panel_get_modes() to access modes. > > This has a nice side effect to simplify the code. > > > > Signed-off-by: Sam Ravnborg > > Cc: Stefan Agner > > Cc: Alison Wang > > --- > > drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c | 10 +--------- > > 1 file changed, 1 insertion(+), 9 deletions(-) > > > > diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c > > b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c > > index 279d83eaffc0..a92fd6c70b09 100644 > > --- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c > > +++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c > > @@ -65,17 +65,9 @@ static const struct drm_connector_funcs > > fsl_dcu_drm_connector_funcs = { > > static int fsl_dcu_drm_connector_get_modes(struct drm_connector *connector) > > { > > struct fsl_dcu_drm_connector *fsl_connector; > > - int (*get_modes)(struct drm_panel *panel); > > - int num_modes = 0; > > > > fsl_connector = to_fsl_dcu_connector(connector); > > - if (fsl_connector->panel && fsl_connector->panel->funcs && > > - fsl_connector->panel->funcs->get_modes) { > > - get_modes = fsl_connector->panel->funcs->get_modes; > > - num_modes = get_modes(fsl_connector->panel); > > - } > > - > > - return num_modes; > > + return drm_panel_get_modes(fsl_connector->panel); > > Oh, that old code looks rather messy. Thanks for the simplification! > > This behaves slightly different since it now returns -EINVAL or -ENOSYS, > but that is what we want. You are right, and I will add this to the changelog when I apply. Sam _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel