From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43824C0650F for ; Mon, 5 Aug 2019 13:16:41 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1878520657 for ; Mon, 5 Aug 2019 13:16:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jO5ZNglt"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HJrPdg5v" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1878520657 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hdgAE10SfnoFmetWqkxwS6AP4jB+jejEE4RlPi2A8Vo=; b=jO5ZNgltRSaaed GaaKu+grBz8QNFKpE4hqHsBmVtIYBZGvg19aAbkfyijwaw68Ef0iCSHjkxnUmftv7n5chhdPbc+RC HJ9Mu+KikA+VLin1PCuvYryTSPATBcdYR6jOH+XRJMXIdb6SVjSu34P38FKBSMb8SXp1H+za1oaoi KtdmIUlW7OE39NXFGyCpWEEMSW2Y2p1nZn8s/l0RrEsMH+UOi8O47ySYPGfaaPiZRXcewWrtx1OZ2 Ut/Ja2bPExr7/WU3MbmIvdLUicOIEnwrFU8QWoH1XRdk3uK6oB5ZHcChY6lnwFMw/o5n7Q6aeeMFE h0kHOF+4G9dOTIECGclw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hucqu-0007bP-Pg; Mon, 05 Aug 2019 13:16:40 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hucqr-0007am-Pr for linux-arm-kernel@lists.infradead.org; Mon, 05 Aug 2019 13:16:39 +0000 Received: by mail-wr1-x441.google.com with SMTP id x4so31211964wrt.6 for ; Mon, 05 Aug 2019 06:16:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=aboHDvQ6ED+izD2UcWUy5SYRhwe6k8n3aFGpiqq6F94=; b=HJrPdg5vi2acXiTXn2D4z0i7Hr8w9XxLP/M4z2UnD9KSie//GRJr+D7i+HBERo0EyL E5xRuusW/sVxMjetijNBd1r+m4y7aPO+7292NQ5ydJqR2IJKF77JAsI54CE17Ta/cdZg QrG3JXUa8RWfSFu9Yj8ueDmPzGjfRvEczwrUzyAF6NXpZFHS1fbblvXfUprPBAeDuSVs G7kkZpSxO2LtflLSGMe98WVsft4eKAhlMb+AWUwtjg4FVC3SvA0PDrhI7UFd5lX9acGL rtGWgEtJiIGVcoJsqWbo5ZVbH0otl6VcYaaYQhB+ovNxMBCVQULGfy9jPcC4aONgj/Ka qTpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=aboHDvQ6ED+izD2UcWUy5SYRhwe6k8n3aFGpiqq6F94=; b=OyS4OuAEnyXEAcQaaAPEGVFIfuqd8luNvyD1ElePCMNLPcLu1jaxxCGbpGtB3RYUYc CYR3dGvRMNL51USh9yrV1B8A5R5aRyFQNhoXiBOtA0Sj+zZ+e7ODKtOog/hrzrd6xGC8 tDuAwHAF1RD5bXqiMn9mXc+kNhjum6gjCgRDCx/q/TA/OIdcz8hPPuo+t1dKdsr41tlw Rki3MzYAstiHbSWlC/0oRfjkme3FOjQmUW6TBiEVIlx6Pz2flJUiFpr4sAu8JiR38f69 lysE+XTS9d2j51Y1MIQLScloFmPL1247AGf5cEBFaGZTim+cewHWgoI3PedD3akqV3xh uXhA== X-Gm-Message-State: APjAAAXYg3WKpMy9z22r7TrOg6pqlAiO31fSt4Yk3q5EuVqho5S8+bqy KIJaFkr7xFM7LghRwKool8s= X-Google-Smtp-Source: APXvYqzjHltu287XVkm0ryMGRX0Isuk446ECENvX2h1IZhSqC098PAq939JkQVreUtJBofYhKAusxA== X-Received: by 2002:a5d:60c5:: with SMTP id x5mr74740880wrt.253.1565010995650; Mon, 05 Aug 2019 06:16:35 -0700 (PDT) Received: from arch-x1c3 ([2a00:5f00:102:0:9665:9cff:feee:aa4d]) by smtp.gmail.com with ESMTPSA id m7sm71200354wrx.65.2019.08.05.06.16.33 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 05 Aug 2019 06:16:34 -0700 (PDT) Date: Mon, 5 Aug 2019 14:15:55 +0100 From: Emil Velikov To: Laurent Pinchart Subject: Re: [PATCH v1 14/16] drm/panel: call prepare/enable only once Message-ID: <20190805131555.GA5005@arch-x1c3> References: <20190804201637.1240-1-sam@ravnborg.org> <20190804201637.1240-15-sam@ravnborg.org> <20190805105928.GI29747@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190805105928.GI29747@pendragon.ideasonboard.com> User-Agent: Mutt/1.11.4 (2019-03-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190805_061637_864039_B67472B9 X-CRM114-Status: GOOD ( 17.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , David Airlie , dri-devel@lists.freedesktop.org, Thierry Reding , Sam Ravnborg , Marek Vasut , linux-samsung-soc@vger.kernel.org, Sean Paul , Allison Randal , Krzysztof Kozlowski , Jonathan Hunter , Maxime Ripard , Kukjin Kim , NXP Linux Team , Jonas Karlman , Alison Wang , Gwan-gyeong Mun , Alexios Zavras , Laurent Pinchart , linux-tegra@vger.kernel.org, Thomas Gleixner , Vincent Abriou , linux-arm-kernel@lists.infradead.org, Jernej Skrabec , Enrico Weigelt , Seung-Woo Kim , Kyungmin Park , Pengutronix Kernel Team , Shawn Guo Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2019/08/05, Laurent Pinchart wrote: > Hi Sam, > > Thank you for the patch. > > On Sun, Aug 04, 2019 at 10:16:35PM +0200, Sam Ravnborg wrote: > > Many panel drivers duplicate logic to prevent prepare to be called > > for a panel that is already prepared. > > Likewise for enable. > > > > Implement this logic in drm_panel so the individual drivers > > no longer needs this. > > A panel is considered prepared/enabled only if the prepare/enable call > > succeeds. > > For disable/unprepare it is unconditionally considered > > disabled/unprepared. > > > > This allows calls to prepare/enable again, even if there were > > some issue disabling a regulator or similar during disable/unprepare. > > Is this the right place to handle this ? Shouldn't the upper layers > ensure than enable/disable and prepare/unprepare are correcty balanced, > and not called multiple times ? Adding enabled and prepared state to > drm_panel not only doesn't align well with atomic state handling, but > also would hide issues in upper layers that should really be fixed > there. > Fully agreed. Mistakes happen - hiding them, by returning "success" does not sound like a wise approach. HTH Emil _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel