From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8EA9C0650F for ; Mon, 5 Aug 2019 13:50:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7FCCA20880 for ; Mon, 5 Aug 2019 13:50:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="AAbPqsp1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7FCCA20880 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wTWXhIawWlTnZwGdk7NnXBCKUw5jk9ppMvGwtFlQmhg=; b=AAbPqsp1S4Glqj l6XzsBA6fPgKGvXFiqNLUVD5i3BAyh5cnxGfV/SIBJXMDXXv56ZMrPWTnfIGjP0Jw+PkGfnJIR4uI amqduqbqq/MfI7WAEr8fDF8LvuXCvsDGvlE6VJ8OROaDgLIkq5Yj6fZGQRet3JI08lacl2Y2GCI3M yUO+/UV8LM8+3aZ4GrQS+T3k+Il31T+g2wqZDGzHlCc/ah7M/3zaWvH1EmMhr62cfZdKOPqUlwfba MNDhjVgvXmtHXG6nhFpMXYbASBP+fgmA/i2ZuexKDLdsujnSQXWm/yWfebxwziuYitAAiEUYro3qg V7jx21J2zOT7DYM0MaeQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hudO6-0006gn-26; Mon, 05 Aug 2019 13:50:58 +0000 Received: from relay7-d.mail.gandi.net ([217.70.183.200]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hudO2-0006fk-7t; Mon, 05 Aug 2019 13:50:56 +0000 X-Originating-IP: 82.246.155.60 Received: from localhost (hy283-1-82-246-155-60.fbx.proxad.net [82.246.155.60]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 1708A20008; Mon, 5 Aug 2019 13:50:44 +0000 (UTC) Date: Mon, 5 Aug 2019 15:50:44 +0200 From: Alexandre Belloni To: Frank Wunderlich Subject: Re: [PATCH v3 05/10] rtc: mt6397: add compatible for mt6323 Message-ID: <20190805135044.GH3600@piout.net> References: <20190729174154.4335-1-frank-w@public-files.de> <20190729174154.4335-6-frank-w@public-files.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190729174154.4335-6-frank-w@public-files.de> User-Agent: Mutt/1.12.0 (2019-05-25) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190805_065054_452421_83AC8F32 X-CRM114-Status: GOOD ( 17.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kate Stewart , Mark Rutland , linux-kernel@vger.kernel.org, Richard Fontana , Mauro Carvalho Chehab , Lee Jones , linux-rtc@vger.kernel.org, Allison Randal , devicetree@vger.kernel.org, linux-pm@vger.kernel.org, Sean Wang , "Tianping . Fang" , Rob Herring , linux-mediatek@lists.infradead.org, Jonathan Cameron , Matthias Brugger , Thomas Gleixner , Eddie Huang , linux-arm-kernel@lists.infradead.org, Alessandro Zummo , Josef Friedl , Greg Kroah-Hartman , Sebastian Reichel , "David S. Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 29/07/2019 19:41:49+0200, Frank Wunderlich wrote: > From: Josef Friedl > > use mt6397 rtc driver also for mt6323 > compatible needed because of different rtc-base/size see part 7 I still don't think this is a good reason so I would remove that sentence. Also, it refers to part 7 which is an info that will not be available when looking at the git history. > > changes since v2: splitted this from v2.3 suggested-by Alexandre Belloni > Changelog after the --- marker please. > Signed-off-by: Josef Friedl > Signed-off-by: Frank Wunderlich > --- > drivers/rtc/rtc-mt6397.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/rtc/rtc-mt6397.c b/drivers/rtc/rtc-mt6397.c > index 9370b7fc9f81..21cd9cc8b4c7 100644 > --- a/drivers/rtc/rtc-mt6397.c > +++ b/drivers/rtc/rtc-mt6397.c > @@ -325,6 +325,7 @@ static SIMPLE_DEV_PM_OPS(mt6397_pm_ops, mt6397_rtc_suspend, > mt6397_rtc_resume); > > static const struct of_device_id mt6397_rtc_of_match[] = { > + { .compatible = "mediatek,mt6323-rtc", }, > { .compatible = "mediatek,mt6397-rtc", }, > { } > }; > -- > 2.17.1 > -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel