From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E223C433FF for ; Mon, 5 Aug 2019 15:11:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E691821734 for ; Mon, 5 Aug 2019 15:11:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GeEsfcIK"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=poorly.run header.i=@poorly.run header.b="Yc8iF9Tg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E691821734 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=poorly.run Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Yp7AR4eyUBxKOv47V4m4wcpdtzOf5F13tLK0mgc6Qms=; b=GeEsfcIKmXbLzE uxZ8Synj+c57Nx70Cc6x5m5/tB3ADNY2OGqkNETGkEEwb1vSOpbmUVEEAzqI62jxwHvLGEK7CGYGO 6eIYwmQa+TQUD3X510nv4r76cfurMCkyXeUeQJ5IxeWpv1/7+GnqummrzY0vUUur7GwNMl3RHlqnj P8YTSIXa9cjIeCvtY3mvENxuMiG4cOCvJZuBnLdOnViw6aW79wlMaiy2vzlE2GKprJmmYaiUhHu6Q etT6IuSN0G2IuVFxRqVYF6fau1AiLQi4lMHVgdCC14UMLNNwag1Ijq+x/rKqRGVi/smq6TKj7RqD6 DQex0bebkq4bFclPAFeA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1huedi-0002C8-Qh; Mon, 05 Aug 2019 15:11:10 +0000 Received: from mail-yw1-xc42.google.com ([2607:f8b0:4864:20::c42]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1huedf-0002A8-MZ for linux-arm-kernel@lists.infradead.org; Mon, 05 Aug 2019 15:11:09 +0000 Received: by mail-yw1-xc42.google.com with SMTP id m16so29627923ywh.12 for ; Mon, 05 Aug 2019 08:11:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=poorly.run; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Xpk6f+iULzta9MKqDdvJJrwYV01nAnI8/sskf5srO6w=; b=Yc8iF9Tg6K4ZUygMSzIbAg7TgFHqn+DDIs7uLPE5xrDqID2IWXqNk6LvPQ9rUJHn/y iwBv+kyYjwO2lD6X/Fbjg+YcSnkIRz0Leri50AKvtchFjaw+ayZguSVOSk2X/dILnpWv l05vTy1Q3eSFfnRT62uEMfRaxksSOQIg4guRvn5xGyPW/ul2eM9FFdAE7qOmM6HojDz0 hxSRDLNwD1Y46nxRF8OvkBl4oPTboz1hP1ZPsSs4wUZj6mCajEVFQtOiN5fzjDm955Jb YEDhkh4JZe7a4k1yOwZ76mQBkUFzfK0sAxWkzheCnCCnGz6AvAqPROj/zx2UuM4Ya+HD ntyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Xpk6f+iULzta9MKqDdvJJrwYV01nAnI8/sskf5srO6w=; b=kI9fhAI08/avpI6D7hgnPGasH9i5lisI08DSAcPqPRndNOQSsXdP2rB50eVvk5T+tK l/iQs+DvV7u3yumaNxhJz0LcL62QroDcvVXWYW73pPe5NItx9x8LtCUaS3TRbT3kGdVz 9ioDFqywZjVRUA+zIh4RG6NZQ2JLgNNH871kQNkdQ3DHXBka2k5Eu2br44v8jSC1dM2j tX83XOadPv3FOlSZjteiSdL70kFBYKuQ37nP9D5rihAYtKaqCNYYn8Q8e4g/UHBqgpPw WRP1YooFsj9jeYfbMoTu94LqClesQ3+Dr/QAK3KCgPoVrFBGjoOfoMTShdNi/Fv+CQzt LHlg== X-Gm-Message-State: APjAAAVq6IQu0KPxewZn1Ttc7RAf68TxLOg247aAShDKZ9tGYjlE0ND0 Uthz7u9z/lemJgFgxIHgKXjtaQ== X-Google-Smtp-Source: APXvYqwucyKIizPhyNVHyc8xvnzNgJysm59poTBqYa8cImRwlOnzSuOS8zREscvyu0uqoevbAyXDUA== X-Received: by 2002:a81:1d11:: with SMTP id d17mr96208542ywd.9.1565017865628; Mon, 05 Aug 2019 08:11:05 -0700 (PDT) Received: from localhost ([2620:0:1013:11:89c6:2139:5435:371d]) by smtp.gmail.com with ESMTPSA id w188sm18900454ywc.93.2019.08.05.08.11.04 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 05 Aug 2019 08:11:04 -0700 (PDT) Date: Mon, 5 Aug 2019 11:11:03 -0400 From: Sean Paul To: Douglas Anderson Subject: Re: [PATCH] drm/rockchip: Suspend DP late Message-ID: <20190805151103.GY104440@art_vandelay> References: <20190802184616.44822-1-dianders@chromium.org> <20190802192629.GX104440@art_vandelay> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190802192629.GX104440@art_vandelay> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190805_081107_755181_5D0AD9C1 X-CRM114-Status: GOOD ( 21.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heiko Stuebner , Tomeu Vizoso , David Airlie , Sandy Huang , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, mka@chromium.org, seanpaul@chromium.org, Daniel Vetter , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 02, 2019 at 03:26:29PM -0400, Sean Paul wrote: > On Fri, Aug 02, 2019 at 11:46:16AM -0700, Douglas Anderson wrote: > > In commit fe64ba5c6323 ("drm/rockchip: Resume DP early") we moved > > resume to be early but left suspend at its normal time. This seems > > like it could be OK, but casues problems if a suspend gets interrupted > > partway through. The OS only balances matching suspend/resume levels. > > ...so if suspend was called then resume will be called. If suspend > > late was called then resume early will be called. ...but if suspend > > was called resume early might not get called. This leads to an > > unbalance in the clock enables / disables. > > > > Lets take the simple fix and just move suspend to be late to match. > > This makes the PM core take proper care in keeping things balanced. > > > > Fixes: fe64ba5c6323 ("drm/rockchip: Resume DP early") > > Signed-off-by: Douglas Anderson > > Reviewed-by: Sean Paul > > This should go in -misc-fixes and due to some... administrative reasons... I > will leave it on the list until Maarten has a chance to ff to -rc4 on Monday. > I'll apply it then so as to not require a backmerge. We're no longer able to ff drm-misc-fixes since a commit came in on Saturday, so I've piled this on as well. Thanks, Sean > > Sean > > > --- > > > > drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c > > index 7d7cb57410fc..f38f5e113c6b 100644 > > --- a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c > > +++ b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c > > @@ -436,7 +436,7 @@ static int rockchip_dp_resume(struct device *dev) > > > > static const struct dev_pm_ops rockchip_dp_pm_ops = { > > #ifdef CONFIG_PM_SLEEP > > - .suspend = rockchip_dp_suspend, > > + .suspend_late = rockchip_dp_suspend, > > .resume_early = rockchip_dp_resume, > > #endif > > }; > > -- > > 2.22.0.770.g0f2c4a37fd-goog > > > > -- > Sean Paul, Software Engineer, Google / Chromium OS -- Sean Paul, Software Engineer, Google / Chromium OS _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel