From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56521C31E40 for ; Tue, 6 Aug 2019 05:13:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2A1CA2147A for ; Tue, 6 Aug 2019 05:13:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Vr9C+QkK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2A1CA2147A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gsO6obcuD47dhHYtPr/ENxJklTwSot/OZI/0a9CKNcI=; b=Vr9C+QkKz8whEo oF6oUKWA9bmGexDHf6cheb1DckInTQV5kiSldJPndEKhLMuEn3lZz9gNL8wDwhpSZFbUqP0+kcqT9 Eveys5f4Qw4Ex+vMDchCOQXbu9P9sr0C8uDCETmZLLdXMUPlCE2ViO0xNJO6/0dgTUmaTXohrLwc2 s+YlD45Dn62qj75dKgByYHj5sKorBrhF9taYmSuvv42w59ucqFdBcojpjFHKM7HIQYdouMLGrehzM RppRnc5YAbQ4yHE8+HTp8B6EOWUeUWmW3gra/hJFhwyP5iUSaHwtWPYL593E4ofV0dsxkD8ry0Oqb D9LGi6vvpvy7BJpOggAA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hurmH-0000NQ-3k; Tue, 06 Aug 2019 05:12:53 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hurmD-0000Mg-Cb for linux-arm-kernel@lists.infradead.org; Tue, 06 Aug 2019 05:12:50 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 8410D68B05; Tue, 6 Aug 2019 07:12:42 +0200 (CEST) Date: Tue, 6 Aug 2019 07:12:42 +0200 From: Christoph Hellwig To: Gavin Li Subject: Re: [PATCH 1/2] dma-mapping: fix page attributes for dma_mmap_* Message-ID: <20190806051242.GA13269@lst.de> References: <20190805080145.5694-1-hch@lst.de> <20190805080145.5694-2-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190805_221249_575263_5B7DC7CD X-CRM114-Status: GOOD ( 11.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gavin Li , Shawn Anastasio , Michael Ellerman , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Russell King , linux-mips@vger.kernel.org, Paul Burton , Catalin Marinas , James Hogan , Will Deacon , Christoph Hellwig , linux-arm-kernel@lists.infradead.org, Robin Murphy Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Aug 05, 2019 at 07:55:44PM -0700, Gavin Li wrote: > > /* create a coherent mapping */ > > ret = dma_common_contiguous_remap(page, size, VM_USERMAP, > > - arch_dma_mmap_pgprot(dev, PAGE_KERNEL, attrs), > > + dma_pgprot(dev, PAGE_KERNEL, attrs), > > __builtin_return_address(0)); > > if (!ret) { > > __dma_direct_free_pages(dev, size, page); > > Is dma_common_contiguous_remap() still necessary in the > DMA_ATTR_NON_CONSISTENT case? I would presume it would be fine to just > return a linearly mapped address in that case. It would not be required for a real DMA_ATTR_NON_CONSISTENT implementation. But only parisc and mips actually properly implement DMA_ATTR_NON_CONSISTENT, everyone ignores it. Given that the API is a little ill defined and I have a better replacement in the pipeline I don't want to start implementing it for other architectures now. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel