From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1F95C433FF for ; Wed, 7 Aug 2019 00:08:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 945A62173C for ; Wed, 7 Aug 2019 00:08:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="L9s8AAcO"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="TAeG++7B" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 945A62173C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To: Message-Id:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IzlZalLokUdERRoZZ0voebfhue+TD+pil++9VNhTmpE=; b=L9s8AAcOLy155Y L8CoxRbJeIi/Y1UaB5CjEteaYnynGtjtfddq20SMtFLAtYGW2WUAd3/kVOqq3kqaTM+mU+K23+lVk ayroYh2jPiHc8WcjMH63X7BRfDK+y4I4Z13xio3tuqELmF8672PyTm3ZwSu6AWIlE3MWRVE4xhkoV p0PA48NXK2upeq0DFWgYMfrk7gZEVxmARtkgvjVE25eP/QCfmriGsMPbHyIfhACG0fDCm/QQap/eG Wc8CS4qPkxqQRz6qYCZLTSAMdamJ/6DvqbrN2sOxqM8GzjNmUrsefTTiROMmeJe0PKggxp7OU4so+ lxF8763DzXDEkGVkORyg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hv9V9-0006c6-Sz; Wed, 07 Aug 2019 00:08:23 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hv9V5-0006bm-SS for linux-arm-kernel@lists.infradead.org; Wed, 07 Aug 2019 00:08:21 +0000 Received: from devnote2 (NE2965lan1.rev.em-net.ne.jp [210.141.244.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id ED7FA2089E; Wed, 7 Aug 2019 00:08:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565136499; bh=FhChKXsPPb1L8MSYtmcGqA0kOKtJaeO7DrzVbRT1MXs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=TAeG++7BBNLdzsT8EeUACw88fONFc1pQcT8EUvAlKq8EqeLzcGZIz0ceLh4nYgX84 xTRDE/BvbyzWZvQYIvI12bG0fb2Hr+ia9Vz72+zfUolIsY7N4a0uoRfA30sNdV3zwc LDnEWEZxfNuA7Zo/uTF7X1Z/DVFpbZNzGS5Nb8/c= Date: Wed, 7 Aug 2019 09:08:11 +0900 From: Masami Hiramatsu To: Leo Yan Subject: Re: [PATCH v2 0/3] arm/arm64: Add support for function error injection Message-Id: <20190807090811.1e50eb3e1d5a7b85743748e7@kernel.org> In-Reply-To: <20190806100015.11256-1-leo.yan@linaro.org> References: <20190806100015.11256-1-leo.yan@linaro.org> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190806_170819_965132_83A1BE59 X-CRM114-Status: GOOD ( 16.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Song Liu , Catalin Marinas , Alexei Starovoitov , Oleg Nesterov , Paul Mackerras , "H. Peter Anvin" , Will Deacon , linux-arch@vger.kernel.org, Daniel Borkmann , Michael Ellerman , x86@kernel.org, Russell King , clang-built-linux@googlegroups.com, Ingo Molnar , Benjamin Herrenschmidt , Yonghong Song , "Naveen N. Rao" , Arnd Bergmann , Borislav Petkov , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Martin KaFai Lau Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 6 Aug 2019 18:00:12 +0800 Leo Yan wrote: > This small patch set is to add support for function error injection; > this can be used to eanble more advanced debugging feature, e.g. > CONFIG_BPF_KPROBE_OVERRIDE. > > The patch 01/03 is to consolidate the function definition which can be > suared cross architectures, patches 02,03/03 are used for enabling > function error injection on arm64 and arm architecture respectively. > > I tested on arm64 platform Juno-r2 and one of my laptop with x86 > architecture with below steps; I don't test for Arm architecture so > only pass compilation. > > - Enable kernel configuration: > CONFIG_BPF_KPROBE_OVERRIDE > CONFIG_BTRFS_FS > CONFIG_BPF_EVENTS=y > CONFIG_KPROBES=y > CONFIG_KPROBE_EVENTS=y > CONFIG_BPF_KPROBE_OVERRIDE=y > > - Build samples/bpf on with Debian rootFS: > # cd $kernel > # make headers_install > # make samples/bpf/ LLC=llc-7 CLANG=clang-7 > > - Run the sample tracex7: > # dd if=/dev/zero of=testfile.img bs=1M seek=1000 count=1 > # DEVICE=$(losetup --show -f testfile.img) > # mkfs.btrfs -f $DEVICE > # ./tracex7 testfile.img > [ 1975.211781] BTRFS error (device (efault)): open_ctree failed > mount: /mnt/linux-kernel/linux-cs-dev/samples/bpf/tmpmnt: mount(2) system call failed: Cannot allocate memory. > > Changes from v1: > * Consolidated the function definition into asm-generic header (Will); > * Used APIs to access pt_regs elements (Will); > * Fixed typos in the comments (Will). This looks good to me. Reviewed-by: Masami Hiramatsu Thank you! > > > Leo Yan (3): > error-injection: Consolidate override function definition > arm64: Add support for function error injection > arm: Add support for function error injection > > arch/arm/Kconfig | 1 + > arch/arm/include/asm/ptrace.h | 5 +++++ > arch/arm/lib/Makefile | 2 ++ > arch/arm/lib/error-inject.c | 19 +++++++++++++++++++ > arch/arm64/Kconfig | 1 + > arch/arm64/include/asm/ptrace.h | 5 +++++ > arch/arm64/lib/Makefile | 2 ++ > arch/arm64/lib/error-inject.c | 18 ++++++++++++++++++ > arch/powerpc/include/asm/error-injection.h | 13 ------------- > arch/x86/include/asm/error-injection.h | 13 ------------- > include/asm-generic/error-injection.h | 6 ++++++ > include/linux/error-injection.h | 6 +++--- > 12 files changed, 62 insertions(+), 29 deletions(-) > create mode 100644 arch/arm/lib/error-inject.c > create mode 100644 arch/arm64/lib/error-inject.c > delete mode 100644 arch/powerpc/include/asm/error-injection.h > delete mode 100644 arch/x86/include/asm/error-injection.h > > -- > 2.17.1 > -- Masami Hiramatsu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel