From: Christoph Hellwig <hch@infradead.org>
To: "Koenig, Christian" <Christian.Koenig@amd.com>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"kernel-build-reports@lists.linaro.org"
<kernel-build-reports@lists.linaro.org>,
"Zhou1, Tao" <Tao.Zhou1@amd.com>,
"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>,
Christoph Hellwig <hch@infradead.org>,
"broonie@kernel.org" <broonie@kernel.org>,
"linux-next@vger.kernel.org" <linux-next@vger.kernel.org>,
"Deucher, Alexander" <Alexander.Deucher@amd.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"Li, Dennis" <Dennis.Li@amd.com>,
"Zhang, Hawking" <Hawking.Zhang@amd.com>
Subject: Re: [PATCH] drm/amdgpu: replace readq/writeq with atomic64 operations
Date: Wed, 7 Aug 2019 03:41:04 -0700 [thread overview]
Message-ID: <20190807104104.GA18773@infradead.org> (raw)
In-Reply-To: <daff9fc7-ead8-40e0-9a16-cb3b90b01722@amd.com>
On Wed, Aug 07, 2019 at 08:53:25AM +0000, Koenig, Christian wrote:
> Am 07.08.19 um 09:08 schrieb Christoph Hellwig:
> > On Wed, Aug 07, 2019 at 10:56:40AM +0800, Tao Zhou wrote:
> >> readq/writeq are not supported on all architectures
> > NAK. You must not use atomic_* on __iomem (MMIO) memory.
>
> Well then what's the right thing to do here?
>
> Essentially writeq/readq doesn't seems to be available on all
> architectures either.
writeq/readq are provided whenever the CPU actually supports 64-bit
atomic loads and stores. If it doesn't provide them atomic64* is
not going to be atomic vs the I/O device either. And that is on top
of the fact that for various architectures you can't simply use
plain loads and stores on MMIO memory to start with, which is why
we have the special accessors and the __iomem annotation.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-08-07 10:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-07 2:56 [PATCH] drm/amdgpu: replace readq/writeq with atomic64 operations Tao Zhou
2019-08-07 3:09 ` Jisheng Zhang
2019-08-07 4:02 ` Alex Deucher
2019-08-07 4:03 ` Alex Deucher
2019-08-07 7:08 ` Christoph Hellwig
2019-08-07 8:53 ` Koenig, Christian
2019-08-07 10:41 ` Christoph Hellwig [this message]
2019-08-07 10:55 ` Koenig, Christian
2019-08-07 12:59 ` Mark Brown
2019-08-07 13:00 ` Koenig, Christian
2019-08-07 13:07 ` Christoph Hellwig
2019-08-07 13:00 ` Christoph Hellwig
2019-08-07 13:03 ` Koenig, Christian
2019-08-07 18:00 ` Alex Deucher
2019-08-08 19:25 ` Guenter Roeck
2019-08-08 19:33 ` Alex Deucher
2019-08-09 9:04 ` Koenig, Christian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190807104104.GA18773@infradead.org \
--to=hch@infradead.org \
--cc=Alexander.Deucher@amd.com \
--cc=Christian.Koenig@amd.com \
--cc=Dennis.Li@amd.com \
--cc=Hawking.Zhang@amd.com \
--cc=Tao.Zhou1@amd.com \
--cc=akpm@linux-foundation.org \
--cc=amd-gfx@lists.freedesktop.org \
--cc=broonie@kernel.org \
--cc=kernel-build-reports@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-next@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).