From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A10DC433FF for ; Wed, 7 Aug 2019 22:25:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3AF9D214C6 for ; Wed, 7 Aug 2019 22:25:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nZ5Uv39X"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="tJSapUW1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3AF9D214C6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject:To:From: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vJj6/+4ZPSAscM7XwWKVZ24nmpasZNXfkkTSP8UV3kc=; b=nZ5Uv39XjODT7k 7qmLaH4EGC8m66lxxn8+S2kKBJvT7Mo6DopDmycKAfK7+zc3GfrXWRzfLVGzpaK/4ndvlqRI2v7Cg 11gujDOJtdOXBv2dtzBbV7H1mnEa7ctpWWKQy41tfa7c9X/yekfKWOOULcm9rwK6XT9xqdAFJo2Os agFiaO5NSVSvrT/1nrAYOdjrGv23zrSuBkCXUR+8lsOdzPnXvvexrwytaKnEXodh5qKgd0HDcjmEa b0WUrNvdEPoawZ4lqaMsB9CyAsXVkuCLuij+fPdnc9LnnkORWNOQ9v3FWvO0wJLQ3wshsIAPP1hSo R4lije9Z76nQGkgoXTjg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hvUND-0005lf-9p; Wed, 07 Aug 2019 22:25:35 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hvUNA-0005lJ-Bh for linux-arm-kernel@lists.infradead.org; Wed, 07 Aug 2019 22:25:33 +0000 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A4B79214C6; Wed, 7 Aug 2019 22:25:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565216731; bh=7DN7jQLFmk0JqhPULilD+Tp18e5zp+WZCZbei5vkoz8=; h=In-Reply-To:References:From:Cc:To:Subject:Date:From; b=tJSapUW1WcpXXWvfFttc/q7bxqeDSm5QApEJYgP8XBpUrq0Qb83eFk/5ZAKDxGQiu waJiFIkk9eRKyuaQZGk6v8sAZOBnryqFEzsOs/VQ/iJeXIygzr9WxCZwkH50YQi4G6 y2fDFQoa5Vrzbl6iWoQFO1nbXqNGbVzmnw1YiRHM= MIME-Version: 1.0 In-Reply-To: <20190804163445.6862-1-nishkadg.linux@gmail.com> References: <20190804163445.6862-1-nishkadg.linux@gmail.com> From: Stephen Boyd To: Nishka Dasgupta , linus.walleij@linaro.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, mturquette@baylibre.com Subject: Re: [PATCH] clk: versatile: Add of_node_put() in cm_osc_setup() User-Agent: alot/0.8.1 Date: Wed, 07 Aug 2019 15:25:30 -0700 Message-Id: <20190807222531.A4B79214C6@mail.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190807_152532_421946_45A25328 X-CRM114-Status: UNSURE ( 7.10 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nishka Dasgupta Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Nishka Dasgupta (2019-08-04 09:34:44) > In function cm_osc_setup, variable parent takes the value returned by > of_get_parent, which gets a node but does not put it. If parent is not > put before it goes out of scope, it may cause a memory leak. > Hence put parent before the function terminates. > Issue found with Coccinelle. > > Signed-off-by: Nishka Dasgupta > --- Applied to clk-next _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel