From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: yvahkhfo.1df7f8c2@hashmail.org, linux-usb@vger.kernel.org,
security@kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: usb zero copy dma handling
Date: Thu, 8 Aug 2019 10:59:51 +0100 [thread overview]
Message-ID: <20190808095951.GD5193@shell.armlinux.org.uk> (raw)
In-Reply-To: <20190808085811.GA1265@kroah.com>
On Thu, Aug 08, 2019 at 10:58:11AM +0200, Greg KH wrote:
> But the main issue here is what exactly is this "fixing"? What is wrong
> with the existing code that non-x86 systems have such a problem with?
> Shouldn't all of these dma issues be handled by the platform with the
> remap_pfn_range() call itself?
remap_pfn_range() takes a PFN. virt_to_phys() converts a kernel *direct
mapped* virtual address to a physical address. That much is fine.
The question is - what is usbm->mem? If that is anything other than an
address returned by kmalloc() or from the normal page allocator, then
virt_to_phys() will return garbage.
In other words, if it comes from dma_alloc_coherent(), vmalloc() or
ioremap(), using virt_to_phys() on it results in garbage.
This aspect of virt_to_phys() has been well known about for ages; it's
one of the fundamentals of kernel programming.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-08-08 10:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-08 8:46 usb zero copy dma handling yvahkhfo.1df7f8c2
2019-08-08 8:58 ` Greg KH
2019-08-08 9:46 ` Robin Murphy
2019-08-08 10:07 ` Greg KH
2019-08-08 10:43 ` Robin Murphy
2019-08-08 13:05 ` Greg KH
2019-08-08 9:59 ` Russell King - ARM Linux admin [this message]
2019-08-08 10:02 ` Oliver Neukum
2019-08-08 16:10 ` Christoph Hellwig
2019-08-08 16:12 ` Christoph Hellwig
2019-08-08 16:57 ` Russell King - ARM Linux admin
-- strict thread matches above, loose matches on Subject: below --
2019-07-27 13:57 yvahknez.7f7d2ff0
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190808095951.GD5193@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=security@kernel.org \
--cc=yvahkhfo.1df7f8c2@hashmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).