From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0006EC0650F for ; Thu, 8 Aug 2019 16:36:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C0011214C6 for ; Thu, 8 Aug 2019 16:36:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="EwPjm/Ms" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C0011214C6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pTsnZGujB0u6pwHv3tK5BebS9OESmt7avNwEQCOf1Ww=; b=EwPjm/MsjbI5nw 6khFxxz2VSBKtEpwTC/o4kwwfgq+QZ9HGbwjUIe6FncMe9z5ZkThdKR4zvqjpjbUn0c0aT5nbc2Yh j46Bu+jsGIVLdY/3Luv3rVHdvsoLENb4lkbdpd2pUfdMPm9eqJAy2mAqwYzp9WToQwpbt7Cg7YHd6 y7WXoFu82Cfx44Z1tsfTbl6JhqzKeuq8GLuDOUEIQ96LSy4iW2fePCEzwRdrWkWTlBho71Mj7vSoy ttEvO4efIIgzrP5wPJdGIuvHFdcOqOmaj0yR6zLjfUO0Y2wGl/hwe8as6GIMqDCiM3oH1fmDkLuRZ 1N5+vIiP+V8PiCcTWSVQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hvlP3-0007hZ-Mn; Thu, 08 Aug 2019 16:36:37 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hvlP1-0007hF-BZ for linux-arm-kernel@lists.infradead.org; Thu, 08 Aug 2019 16:36:36 +0000 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E61AE214C6; Thu, 8 Aug 2019 16:36:33 +0000 (UTC) Date: Thu, 8 Aug 2019 12:36:32 -0400 From: Steven Rostedt To: Will Deacon Subject: Re: [PATCH 1/2 v2] tracing/arm64: Have max stack tracer handle the case of return address after data Message-ID: <20190808123632.0dd1a58c@gandalf.local.home> In-Reply-To: <20190808162825.7klpu3ffza5zxwrt@willie-the-truck> References: <20190807172826.352574408@goodmis.org> <20190807172907.155165959@goodmis.org> <20190808162825.7klpu3ffza5zxwrt@willie-the-truck> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190808_093635_418533_EB39654C X-CRM114-Status: GOOD ( 12.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jiping Ma , catalin.marinas@arm.com, will.deacon@arm.com, linux-kernel@vger.kernel.org, mingo@redhat.com, Joel Fernandes , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 8 Aug 2019 17:28:26 +0100 Will Deacon wrote: > > + * Note, this may change in the future, and we will need to deal with that > > + * if it were to happen. > > + */ > > +#define ARCH_RET_ADDR_AFTER_LOCAL_VARS 1 > > I know it's long already, but prefixing this with FTRACE_ would be good so > that other code doesn't use it for anything. It's not the end of the world > if the ftrace stack usage statistics are wonky, but if people tried to use > this for crazy things like livepatching then we'd be in trouble. > > Maybe FTRACE_ARCH_FRAME_AFTER_LOCALS, which is the same length as what > you currently have? Note, it would still need to be prefixed with "ARCH_" as that's the way of showing arch specific defines. We could make it more descriptive of what it will do and not the reason for why it is done... ARCH_FTRACE_SHIFT_STACK_TRACER ? -- Steve _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel