[PATCH 0/2 v2] tracing/arm: Fix the stack tracer when LR is saved after local storage

Steven Rostedt
2019-08-07T17:29:17Z

As arm64 saves the link register after a function's local variables are
stored, it causes the max stack tracer to be off by one in its output
of which function has the bloated stack frame.

The first patch fixes this by creating a ARCH_RET_ADDR_BEFORE_LOCAL_VARS
define that an achitecture (arm64) may set in asm/ftrace.h, and this
will cause the stack tracer to make the shift.

As it has been proven that the stack tracer isn't the most trivial
algorithm to understand by staring at the code, the second patch adds
comments to the code to explain the algorithm with and without the
ARCH_RET_ADDR_BEFORE_LOCAL_VARS.

Hmm, should this be sent to stable (and for inclusion now?)

-- Steve

Changes since v1:

- Fixed wrong value in stack_trace_index[] array in comment

- Added a comment about gcc currently saves the LR after local variables,
but there's no guarantee that it will be like that in the future.
(Notified of this by Mark Rutland)

Steven Rostedt (VMware) (2):
tracing/arm64: Have max stack tracer handle the case of return address after data
tracing: Document the stack trace algorithm in the comments

----
arch/arm64/include/asm/ftrace.h | 13 +++++
kernel/trace/trace_stack.c | 112 ++++++++++++++++++++++++++++++++++++++++
2 files changed, 125 insertions(+)