From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07079C433FF for ; Thu, 8 Aug 2019 13:26:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D182F21874 for ; Thu, 8 Aug 2019 13:26:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Tlyxk5zP"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="wdhiSMgE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D182F21874 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NpPMJbgZHMrNdZZI43X23SIghDC1GLb8Cv5TwfPorZg=; b=Tlyxk5zP7jf4l+ wkcQJl+Ui0c+cT0M0+WRYVkokqjYiRQfwyifvP9oYQsXjiKpLlsxur8dp5hYkMwHKUkZzjqY3Ban4 JYbFi9YMR2b645T365CWf7nrXdHu7PLiiE4p6gkoRnFc/YJwH+Wpdpr9p00ghsRUMh4R3UJVFIr0f 7QURejcIUKbRWchCdVdWEQTqLO0n1Qa9RPp84hCBMGxiB+VTdRdzqLizt1zk4nN9vK3Zqff94VW5j qla6RxSp7pyjW14HcVXaui4nhKwd3CsmsPmS7DOjctJD7edhy1h1tWAMdsSDlESXTFyOnK2orRSe9 lExY8TyIbzOc3L2g2zoA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hviQn-0008Qb-CL; Thu, 08 Aug 2019 13:26:13 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hviQl-0008QJ-7d for linux-arm-kernel@lists.infradead.org; Thu, 08 Aug 2019 13:26:12 +0000 Received: from localhost (unknown [122.178.245.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B37412171F; Thu, 8 Aug 2019 13:26:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565270770; bh=xOthRltc9QPDcvSfY6/4aGUZsvl14aXcUqTn5d6Zb0c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=wdhiSMgEUzklpKCVFzekiTPw8B+at3lhPkMlMq4SDMz7bagefPWO/3Q+YcDzoHCPg vY90keJnw2raAF5MHo3hox17C8WLQGi9gvALi+W9RX1r1qYdChpA4QJ93ZTn9d6Kam koHNlTvuUSrcY+0LQUue/knLXIFACQjNVu0A19FU= Date: Thu, 8 Aug 2019 18:54:56 +0530 From: Vinod Koul To: Jia-Ju Bai Subject: Re: [PATCH] dma: stm32-mdma: Fix a possible null-pointer dereference in stm32_mdma_irq_handler() Message-ID: <20190808132456.GA12733@vkoul-mobl.Dlink> References: <20190729020849.17971-1-baijiaju1990@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190729020849.17971-1-baijiaju1990@gmail.com> User-Agent: Mutt/1.11.3 (2019-02-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190808_062611_296339_199DF88E X-CRM114-Status: UNSURE ( 8.02 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alexandre.torgue@st.com, linux-kernel@vger.kernel.org, mcoquelin.stm32@gmail.com, dmaengine@vger.kernel.org, dan.j.williams@intel.com, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 29-07-19, 10:08, Jia-Ju Bai wrote: > In stm32_mdma_irq_handler(), chan is checked on line 1368. > When chan is NULL, it is still used on line 1369: > dev_err(chan2dev(chan), "MDMA channel not initialized\n"); > > Thus, a possible null-pointer dereference may occur. > > To fix this bug, "dev_dbg(mdma2dev(dmadev), ...)" is used instead. Applied after changing subsystem name in patch title to dmaengine: ..., Also while fixing it helps to add Fixes tag, have added Thanks -- ~Vinod _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel