From: Stephen Boyd <sboyd@kernel.org>
To: Yong Liang <yong.liang@mediatek.com>,
chunhui.dai@mediatek.com, drinkcat@chromium.org,
eddie.huang@mediatek.com, erin.lo@mediatek.com,
jamesjj.liao@mediatek.com, jasu@njomotys.info,
mark.rutland@arm.com, matthias.bgg@gmail.com,
mturquette@baylibre.com, owen.chen@mediatek.com,
robh+dt@kernel.org, weiyi.lu@mediatek.com
Cc: "yong.liang" <yong.liang@mediatek.com>,
linux-mediatek@lists.infradead.org, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5,2/2] clk: reset: Modify reset-controller driver
Date: Thu, 08 Aug 2019 08:18:23 -0700 [thread overview]
Message-ID: <20190808151824.97D9E218B6@mail.kernel.org> (raw)
In-Reply-To: <20190726070135.14347-2-yong.liang@mediatek.com>
Quoting Yong Liang (2019-07-26 00:01:35)
> From: "yong.liang" <yong.liang@mediatek.com>
>
> Set reset signal by a register and
> clear reset signal by another register for 8183.
>
> Signed-off-by: yong.liang <yong.liang@mediatek.com>
> ---
Applied to clk-next with this squashed in
diff --git a/drivers/clk/mediatek/clk-mt8183.c b/drivers/clk/mediatek/clk-mt8183.c
index 3f1428ed619b..94bbadc0d259 100644
--- a/drivers/clk/mediatek/clk-mt8183.c
+++ b/drivers/clk/mediatek/clk-mt8183.c
@@ -1198,8 +1198,8 @@ static int clk_mt8183_infra_probe(struct platform_device *pdev)
r = of_clk_add_provider(node, of_clk_src_onecell_get, clk_data);
if (r) {
dev_err(&pdev->dev,
- "%s(): could not register clock provider: %d\n"
- ,__func__, r);
+ "%s(): could not register clock provider: %d\n",
+ __func__, r);
return r;
}
diff --git a/drivers/clk/mediatek/reset.c b/drivers/clk/mediatek/reset.c
index 17df8f8b57ea..cb939c071b0c 100644
--- a/drivers/clk/mediatek/reset.c
+++ b/drivers/clk/mediatek/reset.c
@@ -90,7 +90,7 @@ static const struct reset_control_ops mtk_reset_ops_set_clr = {
.reset = mtk_reset_set_clr,
};
-void mtk_register_reset_controller_common(struct device_node *np,
+static void mtk_register_reset_controller_common(struct device_node *np,
unsigned int num_regs, int regofs,
const struct reset_control_ops *reset_ops)
{
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-08-08 15:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-26 7:01 [PATCH v5,1/2] arm64: dts: mt8183: Add reset-cells in infracfg Yong Liang
2019-07-26 7:01 ` [PATCH v5,2/2] clk: reset: Modify reset-controller driver Yong Liang
2019-08-08 15:18 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190808151824.97D9E218B6@mail.kernel.org \
--to=sboyd@kernel.org \
--cc=chunhui.dai@mediatek.com \
--cc=drinkcat@chromium.org \
--cc=eddie.huang@mediatek.com \
--cc=erin.lo@mediatek.com \
--cc=jamesjj.liao@mediatek.com \
--cc=jasu@njomotys.info \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=mturquette@baylibre.com \
--cc=owen.chen@mediatek.com \
--cc=robh+dt@kernel.org \
--cc=weiyi.lu@mediatek.com \
--cc=yong.liang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).