From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FE25C433FF for ; Thu, 8 Aug 2019 15:18:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D39FE218B6 for ; Thu, 8 Aug 2019 15:18:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gyAYwkm8"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="izYzRRnC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D39FE218B6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:To:From:Subject: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3+0KIaOlrt3B6kWO8DOXcN3snICOqN2t8T19sNYYdcI=; b=gyAYwkm8sqT1mk wpop494xBFVpI2lquKQx4RKV6tMil/FbKbHl6+rZOmn7Chroawsu3g6zyMWjDB/T/kdEe2RzPNnVN 1UxWEMCyw935GCGEq+SYYVqbIQxRzkjWgKKfzyloa30XXWzfnyLmuJ0EpPG3LUdwR6NIhm+Xb4dRX OQvQtyQmSeSYxgdO9SW/jwSTPLxkEkM7WLG3c8aVTkKHsnBs5BydELxl8BhR5RbydkLs4eiOgSVCv 4hkQfRPrDyI1h/1IU83wMkAEeJSPcSEIZzJTy87iRP8wwz/dMQbHt+VnNFuZD8HtXo5AWxMJvA810 gjR+5I97v5K67DLHHKXw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hvkBQ-0007k2-AR; Thu, 08 Aug 2019 15:18:28 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hvkBN-0007jZ-BJ; Thu, 08 Aug 2019 15:18:26 +0000 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 97D9E218B6; Thu, 8 Aug 2019 15:18:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565277504; bh=GBreKkzgwLBpfgFjLLgpU1KqC2MjQOWS3c7usXsHeh8=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=izYzRRnCgZ34ZB9Xp6roK3Vuykt0YcaFUjxA15Wlcnx8p0+ClBJoAh5gcErapUjkf nF9sO52BI2j4PEVO0FUVwE0/6IQHnRl/6XgempRnSqFtquMcfSRvyjieRoxnutKeLT y4d+GO3xn7dbQnvB8WHjJzhSS2e0t+eZMWRNAaac= MIME-Version: 1.0 In-Reply-To: <20190726070135.14347-2-yong.liang@mediatek.com> References: <20190726070135.14347-1-yong.liang@mediatek.com> <20190726070135.14347-2-yong.liang@mediatek.com> Subject: Re: [PATCH v5,2/2] clk: reset: Modify reset-controller driver From: Stephen Boyd To: Yong Liang , chunhui.dai@mediatek.com, drinkcat@chromium.org, eddie.huang@mediatek.com, erin.lo@mediatek.com, jamesjj.liao@mediatek.com, jasu@njomotys.info, mark.rutland@arm.com, matthias.bgg@gmail.com, mturquette@baylibre.com, owen.chen@mediatek.com, robh+dt@kernel.org, weiyi.lu@mediatek.com User-Agent: alot/0.8.1 Date: Thu, 08 Aug 2019 08:18:23 -0700 Message-Id: <20190808151824.97D9E218B6@mail.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190808_081825_409407_19913E42 X-CRM114-Status: UNSURE ( 8.01 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "yong.liang" , linux-mediatek@lists.infradead.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Yong Liang (2019-07-26 00:01:35) > From: "yong.liang" > > Set reset signal by a register and > clear reset signal by another register for 8183. > > Signed-off-by: yong.liang > --- Applied to clk-next with this squashed in diff --git a/drivers/clk/mediatek/clk-mt8183.c b/drivers/clk/mediatek/clk-mt8183.c index 3f1428ed619b..94bbadc0d259 100644 --- a/drivers/clk/mediatek/clk-mt8183.c +++ b/drivers/clk/mediatek/clk-mt8183.c @@ -1198,8 +1198,8 @@ static int clk_mt8183_infra_probe(struct platform_device *pdev) r = of_clk_add_provider(node, of_clk_src_onecell_get, clk_data); if (r) { dev_err(&pdev->dev, - "%s(): could not register clock provider: %d\n" - ,__func__, r); + "%s(): could not register clock provider: %d\n", + __func__, r); return r; } diff --git a/drivers/clk/mediatek/reset.c b/drivers/clk/mediatek/reset.c index 17df8f8b57ea..cb939c071b0c 100644 --- a/drivers/clk/mediatek/reset.c +++ b/drivers/clk/mediatek/reset.c @@ -90,7 +90,7 @@ static const struct reset_control_ops mtk_reset_ops_set_clr = { .reset = mtk_reset_set_clr, }; -void mtk_register_reset_controller_common(struct device_node *np, +static void mtk_register_reset_controller_common(struct device_node *np, unsigned int num_regs, int regofs, const struct reset_control_ops *reset_ops) { _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel