From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E71D9C32754 for ; Thu, 8 Aug 2019 16:58:01 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BE01D2173C for ; Thu, 8 Aug 2019 16:58:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="RxRIET1g"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="HEtOaayA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BE01D2173C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Torj0ALIwV5Owcf+dojPnKwHURD6P7+CtZhEng1BA2I=; b=RxRIET1gohAYrb WOvDEXvhtN6+zDbulIuWJ47h9ZcDzEd3VC0nLf6TRNFGX/rTiTCG8BG4K2AsbrQlczGZzJPP6iiZv LgEwAVrHZV9XMBU4rGFFOWqLbQ6UWMQTzkXbWDkAIUUMtW4SVy3BYAn8DgK3qpKPc1A2p8AjHKh66 eHlbCpJFbQDusDRAwJc2hYyeJTJJa5tRuXdQ1h3K08HvrXjv0m4Hb/OwNmqeJkY1IlUzBkhtPGLZL MrO2Wl0yPeUIwekoXo4ze8gBcxxkC7AZyMzCuxV7yFOdL6miFwXCbNaEF3JFbFxlv23sF4roeT/L2 NytDF9lFyFsuMh3WfN2w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hvljf-00075k-6o; Thu, 08 Aug 2019 16:57:55 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:3201:214:fdff:fe10:1be6]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hvljb-00075F-At for linux-arm-kernel@lists.infradead.org; Thu, 08 Aug 2019 16:57:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=ED7e8Ih4bHyHDCY/4eqes98RiULX2Mf6sQjwvNk6YLI=; b=HEtOaayAs5z8Q5QJuNZExgI6F +T+yjUP8Hqtm24tikmCLflGGfe9VSn1Z082YkaVMXOWfxFGi8lnoUbE2YaL0km1Z0eWOk4LsVu0Va z9eWLGV4vP5t3FZZi30rn0MFUBtloE91Wfre/vO1Xb3ltF3o1EyMonQVtNC15qYhKpt0pEs2yymm3 Fo7kmZSPxiopdMS2S6w4ZQ6wWC4t2hDKHizKG0Tj2RAC4Gyajo+SqJmr5evxLb46Qscw3pujg9UfB 2f6i04O7odGaoWvSU9jdx65LeNs3ycRg+XFkismkKLvfwxTobZA9soPtRmZTOdpeQn9B5JakiuRYz /1lprmjUQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:54188) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1hvljO-00059I-Tx; Thu, 08 Aug 2019 17:57:39 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1hvljK-0002pQ-7m; Thu, 08 Aug 2019 17:57:34 +0100 Date: Thu, 8 Aug 2019 17:57:34 +0100 From: Russell King - ARM Linux admin To: Christoph Hellwig Subject: Re: usb zero copy dma handling Message-ID: <20190808165734.GG5193@shell.armlinux.org.uk> References: <20190808084636.GB15080@priv-mua.localdomain> <20190808161015.GA8470@infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190808161015.GA8470@infradead.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190808_095751_379473_FDA9F8C9 X-CRM114-Status: GOOD ( 10.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: yvahkhfo.1df7f8c2@hashmail.org, linux-usb@vger.kernel.org, security@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 08, 2019 at 09:10:15AM -0700, Christoph Hellwig wrote: > On Thu, Aug 08, 2019 at 10:46:36AM +0200, yvahkhfo.1df7f8c2@hashmail.org wrote: > > --- a/drivers/usb/core/devio.c > > +++ b/drivers/usb/core/devio.c > > @@ -238,9 +238,14 @@ static int usbdev_mmap(struct file *file, struct vm_area_struct *vma) > > usbm->vma_use_count = 1; > > INIT_LIST_HEAD(&usbm->memlist); > > > > +#ifdef CONFIG_X86 > > if (remap_pfn_range(vma, vma->vm_start, > > virt_to_phys(usbm->mem) >> PAGE_SHIFT, > > size, vma->vm_page_prot) < 0) { > > +#else /* !CONFIG_X86 */ > > + if (dma_mmap_coherent(ps->dev->bus->sysdev, > > + vma, mem, dma_handle, size) < 0) { > > +#endif /* !CONFIG_X86 */ > > Doing the dma_mmap_coherent unconditionally is the right thing here. So what if usbm->mem is from kmalloc because the host doesn't support DMA? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel