From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8425EC31E40 for ; Fri, 9 Aug 2019 21:59:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5150B2089E for ; Fri, 9 Aug 2019 21:59:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="EYejkRoK"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="XmhQBsfM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5150B2089E Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:From:Subject:References:Mime-Version :Message-Id:In-Reply-To:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/qRG9CftzI6BGAaqPBlue7W11Lv44k2lxHinbW+ij1E=; b=EYejkRoKpIS9Pw JnqQRqGqDNtIzPtsuGil74ML/MWOkUrRdDIPyX84ZFF6A6/7L10RA1rqlgmxLbK2uZYg6IUR//71V 2a4UMGZdqOzzcoz8nFYqi5QUuH+Ag2GSoNJY8yIy6wV0jggQ0EZSPIkofUewOH3Ik7DW1YvnN2/i4 0+gygU+WHYZSqS3rRPRCFpSurZAgWm1ynu9GcgoJ/sNd0sOX9ftFGzGIo7g5NzWAiubllFvajIZ6q Rft89ByCphkHwLkL+TTAyVqvsnimHVOFSaI6r7EE4pE3fjqidmpo1CP1Lkhjd969WHv2f3Y3DD2ud 84Si69YEhYel0Wn2nPgg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hwCuv-0008A1-2i; Fri, 09 Aug 2019 21:59:21 +0000 Received: from mail-pf1-x449.google.com ([2607:f8b0:4864:20::449]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hwCur-00089H-QQ for linux-arm-kernel@lists.infradead.org; Fri, 09 Aug 2019 21:59:19 +0000 Received: by mail-pf1-x449.google.com with SMTP id 191so62281926pfy.20 for ; Fri, 09 Aug 2019 14:59:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=aHPozI+kRmLZ/MJlV7luwBtUMjEIFkgoeCnOJismWTA=; b=XmhQBsfMHALmx6QOLM9UBumnO7+O8bCcXOWfbEhvnKPRZtyZjK8Tox3QlWh+5SsoHo nSFWQ4AXRB5rGt1kt3KE4aQEc1I3c3lRuL9npZ/+GiDm5vL+RU7MnPYmUFcMbJyKb6ra WcTRcRm2FQ6DDaHqNyLsrOSB632i+21o8ygllWidqV7vliACQwXLx06D5cWErjUfEvvk oS6tlLYGXRIUWgi8FZPNnxObKBs0OQf/b3sPOwVn84irLt21e12rwexZf1dIbzAlT4UU pC9A8HRAZ1JoHP5xAxw+zFJ7gBhI3E9LOkogGnAloitRhXpmiawVE738kNJQ2UpHPLsi ecbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=aHPozI+kRmLZ/MJlV7luwBtUMjEIFkgoeCnOJismWTA=; b=m1T22764nJwgWwkgj30IAp1GEjx5CnP+8tej7ZFg2IIW4IIzg9GFk8NPh4x5YkLU9c YHHGI14y1Hetk823rH1lnswblhH02l69Ag57b7Dfc7I3HppkoIzpkBW7GoIY5xjFtF3b iWdgz84EguoZJh76UQ8joV+rEdQ7Y5wibM5qBd2DmuCO95ZzIR6IribZ3O09CLZGceVf wc33nc+ye2GZ7RiBLOzra5z4MVlz03fmBso+7T8ouOUohbu2o9+vN2h2pAYgGwWrk7tm XWxyksM+q2CRtYVDSgyxy8ffL1MldwBsoC4+hYIUO2CW5MwDCdconTVUJkEgHTPMZ9Ph loBw== X-Gm-Message-State: APjAAAUsYq5xQQ2Dwj8V1MCQsukg9UrDQDxYxj6VILg2uEAsGGS3zy9T dvuSAvo7ddTTdcr41IFWoYA9hX62Iw== X-Google-Smtp-Source: APXvYqyz8CcNShPWSHPO/FAxHKFz6gmTSkkw/fYF/3ATwxbLzpgLwoS9L+u1s86mqzbQrSNfPjRKv0frajw= X-Received: by 2002:a63:bf01:: with SMTP id v1mr18841445pgf.278.1565387955717; Fri, 09 Aug 2019 14:59:15 -0700 (PDT) Date: Fri, 9 Aug 2019 14:58:48 -0700 In-Reply-To: Message-Id: <20190809215848.47736-1-yabinc@google.com> Mime-Version: 1.0 References: X-Mailer: git-send-email 2.23.0.rc1.153.gdeed80330f-goog Subject: Re: [PATCH] coresight: Serialize enabling/disabling a link device. From: Yabin Cui To: Mathieu Poirier , Suzuki K Poulose , Alexander Shishkin X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190809_145917_883724_AA3A3CB3 X-CRM114-Status: UNSURE ( 5.47 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Yabin Cui , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org >You may also want to protect the refcount checks below with the same lock, just >to be consistent. Good suggestion! I didn't protect it because I found other places using refcnt. But it turns out they are not link devices. I have uploaded patch v2. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel