From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B82DC31E40 for ; Mon, 12 Aug 2019 15:05:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5FD2C208C2 for ; Mon, 12 Aug 2019 15:05:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="VgigtWBO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5FD2C208C2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vJJSZYUcmtwOrTqROVJfmgaAvjPARQU96q5yIThBB4Y=; b=VgigtWBOwkn7Bi aUjnp1KhfA4tAwzBvpP4BusMaybRQA0NHbpNPqR1BF8FQo4DJIMPIUwQ85i5VzGceDYaCQFiqpS4+ LLSI4tLdPJqOVIYd00/knBn9i+3BBDTcIiHsZP1fFWtgnvbL/qmGKLtF3f32syvH4fP7ONAv4466O gTZzF1vAGm+IMDgPcW4kD6JXxBlLJKtWxasqkR2YLPkyKD9d7Xc+lMiCU/rFbC7vzfKEIfERQQJve NyFsyk4BMvw/f3cd6w7ZgrMAmUk7hqZ27A4bK5sQQKqTsrLc1FGdigUVOsFPj4yTCIncgreIjOy6w Pah9zHV2vBc2t3jUGWyQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hxBt5-00080J-Qr; Mon, 12 Aug 2019 15:05:31 +0000 Received: from relay6-d.mail.gandi.net ([217.70.183.198]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hxBt1-0007z1-Iw for linux-arm-kernel@lists.infradead.org; Mon, 12 Aug 2019 15:05:29 +0000 X-Originating-IP: 92.137.69.152 Received: from localhost (alyon-656-1-672-152.w92-137.abo.wanadoo.fr [92.137.69.152]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id D09B9C0002; Mon, 12 Aug 2019 15:05:15 +0000 (UTC) Date: Mon, 12 Aug 2019 17:05:15 +0200 From: Alexandre Belloni To: Colin King Subject: Re: [PATCH] tty/serial: atmel: remove redundant assignment to ret Message-ID: <20190812150515.GQ3600@piout.net> References: <20190809174042.6276-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190809174042.6276-1-colin.king@canonical.com> User-Agent: Mutt/1.12.0 (2019-05-25) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190812_080527_774668_2C83C5A0 X-CRM114-Status: GOOD ( 14.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Genoud , Greg Kroah-Hartman , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Ludovic Desroches , linux-serial@vger.kernel.org, Jiri Slaby , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 09/08/2019 18:40:42+0100, Colin King wrote: > From: Colin Ian King > > Variable ret is initialized to a value that is never read and it > is re-assigned later. The initialization is redundant and can be > removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King Acked-by: Alexandre Belloni > --- > drivers/tty/serial/atmel_serial.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c > index 0b4f36905321..19a85d6fe3d2 100644 > --- a/drivers/tty/serial/atmel_serial.c > +++ b/drivers/tty/serial/atmel_serial.c > @@ -2888,7 +2888,7 @@ static int atmel_serial_probe(struct platform_device *pdev) > struct atmel_uart_port *atmel_port; > struct device_node *np = pdev->dev.parent->of_node; > void *data; > - int ret = -ENODEV; > + int ret; > bool rs485_enabled; > > BUILD_BUG_ON(ATMEL_SERIAL_RINGSIZE & (ATMEL_SERIAL_RINGSIZE - 1)); > -- > 2.20.1 > -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel