From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E018C32750 for ; Tue, 13 Aug 2019 11:41:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0F5D9204EC for ; Tue, 13 Aug 2019 11:41:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="h+hGJl1s"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="hR9C8Sdb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0F5D9204EC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SEfPtJ8i0QCz5w6hzHtr2dwQ9vjRV+urYNU+uYqFp7M=; b=h+hGJl1sNV8clZ 4UDnGevTQnAl/SYdEwrsxS7Z7hLKDxzXCozKEJ9B8lMVRO6FPNpe8OYxaujRkiIi07o2WSPrSD4wW 3SPWLonz0dOihxBMNQ99J72hVk3TdMizz4W0PYeXN9rqMbn+R0jU7+2RCIlFxSqK0mHPL0IFgbNSE SjVBTBtYyapp/9oVr1v5M993E+tff7J2dtrgUeEx8+t8GeVGT1FmX71offw41uj4qc2fTugYuRdDa SkE+SH1XMUUY7iPB5/qwgx7Kt4JswY3cdqy0YqZyiweVsopp+6zIFF7bydnZQ8dUzuWwzC4yxStDu UJKDg9HrBIGpToS7nyqw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hxVAq-0005mi-El; Tue, 13 Aug 2019 11:41:08 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:3201:214:fdff:fe10:1be6]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hxVAn-0002gk-Qm for linux-arm-kernel@lists.infradead.org; Tue, 13 Aug 2019 11:41:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=OhLDQQN+hbiEAG1TpQP8a/y4fpxqsnBJK9G3iQ2C2s4=; b=hR9C8SdbOHH8WqJOQWEwqSr9I lwLZSuUVnKR8i72bzk8GJ87wf6D5jPsRm8eA88Skhp56CD9oCqXvvC7ed9eX0kBjNeOR52PaU749P oofDaSOufoispmGRH8UprhrwSFfOakR0EJWiCgwg9BgNEsGKIWUmv0CHxNqsPu2ixQ+wuA7aQDJCf AZ8EhtXC/8XV9OGEHWNz5tSohTsDaYmGbvTJIJPxr7cb7u7e8DWbvk8ciX5NR8wnxebry9pwuv7W3 ruzfmL+qbDeCKTpXkC9O8p1A0oyTqaS9KvxNRNwcoD28dpo7fOdWlXIyca66wqUQLDqglMufmZmut pNT+hXJkg==; Received: from shell.armlinux.org.uk ([2001:4d48:ad52:3201:5054:ff:fe00:4ec]:44432) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1hxV8a-0008Tv-Jc; Tue, 13 Aug 2019 12:38:48 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1hxV8Y-0007T9-Pj; Tue, 13 Aug 2019 12:38:46 +0100 Date: Tue, 13 Aug 2019 12:38:46 +0100 From: Russell King - ARM Linux admin To: Manivannan Sadhasivam Subject: Re: [PATCH v2 1/3] dt-bindings: media: i2c: Add IMX290 CMOS sensor binding Message-ID: <20190813113846.GG13294@shell.armlinux.org.uk> References: <20190806130938.19916-1-manivannan.sadhasivam@linaro.org> <20190806130938.19916-2-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190806130938.19916-2-manivannan.sadhasivam@linaro.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190813_044105_862344_D5CB04B9 X-CRM114-Status: GOOD ( 11.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, c.barrett@framos.com, linux-kernel@vger.kernel.org, a.brela@framos.com, robh+dt@kernel.org, mchehab@kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 06, 2019 at 06:39:36PM +0530, Manivannan Sadhasivam wrote: > +Required Properties: > +- compatible: Should be "sony,imx290" > +- reg: I2C bus address of the device > +- clocks: Reference to the xclk clock. > +- clock-names: Should be "xclk". > +- clock-frequency: Frequency of the xclk clock. Driver code: + ret = of_property_read_u32(dev->of_node, "clock-frequency", &xclk_freq);+ if (ret) { + dev_err(dev, "Could not get xclk frequency\n"); + return ret; + } + + /* external clock must be 37.125 MHz */ + if (xclk_freq != 37125000) { + dev_err(dev, "External clock frequency %u is not supported\n", + xclk_freq); + return -EINVAL; + } So, only 37125000 is supported - is that not worth mentioning in this description? Is this a hard requirement of the sensor? If so, why does it need to be mentioned in the DT binding? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel