From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5CE7C433FF for ; Tue, 13 Aug 2019 15:38:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 87C8820679 for ; Tue, 13 Aug 2019 15:38:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="tf/zBmcE"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="SrBu8AYa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 87C8820679 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gSyp1kVcCAdVfBZw4Ep8iggZOM1VO8B4RQMStR8I2G4=; b=tf/zBmcEcKqC1T DNkai46hD4Nz1We38FMo0DG2TQq0Oy2TWuskSKz/48wRJ0l4onW716XFokmbIc6vZtYUrsDSFmOeR YsuDmjfXymwhDVzPvCmD6bB8igV2L0lsmFFbMS6dvkWW9RfhYRbLcOVvEEq/7JMFl0DCBZ7p/4CSB 0IFBcHy2g7FRrB4FbaSUQgNGlGRTpY2ZYl/LW0MorM9lstXC/hEfwoMCFPCs5zzbvOYXbXt2MKOr9 c9Cb/0NM7+FAXqGU2eCFsZ05YnEVbadLH9UZNcmLW+me54elBYAkhA1tDBhz0yqfVR0tmbc7xfUQW gOxMyVn34mOBE7irIo/w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hxYsW-0000wp-LQ; Tue, 13 Aug 2019 15:38:28 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hxYsT-0000wN-ST for linux-arm-kernel@lists.infradead.org; Tue, 13 Aug 2019 15:38:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=BJYOCOgG3vSFD6B2/NaAeHaq/xMvIZnICqXhFcn1r2g=; b=SrBu8AYaayxZtoAvX73LOWV53W T30rx8Yp718aJXL83KUA1lrCEW1ZrAbyOCuuhybNrVEaIkILwcAOzqx69S859eUT3ouinPFsNGR77 A7UlK8svth/iQczY5jhEFoTPqXqCITyi7pPix70VltvRCfq9gnp4Iq7SS8pNZMUXIovY=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hxYsO-0002VJ-T4; Tue, 13 Aug 2019 17:38:20 +0200 Date: Tue, 13 Aug 2019 17:38:20 +0200 From: Andrew Lunn To: Harini Katakam Subject: Re: [PATCH 2/2] net: gmii2rgmii: Switch priv field in mdio device structure Message-ID: <20190813153820.GY14290@lunn.ch> References: <1564565779-29537-1-git-send-email-harini.katakam@xilinx.com> <1564565779-29537-3-git-send-email-harini.katakam@xilinx.com> <20190801040648.GJ2713@lunn.ch> <20190813132321.GF15047@lunn.ch> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190813_083826_069565_993F1D65 X-CRM114-Status: UNSURE ( 7.38 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Florian Fainelli , netdev@vger.kernel.org, radhey.shyam.pandey@xilinx.com, Michal Simek , linux-kernel@vger.kernel.org, Harini Katakam , David Miller , linux-arm-kernel@lists.infradead.org, Heiner Kallweit Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org > > The kernel does have a few helper, spi_get_drvdata, pci_get_drvdata, > > hci_get_drvdata. So maybe had add phydev_get_drvdata(struct phy_device > > *phydev)? > > Maybe phydev_mdio_get_drvdata? Because the driver data member available is > phydev->mdio.dev.driver_data. I still prefer phydev_get_drvdata(). It fits with the X_get_drvdata() pattern, where X is the type of parameter passed to the call, spi, pci, hci. We can also add mdiodev_get_drvdata(mdiodev). A few DSA drivers could use that. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel