From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B73EC433FF for ; Wed, 14 Aug 2019 23:15:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3855A2064A for ; Wed, 14 Aug 2019 23:15:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gRH5re/Y"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="VXD0g4V2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3855A2064A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6s00mYusmi3e+IFZkUjHLBHJ8BygriPmxK1QgtAJP/I=; b=gRH5re/YRqmRSV JhPwFLK6tNpCC3S5hXnQOcVvIB3N14G9aoxkS5dt1TJxFLScdP/ieog2QOXXpIteP1RuhOoSSzUiF AmRc+KjqS6Fthi27Ci4z/BUKVEJ5rEZ3pBK94CXQv0s9jww+zQDyRmarDyaF/kKus+NgVanWYC1jl zXXEl/vBopzaoqoS/oTe+SfJlyq56JRcFYJP6BuhzVCAhwn6QnUslvi6Mi+cS+c181JCLgFeU3Z0i 5UiHbagVK9tXgwwTJUmHHQS70SV6RIqAobb7kNIVEyCDoEWbJyExejIJx0vZ9KkuN4Yde3XYsNSmP t0vkNu7i5QgS4C9IkHwQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hy2Ub-0003KA-C7; Wed, 14 Aug 2019 23:15:45 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:3201:214:fdff:fe10:1be6]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hy2UY-0003Jq-9w for linux-arm-kernel@lists.infradead.org; Wed, 14 Aug 2019 23:15:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Sv8Sj/ixrwVpwf8DeTHbHSgly+psCtFNDpFCJOhRNgI=; b=VXD0g4V281rMfgDBwNQrhqToY Rofd7NDIEbm3Vz1ioV6aWOUztfLTHdbu08ljSYbtOj3zmAfuRTHxMp4Sza+dVWS4MDh0tylqLZK6p DaXZT08DU/9+3eRcHB93R8gX/PvCcoMQatqBg48tSQV/rN+ce7/hZbzc9xeJ+qZdlnywyACGXInXL c5v/opELXGIvgAHbro/ay9sd2K+Kit77hOSyOn9DjyI5mJeVJ/m5ajijKWuJx0AQmEoyKXRb1D7N+ DEJfLqTuLbyw/+TpBSEMhlYx3YCqL4AmfFig06YzZXim8D1rHnOYIHn0hxYxJRm7Hf8OOswEJ1/T8 QDjOCAWlQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:56690) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1hy2U8-0000f6-8R; Thu, 15 Aug 2019 00:15:16 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1hy2U1-0000Pe-LG; Thu, 15 Aug 2019 00:15:09 +0100 Date: Thu, 15 Aug 2019 00:15:09 +0100 From: Russell King - ARM Linux admin To: Steve Longerbeam Subject: Re: [PATCH 04/22] media: Move v4l2_fwnode_parse_link from v4l2 to driver base Message-ID: <20190814231509.GK13294@shell.armlinux.org.uk> References: <20190805233505.21167-1-slongerbeam@gmail.com> <20190805233505.21167-5-slongerbeam@gmail.com> <4750b347-b421-6569-600f-0ced8406460e@gmail.com> <20190814103054.GI13294@shell.armlinux.org.uk> <20190814220437.GJ13294@shell.armlinux.org.uk> <1842bf8f-4f97-6294-41db-74f9f8e2befd@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1842bf8f-4f97-6294-41db-74f9f8e2befd@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190814_161542_349926_32282AD3 X-CRM114-Status: GOOD ( 21.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heikki Krogerus , Sakari Ailus , "Rafael J. Wysocki" , Laurent Pinchart , Shawn Guo , Fabio Estevam , "open list:STAGING SUBSYSTEM" , Mauro Carvalho Chehab , Michal Simek , "open list:ACPI" , Andy Shevchenko , NXP Linux Team , Len Brown , Philipp Zabel , Sascha Hauer , Thomas Gleixner , Andy Shevchenko , "moderated list:ARM/ZYNQ ARCHITECTURE" , Hyun Kwon , Greg Kroah-Hartman , open list , Jacopo Mondi , Pengutronix Kernel Team , Hans Verkuil , Linux Media Mailing List , Enrico Weigelt Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Aug 14, 2019 at 04:00:30PM -0700, Steve Longerbeam wrote: > > > On 8/14/19 3:04 PM, Russell King - ARM Linux admin wrote: > > On Wed, Aug 14, 2019 at 12:04:41PM -0700, Steve Longerbeam wrote: > > > > > > On 8/14/19 3:30 AM, Russell King - ARM Linux admin wrote: > > > > On Tue, Aug 06, 2019 at 09:53:41AM -0700, Steve Longerbeam wrote: > > > > > The full patchset doesn't seem to be up yet, but see [1] for the cover > > > > > letter. > > > > Was the entire series copied to the mailing lists, or just selected > > > > patches? I only saw 4, 9, 11 and 13-22 via lakml. > > > The whole series was posted to the linux-media ML, see [1]. At the time, > > > none of the linux-media ML archives had the whole series. > > > > > > > In the absence of the other patches, will this solve imx-media binding > > > > the internal subdevs of sensor devices to the CSI2 interface? > > > "internal subdevs of sensor devices" ?? That doesn't make any sense. > > Sorry, but it makes complete sense when you consider that sensor > > devices may have more than one subdev, but there should be only one > > that is the "output" to whatever the camera is attached to. The > > other subdevs are internal to the sensor. > > Ah, thanks for the clarification. Yes, by "internal subdevs" I understand > what you mean now. The adv748x and smiapp are examples. > > > > > subdevs are not purely the remit of SoC drivers. > > So there is no binding of internal subdevs to the receiver CSI-2. The > receiver CSI-2 subdev will create media links to the subdev that has an > externally exposed fwnode endpoint that connects with the CSI-2 sink pad. Maybe - with 5.2, I get: - entity 15: imx6-mipi-csi2 (5 pads, 6 links) type V4L2 subdev subtype Unknown flags 0 device node name /dev/v4l-subdev2 pad0: Sink ... <- "imx219 0-0010":0 [] <- "imx219 pixel 0-0010":0 [] Adding some debug in gives: [ 11.963362] imx-media: imx_media_create_of_links() for imx6-mipi-csi2 [ 11.963396] imx-media: create_of_link(): /soc/aips-bus@2000000/iomuxc-gpr@20e0000/ipu1_csi0_mux [ 11.963422] imx-media: create_of_link(): /soc/ipu@2400000 [ 11.963450] imx-media: create_of_link(): /soc/ipu@2800000 [ 11.963478] imx-media: create_of_link(): /soc/aips-bus@2000000/iomuxc-gpr@20e0000/ipu2_csi1_mux [ 11.963489] imx-media: imx6-mipi-csi2:4 -> ipu2_csi1_mux:0 [ 11.963522] imx-media: create_of_link(): /soc/aips-bus@2100000/i2c@21a0000/camera@10 [ 11.963533] imx-media: imx219 0-0010:0 -> imx6-mipi-csi2:0 [ 11.963549] imx-media: imx_media_create_of_links() for imx219 pixel 0-0010 [ 11.963577] imx-media: create_of_link(): /soc/aips-bus@2100000/mipi@21dc000 [ 11.963587] imx-media: imx219 pixel 0-0010:0 -> imx6-mipi-csi2:0 [ 11.963602] imx-media: imx_media_create_of_links() for imx219 0-0010 Note that it's not created by imx6-mipi-csi2, but by imx-media delving around in the imx219 subdevs. >From what I can see, smiapp does the same thing that I do in imx219 - sets the subdev->dev member to point at the struct device, which then means that v4l2_device_register_subdev() will associate the same fwnode with both "imx219 pixel 0-0010" and "imx219 0-0010". -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel