From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2978C3A589 for ; Thu, 15 Aug 2019 19:36:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A57BC20656 for ; Thu, 15 Aug 2019 19:36:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XTtoshKr"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="dNlzOMvc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A57BC20656 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:To:From:Subject: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=N7z3YChmKhfkJc/Rx0pxLN1ALcfcjYgk1oy44a7OmIM=; b=XTtoshKr01AQ5u Pz0bQkvRLpx8PUJS9B4NvoiWBLLOe0YR4JdBt4WknFDzprlTWSEzBM7yc4y2UL/nUxc/olsSDIdyo X+jxgsE7V7lTEH+cMFspiionAdKTaFqZtpzmtgeOuuiShKEPjDUe+k0kublzj+sPIX4zvoFlqvCZf CmtV5SXXND+QzdKcLOpRV4g0uKQYW+W7p99k7t04F+pQUBFDrY9MpSKP/vVXQkbZU0JS1KYQA1epH prS1Dk8mNFUaF7h0MCZ55JBcrrliLnPkfI4CG5rkt8RkDWqi0GokxvNkLGmkNSdfmFO5p8ux2vElu FRB6B9eaA+YLdginMlzA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hyLY1-0002SF-5y; Thu, 15 Aug 2019 19:36:33 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hyLXy-0002RW-9a for linux-arm-kernel@lists.infradead.org; Thu, 15 Aug 2019 19:36:31 +0000 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2C1EB20656; Thu, 15 Aug 2019 19:36:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565897789; bh=EW0TSpgRvmluEEbkBDw/BeuuXW6cPt71WV5w74ebqrg=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=dNlzOMvcy/GqjHHKA+gBnz7GlvSplNcldf6dGBVNeqVLShEGKF5uN9e27kiTUr2R5 pClxyDelehLdhTpVScj3Q2l1kVV6e09YEG2TbPlivD7nkWZjZH1w4VTI28rIsss71Q 6f4gRhHyznQQ4YDf6zHR2urAhGi2qMrq1Wu6DC+A= MIME-Version: 1.0 In-Reply-To: References: Subject: Re: [PATCH 0/4] clk: imx8m: Fix incorrect parents From: Stephen Boyd To: Abel Vesa , Jacky Bai , Leonard Crestez , Shawn Guo User-Agent: alot/0.8.1 Date: Thu, 15 Aug 2019 12:36:28 -0700 Message-Id: <20190815193629.2C1EB20656@mail.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190815_123630_350168_0933C647 X-CRM114-Status: UNSURE ( 7.36 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dong Aisheng , Anson Huang , Michael Turquette , linux-imx@nxp.com, kernel@pengutronix.de, Fabio Estevam , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Leonard Crestez (2019-08-13 10:05:27) > No checks are made to ensure the parents in the _sels arrays actually > exist and it turns out that several are incorrect. > > I found the errors using a hack to clk core, is there a better way? > Link: https://github.com/cdleonard/linux/commit/da32c2e76eb373e8a03aec905af2eef28a7997a7 Maybe you can make it into some sort of Kconfig option that's behind a debug flag. Or you can use the possible parent debugfs files and check for parents from userspace with some script. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel