From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E36E7C3A589 for ; Thu, 15 Aug 2019 22:51:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B49CA206C2 for ; Thu, 15 Aug 2019 22:51:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PElDzWa0"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=onstation.org header.i=@onstation.org header.b="kbBRmB2A" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B49CA206C2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=onstation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=A5b2u8uslBkYDu/U6j1UXzoYVAQ9+DTEj+qgpY9dct8=; b=PElDzWa0r0NzAv dL9vuou+GirgBv9WUCkr+XMpt1iedYjRInsFTPipMLnUiQOfHVoi0oWte7j25hmEVN4m9GwJp/t/0 HTM/QDfyqz6T26WoSKxMdEUbGflDFMKTHwZ2BHxeZyoe1XKw8ywZIl9TLQDmLpC9Ilh+fEXy3pYMr FVbReV1Uwn7nl7r8kAqwgRq1MuHfFwFuUe8QU/fFNRjLoPmqf3ABjlZhAQastASZ9DDmyQbknWUna xpJdGzvoYUU6tguvsS/FswbqutS5kC6ssIYKP7NsGQVKnBGIWmBYDiuv664TMkkrMD87TMQidq9eF +Az1Y54s/d7gh+e80XzQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hyOaN-0003j9-Es; Thu, 15 Aug 2019 22:51:11 +0000 Received: from onstation.org ([52.200.56.107]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hyOaJ-0003iS-Tr for linux-arm-kernel@lists.infradead.org; Thu, 15 Aug 2019 22:51:09 +0000 Received: from localhost (c-98-239-145-235.hsd1.wv.comcast.net [98.239.145.235]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: masneyb) by onstation.org (Postfix) with ESMTPSA id D89F23E998; Thu, 15 Aug 2019 22:51:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=onstation.org; s=default; t=1565909466; bh=GlErRnlbnhtp3xOCD8QDuEBNzdpIzm/CEjl/t+YePi4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kbBRmB2Ag3E2vXFKqyIe3P3JBKnDCf2Gw4yfO4jcxecQTEdBlDWG3wDJ+vxPQ+XQN a1BNwFsIm8w50ApVariWEfK20tN4ggz3LwN3Ya5I93TAxtpu1h1nThdsONxNN6uX7o QkSapavjafeT34+PmnZN/YYXcO0hocqwBz5MLwfA= Date: Thu, 15 Aug 2019 18:51:04 -0400 From: Brian Masney To: Linus Walleij Subject: Re: [PATCH RFC 06/11] drm/bridge: analogix-anx78xx: add support for avdd33 regulator Message-ID: <20190815225104.GB32072@onstation.org> References: <20190815004854.19860-1-masneyb@onstation.org> <20190815004854.19860-7-masneyb@onstation.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190815_155108_029783_148529BE X-CRM114-Status: GOOD ( 18.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Jernej Skrabec , Neil Armstrong , Dave Airlie , "linux-kernel@vger.kernel.org" , Jonas Karlman , Andy Gross , "open list:DRM PANEL DRIVERS" , Bjorn Andersson , Andrzej Hajda , Rob Clark , Rob Herring , Laurent Pinchart , Daniel Vetter , MSM , Enric Balletbo i Serra , freedreno , Sean Paul , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 15, 2019 at 10:22:45AM +0200, Linus Walleij wrote: > On Thu, Aug 15, 2019 at 2:49 AM Brian Masney wrote: > > > Add support for the avdd33 regulator to the analogix-anx78xx driver. > > Note that the regulator is currently enabled during driver probe and > > disabled when the driver is removed. This is currently how the > > downstream MSM kernel sources do this. > > > > Let's not merge this upstream for the mean time until I get the external > > display fully working on the Nexus 5 and then I can submit proper > > support then that powers down this regulator in the power off function. > > > > Signed-off-by: Brian Masney > > > +static void anx78xx_disable_regulator_action(void *_data) > > +{ > > + struct anx78xx_platform_data *pdata = _data; > > + > > + regulator_disable(pdata->avdd33); > > +} > (...) > > + err = devm_add_action(dev, anx78xx_disable_regulator_action, > > + pdata); > > Clever idea. Good for initial support, probably later on it would > need to be reworked using runtime PM so it's not constantly > powered up. Yes, that's my plan. I suspect that I may have a regulator disabled somewhere so I was planning to leave this on all the time for the time being to match the downstream behavior until I get the hot plug detect GPIO working. > Reviewed-by: Linus Walleij Thanks, Brian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel