From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10757C3A59E for ; Fri, 16 Aug 2019 09:48:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DBDD121721 for ; Fri, 16 Aug 2019 09:48:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Keaffp0W"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="VsKGOtqv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DBDD121721 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=HOtfwpP6ZQ+eKH0pfBhC4KNSDIfTY6FsKUfz5wWC48I=; b=Keaffp0WXNo+jpCUdHTorddkE S5d1T5YtUIq9xWxrNnw/l2RUTBgtjAblAshk35d1RDopfemMLITpZy+6j3WDZs8LcOTHr63j3s7le Nt2Ynmj6Rw5XMPsZqpQsxqIuPZ5JsfL7bJC0LPTqdeUj9c9sjvGK7Jg0b+CsRGL1TB8OojkHazKqH Rru6QqPSqLKlenI9y0dI6788JLctw8S1wkp88tFJg91RFnVq++4GvHdDUJm/cqXm19/d6jXe17RRa 2NvDXoLx0EXncGSxX2DNZww3PPasI5pz/PXJYmJI0fWpgg5qo2D7ivRGCF/AIUzjInjIVRHJAs8t/ 4ZTlwzavw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hyYqL-0007gI-ES; Fri, 16 Aug 2019 09:48:21 +0000 Received: from merlin.infradead.org ([2001:8b0:10b:1231::1]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hyYqJ-0007gA-Q4 for linux-arm-kernel@bombadil.infradead.org; Fri, 16 Aug 2019 09:48:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=mD9ClRBue1XFA4KcgMq3vDk+RqrW0ppD8k04D80FnEM=; b=VsKGOtqvSR5jGndo96dxoFlNN 3cDBKv7Gco5fBKsSKujsiVs0dcK39WT/zTbt/T7fmkhe8y5C45WpPWYR+OJfvi5VAeNlAI3obwwwm T6/nMLKMJsosACKPzBYkTIYbgkUMB1E4iMannJYhxSPrMPX8qTTzSdR2xMaiiXkOBS1Kx+Dv+OQQ5 WluexYOPVhEIZd4BFfSOa2WSJP7PNHFemp+K40ml9p+9EzOVZ8hmXEAJobxHAwSKGjxeE96zFobrq b8XvhzbO5fQ2N2wbJCQozmoPWjH7lJsR14j802qf2P7DLeJmzVNSmzG6zBN1BzKjXl5LuaRvXa3fO m1GfodaEg==; Received: from relay3-d.mail.gandi.net ([217.70.183.195]) by merlin.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hyYqF-0005wL-Uu for linux-arm-kernel@lists.infradead.org; Fri, 16 Aug 2019 09:48:18 +0000 X-Originating-IP: 86.250.200.211 Received: from localhost (lfbn-1-17395-211.w86-250.abo.wanadoo.fr [86.250.200.211]) (Authenticated sender: maxime.ripard@bootlin.com) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 1026C60005; Fri, 16 Aug 2019 09:47:36 +0000 (UTC) Date: Fri, 16 Aug 2019 11:47:36 +0200 From: Maxime Ripard To: Frank Lee Subject: Re: [PATCH v5 02/18] dt-bindings: thermal: add binding document for h6 thermal controller Message-ID: <20190816094736.cbxkqk7q2jvvp7c7@flea> References: <20190810052829.6032-1-tiny.windzz@gmail.com> <20190810052829.6032-3-tiny.windzz@gmail.com> <20190812085604.ozhl35wwm3ehlvqn@flea> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20180716 X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree , Linux PM , Greg Kroah-Hartman , Daniel Lezcano , Linux Kernel Mailing List , Eduardo Valentin , Chen-Yu Tsai , Rob Herring , Jonathan.Cameron@huawei.com, Mauro Carvalho Chehab , rui.zhang@intel.com, David Miller , Linux ARM Content-Type: multipart/mixed; boundary="===============0140245405236451464==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============0140245405236451464== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="e3oyg4ksww5uov3y" Content-Disposition: inline --e3oyg4ksww5uov3y Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Aug 13, 2019 at 07:40:44AM +0800, Frank Lee wrote: > On Mon, Aug 12, 2019 at 4:56 PM Maxime Ripard wrote: > > > > On Sat, Aug 10, 2019 at 05:28:13AM +0000, Yangtao Li wrote: > > > This patch adds binding document for allwinner h6 thermal controller. > > > > > > Signed-off-by: Yangtao Li > > > --- > > > .../bindings/thermal/sun8i-thermal.yaml | 79 +++++++++++++++++++ > > > 1 file changed, 79 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/thermal/sun8i-thermal.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/thermal/sun8i-thermal.yaml b/Documentation/devicetree/bindings/thermal/sun8i-thermal.yaml > > > new file mode 100644 > > > index 000000000000..e0973199ba3c > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/thermal/sun8i-thermal.yaml > > > > We've used so far for the schemas the first compatible to introduce > > that controller as the filename, we should be consistent here. In that > > case that would be allwinner,sun8i-a23-ths.yaml > > > > > @@ -0,0 +1,79 @@ > > > +# SPDX-License-Identifier: GPL-2.0 > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/thermal/sun8i-thermal.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Allwinner SUN8I Thermal Controller Device Tree Bindings > > > + > > > +maintainers: > > > + - Yangtao Li > > > + > > > +description: |- > > > + This describes the device tree binding for the Allwinner thermal > > > + controller which measures the on-SoC temperatures. > > > + > > > +properties: > > > + compatible: > > > + enum: > > > + - allwinner,sun50i-h6-ths > > > + > > > + reg: > > > + maxItems: 1 > > > + > > > + interrupts: > > > + maxItems: 1 > > > + > > > + resets: > > > + maxItems: 1 > > > + > > > + clocks: > > > + maxItems: 1 > > > + > > > + clock-names: > > > + const: bus > > > + > > > + "#thermal-sensor-cells": > > > + const: 1 > > > + > > > + nvmem-cells: > > > > You need a maxItems here too > > > > > + description: ths calibrate data > > > > What about something like this: > > > > Calibration data for the thermal sensor > > > > > + > > > + nvmem-cell-names: > > > + const: calib > > > > I'm not sure we need a abbreviation here, calibration would be more > > explicit > > > > > + > > > +required: > > > + - compatible > > > + - reg > > > + - reset > > > + - clocks > > > + - clock-names > > > + - interrupts > > > + - "#thermal-sensor-cells" > > > + > > > +additionalProperties: false > > > + > > > +examples: > > > + - | > > > + ths: ths@5070400 { > > > + compatible = "allwinner,sun50i-h6-ths"; > > > + reg = <0x05070400 0x100>; > > > + clocks = <&ccu CLK_BUS_THS>; > > > + clock-names = "bus"; > > > + resets = <&ccu RST_BUS_THS>; > > > + interrupts = ; > > > > Those examples won't compile. > > Emmm, I have some questions about this. > I added this information and it can be compiled. With your patch applied, $ ARCH=arm DT_SCHEMA_FILES=Documentation/devicetree/bindings/thermal/sun8i-thermal.yaml make -j4 dt_binding_check CHKDT Documentation/devicetree/bindings/thermal/sun8i-thermal.yaml DTC Documentation/devicetree/bindings/thermal/sun8i-thermal.example.dt.yaml Error: Documentation/devicetree/bindings/thermal/sun8i-thermal.example.dts:20.28-29 syntax error FATAL ERROR: Unable to parse input tree make[2]: *** [scripts/Makefile.lib:299: Documentation/devicetree/bindings/thermal/sun8i-thermal.example.dt.yaml] Error 1 make[1]: *** [/home/max/Work/src/linux/Makefile:1286: dt_binding_check] Error 2 make: *** [/home/max/Work/src/linux/Makefile:179: sub-make] Error 2 Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --e3oyg4ksww5uov3y Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXVZ7uAAKCRDj7w1vZxhR xWTKAQDfLyzi2ALbODyX2kPcPMmaLcp2tRh8IqLRMr6zqYgqDgD/dgWM62HXzihe 5V5fiOFI853nEXxoNxr4cglIprifmAw= =nc3f -----END PGP SIGNATURE----- --e3oyg4ksww5uov3y-- --===============0140245405236451464== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============0140245405236451464==--