From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BA78C3A59C for ; Fri, 16 Aug 2019 16:40:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5E7192077C for ; Fri, 16 Aug 2019 16:40:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="aMYZtkeH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5E7192077C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Z+4chrVUY80AqfXrsUOiiRGNG/G7SeEWKymXsMV0FXE=; b=aMYZtkeHKs6If3 pyNDvthJWmZ80wzCB6RrLMHonbl0vBYBga5G2lXcumHl8+TjZ2xti7nHHRxBZHWvlPvYZiqKmoGIf XA4SEd///JrPdZ5G6dx4PyPuJwuJV3IZ08YDWabGzU+97ALWr6egZqJBEwp/9S2K20UQM2khTzO8O LkKhW3JRLUaAQkmvuUfapCwY7r6T/Om0g8H2UaFYgVitHykmF5pv7KngQGP4mYpgDfVkUZwLfXkZe n90lQsR4xZhLx7AdBy7YJkpiT7HI0iL7BuR4LEmTYSRs94OM8yNdmaxeWplQj/HY8xASQFDZgbYEU 13+1hVLOPfShmRZpjBaQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hyfHS-000144-1o; Fri, 16 Aug 2019 16:40:46 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hyfHO-00013Z-9f for linux-arm-kernel@lists.infradead.org; Fri, 16 Aug 2019 16:40:43 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9B15528; Fri, 16 Aug 2019 09:40:36 -0700 (PDT) Received: from arrakis.emea.arm.com (arrakis.cambridge.arm.com [10.1.196.78]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CC39A3F694; Fri, 16 Aug 2019 09:40:35 -0700 (PDT) Date: Fri, 16 Aug 2019 17:40:33 +0100 From: Catalin Marinas To: Will Deacon Subject: Re: [PATCH] arm64: ftrace: Ensure module ftrace trampoline is coherent with I-side Message-ID: <20190816164033.GA36069@arrakis.emea.arm.com> References: <20190816135743.13683-1-will@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190816135743.13683-1-will@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190816_094042_383457_F00DCB36 X-CRM114-Status: GOOD ( 10.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: James Morse , stable@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Ard Biesheuvel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 16, 2019 at 02:57:43PM +0100, Will Deacon wrote: > The initial support for dynamic ftrace trampolines in modules made use > of an indirect branch which loaded its target from the beginning of > a special section (e71a4e1bebaf7 ("arm64: ftrace: add support for far > branches to dynamic ftrace")). Since no instructions were being patched, > no cache maintenance was needed. However, later in be0f272bfc83 ("arm64: > ftrace: emit ftrace-mod.o contents through code") this code was reworked > to output the trampoline instructions directly into the PLT entry but, > unfortunately, the necessary cache maintenance was overlooked. > > Add a call to __flush_icache_range() after writing the new trampoline > instructions but before patching in the branch to the trampoline. > > Cc: Ard Biesheuvel > Cc: Catalin Marinas > Cc: James Morse > Cc: > Fixes: be0f272bfc83 ("arm64: ftrace: emit ftrace-mod.o contents through code") > Signed-off-by: Will Deacon Queued for 5.3. Thanks. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel