From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C15EC3A59B for ; Sun, 18 Aug 2019 01:12:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0A5C12173B for ; Sun, 18 Aug 2019 01:12:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lmL0gQBn"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="sK9Zf/ug" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0A5C12173B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:To:From:Subject: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3jNIqI9REmEiyK6Qxb6N3W9RkHuX8fagcEaj6rpgbRk=; b=lmL0gQBnyzhw+t ksL4kGf4xDhctj+gMg1qBZQN7rUieu0db3XL2tnXrlaVmzUDpDwGeyH9C+6d8vWXlKyY8+dAWJnRC uazhRzvOcdCPXTD5MfphXdcQh8kDhOzYXSWEg7eY4WojDQIEhXxqympYNnwwgPH5ogldhkO4iJSJl 2dztIk9mfNnJJfT8PIkJzvtgnv0X5gtfdHF5LU5Tq1NiW22obw4A84XeMk070AMZE4OzJF341R7ur FUVsrvOn5mxXMb1ovLptJVD2VWjKqpr+Lcg9mYbogRcGhsl0s1aP+rIC/g2iG+RqIMcpuUTw45U5z Mp6tXxEbYbnMG9l6HS+A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hz9jO-000769-Ad; Sun, 18 Aug 2019 01:11:38 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hz9jK-00075j-V2 for linux-arm-kernel@lists.infradead.org; Sun, 18 Aug 2019 01:11:36 +0000 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CE6F52173B; Sun, 18 Aug 2019 01:11:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566090693; bh=HEk8XIpEA4mKu9ETPAtTenyB9qoVj6YJR6owDZIimHs=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=sK9Zf/ugbsO75h1nHUNXz44KUjY5aEA9MnyjFVsDNwQTo4GWK7FXrVcl8buP+RkpQ IKARSoCV5i/ZRLTSA7Vx7M11YUQKMWzMqPd4RQkrPe05z/EE9Ib+ZloogrWcWnN5cW u/2QgfCMRzjgHcPCupHFUaAQ6csiw5Muyoa2MIyY= MIME-Version: 1.0 In-Reply-To: References: <1565866783-19672-1-git-send-email-Anson.Huang@nxp.com> <1565866783-19672-5-git-send-email-Anson.Huang@nxp.com> <20190817035220.268F32173B@mail.kernel.org> Subject: RE: [PATCH 5/6] clk: imx8mn: Add necessary frequency support for ARM PLL table From: Stephen Boyd To: "devicetree@vger.kernel.org" , "festevam@gmail.com" , "kernel@pengutronix.de" , "linux-arm-kernel@lists.infradead.org" , "linux-clk@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-pm@vger.kernel.org" , "mark.rutland@arm.com" , "mturquette@baylibre.com" , "rjw@rjwysocki.net" , "robh+dt@kernel.org" , "s.hauer@pengutronix.de" , "shawnguo@kernel.org" , "viresh.kumar@linaro.org" , Abel Vesa , Anson Huang , Leonard Crestez User-Agent: alot/0.8.1 Date: Sat, 17 Aug 2019 18:11:33 -0700 Message-Id: <20190818011133.CE6F52173B@mail.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190817_181135_024944_9204180A X-CRM114-Status: GOOD ( 10.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dl-linux-imx Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Anson Huang (2019-08-17 15:22:01) > Hi, Stephen > > > Quoting Anson.Huang@nxp.com (2019-08-15 03:59:42) > > > diff --git a/drivers/clk/imx/clk-imx8mn.c > > > b/drivers/clk/imx/clk-imx8mn.c index ecd1062..3f1239a 100644 > > > --- a/drivers/clk/imx/clk-imx8mn.c > > > +++ b/drivers/clk/imx/clk-imx8mn.c > > > @@ -82,6 +84,7 @@ static struct imx_pll14xx_clk imx8mn_dram_pll = { > > > static struct imx_pll14xx_clk imx8mn_arm_pll = { > > > .type = PLL_1416X, > > > .rate_table = imx8mn_pll1416x_tbl, > > > + .rate_count = ARRAY_SIZE(imx8mn_pll1416x_tbl), > > > > Why is rate_count added? That's not described in the commit text. > > rate_count is necessary for table search during set_rate, it was missed previously, > I will add it into commit text in V2. > Right, isn't that a more critical fix to make by itself instead of rolling into this change that adds a few more frequencies? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel