From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DB27C3A59B for ; Mon, 19 Aug 2019 07:51:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D38332184E for ; Mon, 19 Aug 2019 07:51:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Myh3vBaF"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="XkPMjR9k" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D38332184E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZjkgtLh6npAao3x+mK0sMRsG713rb4Swtrqs9ayALNI=; b=Myh3vBaFpSDl90 rrrSF15+hhfKtxzlt12uNWTUv07G3Ap/LKnOb9vQFLO8i/YSCgPoM+Qj81dkgOsqjUJcMp3rUnnea GuEzAc1HUJThrWqXBkH/Mnh/fitViDjL8JEGXqee0SabBGG46XdYKzQKorMSc+KdOBkkCFEQQF2l9 JU+eMJnE5Z+pD/L6zpATWYMlFz+W93zSBToOAhRQtjAHWY/8FTFL76Ig2uUsxgcHtXltOvq4KraW1 MFOn9yc4a9/8rCGH1hyo/Eg75izPItxhXxRSE1Bkl9jmR2yT0VmVTpQaDWKGGmNZK7uPq+6MJbfm2 KXFEZZgoZzxHK/dD4ruA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hzcS2-0000mo-HK; Mon, 19 Aug 2019 07:51:38 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hzcRy-0000mO-QB for linux-arm-kernel@lists.infradead.org; Mon, 19 Aug 2019 07:51:36 +0000 Received: from X250 (37.80-203-192.nextgentel.com [80.203.192.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 119D92082C; Mon, 19 Aug 2019 07:51:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566201094; bh=YYr+sOzCSeA4C3uJqftbtG0MGcaU4L5Jif35BaA4Eeg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XkPMjR9kuQYoRQFea2vw8zhFvepVrwta4FDt0MBDl3vuCiPOXC9CX+uxyms8h9ObM lVnSTdfyABWFjGSXGqiaA7jEMJha02Ui/xq8ZZldXeCRmhMMnlHr8KDrN1Yxy+kBPk P3spAEPt2fVETl5G5eZQoUISn2kecFpSHI+5s3Zs= Date: Mon, 19 Aug 2019 09:51:22 +0200 From: Shawn Guo To: =?iso-8859-1?Q?Andr=E9?= Draszik Subject: Re: [PATCH] ARM: dts: imx7d: cl-som-imx7: make ethernet work again Message-ID: <20190819075121.GE5999@X250> References: <20190809031227.3319-1-git@andred.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190809031227.3319-1-git@andred.net> User-Agent: Mutt/1.5.24 (2015-08-30) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190819_005134_869880_363491C3 X-CRM114-Status: GOOD ( 15.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sascha Hauer , linux-kernel@vger.kernel.org, Rob Herring , Igor Grinberg , Pengutronix Kernel Team , Fabio Estevam , Ilya Ledvich , NXP Linux Team Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 09, 2019 at 04:12:27AM +0100, Andr=E9 Draszik wrote: > Recent changes to the atheros at803x driver caused > ethernet to stop working on this board. > In particular commit 6d4cd041f0af > ("net: phy: at803x: disable delay only for RGMII mode") > and commit cd28d1d6e52e > ("net: phy: at803x: Disable phy delay for RGMII mode") > fix the AR8031 driver to configure the phy's (RX/TX) > delays as per the 'phy-mode' in the device tree. > = > This now prevents ethernet from working on this board. > = > It used to work before those commits, because the > AR8031 comes out of reset with RX delay enabled, and > the at803x driver didn't touch the delay configuration > at all when "rgmii" mode was selected, and because > arch/arm/mach-imx/mach-imx7d.c:ar8031_phy_fixup() > unconditionally enables TX delay. > = > Since above commits ar8031_phy_fixup() also has no > effect anymore, and the end-result is that all delays > are disabled in the phy, no ethernet. > = > Update the device tree to restore functionality. > = > Signed-off-by: Andr=E9 Draszik > CC: Ilya Ledvich > CC: Igor Grinberg > CC: Rob Herring > CC: Mark Rutland > CC: Shawn Guo > CC: Sascha Hauer > CC: Pengutronix Kernel Team > CC: Fabio Estevam > CC: NXP Linux Team > CC: devicetree@vger.kernel.org > CC: linux-arm-kernel@lists.infradead.org Applied, thanks. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel