From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F41CBC3A59D for ; Mon, 19 Aug 2019 10:44:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C463720851 for ; Mon, 19 Aug 2019 10:44:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qNi6x4YG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C463720851 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NWwMqOoQoZx9wh9niPcFC924qVhm1TED+CeLjwQY7wg=; b=qNi6x4YGIay0fa 4TLj57T4RJQk/Tweuy2ix6uK23bX4lILUjNYueEDFvwk4wbScFdi2WWeZbsaogZ3lCp3GBtuAqNpY RoKrQIQpy4ZwRNXrAzW2lCt/kXOQ0dC3TzLb++QH/Xe2DN+8N7cFy5e7HKuKm9pQpVFh6d8nY8OYU yIdk4+MMZ4p+1Fgr1S3OnO5ga6h45zBq6Ev/kozV2XKFlF7mZA3YOeaGoiaGwW4s1vfrmGMHi8hsY oaT3I3VZ/XnAsbDfEfe6Cu1Tpk+AoDLmdovuqskUVdyNF+YyAyncV68NabxWbJI5T2eQVbI+cVHes 9x9zuzF6R7Zy51cRmoig==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hzf9F-0003xq-DG; Mon, 19 Aug 2019 10:44:25 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hzf9C-0003xP-Ao for linux-arm-kernel@lists.infradead.org; Mon, 19 Aug 2019 10:44:23 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5B917344; Mon, 19 Aug 2019 03:44:18 -0700 (PDT) Received: from lakrids.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 072A83F246; Mon, 19 Aug 2019 03:44:16 -0700 (PDT) Date: Mon, 19 Aug 2019 11:44:14 +0100 From: Mark Rutland To: Will Deacon Subject: Re: [PATCHv3 6/6] smccc: make 1.1 macros value-returning Message-ID: <20190819104414.GC7482@lakrids.cambridge.arm.com> References: <20190809132245.43505-1-mark.rutland@arm.com> <20190809132245.43505-7-mark.rutland@arm.com> <20190815164243.2hzydvjly6iwr3jf@willie-the-truck> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190815164243.2hzydvjly6iwr3jf@willie-the-truck> User-Agent: Mutt/1.11.1+11 (2f07cb52) (2018-12-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190819_034422_413379_385D2F78 X-CRM114-Status: GOOD ( 12.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lorenzo.pieralisi@arm.com, suzuki.poulose@arm.com, marc.zyngier@arm.com, catalin.marinas@arm.com, will.deacon@arm.com, linux@armlinux.org.uk, james.morse@arm.com, robin.murphy@arm.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 15, 2019 at 05:42:44PM +0100, Will Deacon wrote: > On Fri, Aug 09, 2019 at 02:22:45PM +0100, Mark Rutland wrote: > > The arm_smccc_1_1_{smc,hvc}() macros for inline invocation take a res > > pointer as their final argument, matching the out-of-line SMCCC > > invocation functions. > > > > However, the inline invocation macros are variadic, so it's easy to mess > > up passsing the correct parameters. > > passing > > > Instead, let's make them value-returning, which is less confusing. > > I'm not completely sure I agree with you here because, as far as I can > tell, it means that we have a different calling convention for 1.0 (i.e. > arm_smccc_smc()) and 1.1 (i.e. arm_smccc_1_1_smc). > > Can we do the same for 1.0 as well or am I missing something? I will take a look; I think the QC quirk is the only thing that gets in the way. Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel