From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8193C3A5A0 for ; Mon, 19 Aug 2019 20:33:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6FD20214DA for ; Mon, 19 Aug 2019 20:33:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="avECrMT4"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="uKxM19xm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6FD20214DA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IFejyRxcW54n46qBMKX2ttAvVcsbOnzp+TVrdhxag2M=; b=avECrMT48F4yD9 ixqjfAIJr1sNoVlCV04ypupCPovmTpYG0VR2f9zt2odZusoRcPuaByKp82Omzf8Cg2/ttxVFhcWsy dLR8rqNBOrVKBLGBCJ6JswQz7uHgX3NqbudRTZdlamF/dng9+k7KPmFrTpPT+lu+UF0HLGIDCuuRI xJM9ZXCNKrxSKTiKUydddiCeboE9H64pC2tB2iVuwqPrYEJ3LDAnO9BKoSwixb3HxebKtG1jJv2+4 DIn5ojtHs5wweMIwLMjeBAvZtBWOMacPnVucFxN9evkQj6LxLAsiXN9OqTvgox8MaoHXZ1N1iytvj wWJpB2SDOb87PICqOcKw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hzoLN-0005rG-Tj; Mon, 19 Aug 2019 20:33:33 +0000 Received: from mail-pl1-x641.google.com ([2607:f8b0:4864:20::641]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hzoLK-0005qp-17 for linux-arm-kernel@lists.infradead.org; Mon, 19 Aug 2019 20:33:31 +0000 Received: by mail-pl1-x641.google.com with SMTP id f19so1106609plr.3 for ; Mon, 19 Aug 2019 13:33:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=C0YdE7WLdR5eShoGfGzaTJbbzQCql5KdO1zzWvfao/I=; b=uKxM19xm2s7/cFwYcRITgshuU5SM6FPO78IQuoXe3YJJ2FoPRFyK+9UwydxmEwTzz0 aMjktkxdi6yTQR2//FZBqty3r88nNwi039t9rDaAtBq7l3Wm24dAqe29F+xcwY1fG1D3 34F/z9GimHbQTFjF/W/A1hA6dXjCyb++iaeYtBpabSwyBjcBmGN+VX2HollYI3DooMyU MG4d6fP2IIy0KsSYDcnEtDduKWOk9J1vu0v88ithmAacP6Gbqk2L7X4xZ7+/ZWnBx4OQ NC6+OtAyYV2WJV3xgtmNTPM468RDTHDTUkCaKCvrAY5cbYt2SH/Hra4ek62jbmL6uMsm iWCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=C0YdE7WLdR5eShoGfGzaTJbbzQCql5KdO1zzWvfao/I=; b=GA7fLEcvS1/YgQbOu8lsJRjih3iF9Ynz5JVrbCO0WhZJ/cRb+4oYAQdJMbMATay2g4 s8+Gn56HE7Xl6Ttok0MOM4I8A3113+/d2oAWFs5GawODypSrjxzCavHJ4LYU9YT03UPd mubLoCbWketma0fxSnYJhOV05LXY8UOm5DMftDaktsJQCVaYEFTwFCqCx0BIcwpsNVYe Yh3XrtQ93o40jdJwoKYRP7MomocJBSK2qjLbiEAJmunP0R7MSnWN/m1QAWPe537F3Pm9 0zVDv1MbhIA58B0zkBUY4nPdUiMtgCO6qbKinxWQALQuszEXCNz+pCj01nRs+k0Ed63E HDNw== X-Gm-Message-State: APjAAAWAFiULoaSEshEdQiTkc9e1tEflTMak6vSJ+vUl2BS8c2v4oeQ4 8gJUGVVuSX1jfaxwHTj01dHkAQ== X-Google-Smtp-Source: APXvYqzm51FMfY0i8xpqcKW5PlL/Gu2LoqQLJ+6mU4zb/yf7lXfYTguv7N7bV/JNozv1azQ7wUodJg== X-Received: by 2002:a17:902:684f:: with SMTP id f15mr24810884pln.332.1566246807635; Mon, 19 Aug 2019 13:33:27 -0700 (PDT) Received: from xps15 (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id h11sm16844370pfn.120.2019.08.19.13.33.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 19 Aug 2019 13:33:27 -0700 (PDT) Date: Mon, 19 Aug 2019 14:33:25 -0600 From: Mathieu Poirier To: Tanmay Vilas Kumar Jagdale Subject: Re: coresight: Add ETM4.1 support for ThunderX2 Message-ID: <20190819203325.GB8268@xps15> References: <1565877215-1331-1-git-send-email-tanmay@marvell.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1565877215-1331-1-git-send-email-tanmay@marvell.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190819_133330_213743_71B94466 X-CRM114-Status: GOOD ( 17.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tomasz Nowicki , Jayachandran Chandrasekharan Nair , Ganapatrao Kulkarni , "linux-arm-kernel@lists.infradead.org" , "suzuki.poulose@arm.com" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Same comment as the previous patch along with the following... On Thu, Aug 15, 2019 at 01:53:46PM +0000, Tanmay Vilas Kumar Jagdale wrote: > Add ETM4.1 periperhal ID for Marvell's ThunderX2 chip. > > Signed-off-by: Tanmay Jagdale > --- > drivers/hwtracing/coresight/coresight-etm4x.c | 2 ++ > drivers/hwtracing/coresight/coresight-etm4x.h | 1 + > 2 files changed, 3 insertions(+) > > diff --git a/drivers/hwtracing/coresight/coresight-etm4x.c b/drivers/hwtracing/coresight/coresight-etm4x.c > index 7bcac8896fc1..ac3bd617907b 100644 > --- a/drivers/hwtracing/coresight/coresight-etm4x.c > +++ b/drivers/hwtracing/coresight/coresight-etm4x.c > @@ -58,6 +58,7 @@ static bool etm4_arch_supported(u8 arch) > /* Mask out the minor version number */ > switch (arch & 0xf0) { > case ETM_ARCH_V4: > + case ETM_ARCH_V4_1: Why add ETM_ARCH_V4_1 when the switch statement strips off the first byte? Look at[1], someone already added support for 4.2. [1]. 5666dfd1d8a4 coresight: etm4x: Add support to enable ETMv4.2 > break; > default: > return false; > @@ -1196,6 +1197,7 @@ static const struct amba_id etm4_ids[] = { > CS_AMBA_ID(0x000bb95e), /* Cortex-A57 */ > CS_AMBA_ID(0x000bb95a), /* Cortex-A72 */ > CS_AMBA_ID(0x000bb959), /* Cortex-A73 */ > + CS_AMBA_ID(0x000cc0af), /* Marvell ThunderX2 */ I suspect this processor also has "coresight-cpu-debug" IPs. If that is the case it is very possible they both have the same CID and a UCI (see next line) is required. > CS_AMBA_UCI_ID(0x000bb9da, uci_id_etm4), /* Cortex-A35 */ > {}, > }; Thanks, Mathieu > diff --git a/drivers/hwtracing/coresight/coresight-etm4x.h b/drivers/hwtracing/coresight/coresight-etm4x.h > index 4523f10ddd0f..03369e56b2eb 100644 > --- a/drivers/hwtracing/coresight/coresight-etm4x.h > +++ b/drivers/hwtracing/coresight/coresight-etm4x.h > @@ -137,6 +137,7 @@ > #define ETM_MAX_SS_CMP 8 > > #define ETM_ARCH_V4 0x40 > +#define ETM_ARCH_V4_1 0x41 > #define ETMv4_SYNC_MASK 0x1F > #define ETM_CYC_THRESHOLD_MASK 0xFFF > #define ETM_CYC_THRESHOLD_DEFAULT 0x100 > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel