From: Viresh Kumar <viresh.kumar@linaro.org>
To: Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-pm@vger.kernel.org, vireshk@kernel.org,
b.zolnierkie@samsung.com, linux-kernel@vger.kernel.org,
krzk@kernel.org, robh+dt@kernel.org, kgene@kernel.org,
pankaj.dubey@samsung.com, linux-arm-kernel@lists.infradead.org,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH v2 0/9] Exynos Adaptive Supply Voltage support
Date: Tue, 20 Aug 2019 08:31:14 +0530 [thread overview]
Message-ID: <20190820030114.6flnn2omeys3lih3@vireshk-i7> (raw)
In-Reply-To: <b7093aaf-ea56-c390-781f-6f9d0780bd8e@samsung.com>
On 19-08-19, 15:39, Sylwester Nawrocki wrote:
> Unfortunately not, the patch set as I see it is another way of updating
> an OPP after it was parsed from DT. OPP remove/add could work equally
> well in our use case.
Adding OPPs dynamically has limitations, you can't set many values which are
otherwise possible with DT. And removing/adding is not the right thing to do
technically.
> The problem is that we have the information on how to translate the
> common OPP voltage to a voltage specific to given silicon encoded jointly
> in the ASV tables and the CHIPID registers (efuse/OTP memory).
> Additionally, algorithm of selecting ASV data (OPP voltage) based on
> the "key" data from registers is not generic, it is usually different
> per each SoC type.
>
> I tried to identify some patterns in those tables in order to simplify
> possible DT binding, but that was not really successful. I ended up just
> keeping whole tables.
Sorry but I am unable to understand the difficulty you are facing now. So what I
suggest is something like this.
- Use DT to get a frequency and voltage for each frequency.
- At runtime, based on SoC, registers, efuses, etc, update the voltage of the
OPPs.
- This algo can be different for each SoC, no one is stopping you from doing
that.
Am I missing something ?
--
viresh
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-08-20 3:01 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190718143117eucas1p1e534b9075d10fbbbe427c66192205eb1@eucas1p1.samsung.com>
2019-07-18 14:30 ` [PATCH v2 0/9] Exynos Adaptive Supply Voltage support Sylwester Nawrocki
2019-07-18 14:30 ` [PATCH v2 1/9] soc: samsung: Add exynos chipid driver support Sylwester Nawrocki
2019-07-23 12:57 ` Krzysztof Kozlowski
2019-07-23 14:10 ` Bartlomiej Zolnierkiewicz
2019-07-24 10:47 ` Krzysztof Kozlowski
2019-08-08 12:07 ` Sylwester Nawrocki
2019-07-18 14:30 ` [PATCH v2 2/9] soc: samsung: Convert exynos-chipid driver to use the regmap API Sylwester Nawrocki
2019-07-23 13:01 ` Krzysztof Kozlowski
2019-08-08 12:07 ` Sylwester Nawrocki
2019-07-18 14:30 ` [PATCH v2 3/9] soc: samsung: Add Exynos Adaptive Supply Voltage driver Sylwester Nawrocki
2019-07-23 13:38 ` Krzysztof Kozlowski
2019-08-08 12:07 ` Sylwester Nawrocki
2019-08-08 12:31 ` Krzysztof Kozlowski
2019-08-08 12:48 ` Robin Murphy
2019-08-08 13:14 ` Krzysztof Kozlowski
2019-07-18 14:30 ` [PATCH v2 4/9] ARM: EXYNOS: enable exynos_chipid for ARCH_EXYNOS Sylwester Nawrocki
2019-07-18 14:30 ` [PATCH v2 5/9] ARM64: " Sylwester Nawrocki
2019-07-18 14:30 ` [PATCH v2 6/9] ARM: EXYNOS: Enable exynos-asv driver " Sylwester Nawrocki
2019-07-18 14:30 ` [PATCH v2 7/9] soc: samsung: Update the CHIP ID DT binding documentation Sylwester Nawrocki
2019-07-18 14:30 ` [PATCH v2 8/9] ARM: dts: Add "syscon" compatible string to chipid node Sylwester Nawrocki
2019-07-18 14:30 ` [PATCH v2 9/9] ARM: dts: Add samsung,asv-bin property for odroidxu3-lite Sylwester Nawrocki
2019-07-23 2:04 ` [PATCH v2 0/9] Exynos Adaptive Supply Voltage support Viresh Kumar
2019-07-24 13:10 ` Marek Szyprowski
2019-07-25 2:23 ` Viresh Kumar
2019-08-09 15:58 ` Sylwester Nawrocki
2019-08-19 9:09 ` Viresh Kumar
2019-08-19 10:06 ` Viresh Kumar
2019-08-19 11:16 ` Sylwester Nawrocki
2019-08-19 11:25 ` Viresh Kumar
2019-08-19 13:39 ` Sylwester Nawrocki
2019-08-20 3:01 ` Viresh Kumar [this message]
2019-08-20 9:03 ` Sylwester Nawrocki
2019-08-20 9:21 ` Viresh Kumar
2019-09-04 12:37 ` Sylwester Nawrocki
2019-09-05 5:01 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190820030114.6flnn2omeys3lih3@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=b.zolnierkie@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=pankaj.dubey@samsung.com \
--cc=robh+dt@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox