From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C005BC3A589 for ; Tue, 20 Aug 2019 11:30:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 912F0205ED for ; Tue, 20 Aug 2019 11:30:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="SAlqgXy/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 912F0205ED Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dNw/+EI+ghRkzVBEFSFaOP3Uk/wNZiPA2Fzga4WAV90=; b=SAlqgXy/G0y59O xAw2BYr9bN+Mvrdg/I097yA3gMRUoy3T1on3nWHb6AWzAuj/Ew6jpKYuaJJMGBJnNeMIWh3sGdBB8 JFhsDxRR1F+52NTor74Jmh5sQG34OwOm0ybsGP/afIChtfNUbxXJpE3tUZvkBP6CV4nZ64dG+EHRn tqB/t4pZib4zyhkvTWOfJpMQb6hR2JFdq+wrCiFhtxscL+5Y+aye0n5LbhCGYqkci48zIhR1304Zf GrMjrFppr6hVfag/nlNS7/L/gmDk1ndlRRB8I+KvvdT1aiVSzmdDyfW2H1WjXjd9AHstc3HO9VqbO aXgeS85+Vw0QWXqrKbeg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i02LQ-0001Yb-0j; Tue, 20 Aug 2019 11:30:32 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i02LL-0001Wj-W6; Tue, 20 Aug 2019 11:30:29 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A2932344; Tue, 20 Aug 2019 04:30:22 -0700 (PDT) Received: from lakrids.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4C98A3F718; Tue, 20 Aug 2019 04:30:20 -0700 (PDT) Date: Tue, 20 Aug 2019 12:30:10 +0100 From: Mark Rutland To: Pavel Tatashin Subject: Re: [PATCH v2 03/14] arm64, hibernate: add trans_table public functions Message-ID: <20190820113000.GA49252@lakrids.cambridge.arm.com> References: <20190817024629.26611-1-pasha.tatashin@soleen.com> <20190817024629.26611-4-pasha.tatashin@soleen.com> <20190819155824.GE9927@lakrids.cambridge.arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.1+11 (2f07cb52) (2018-12-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190820_043028_078463_286583FB X-CRM114-Status: GOOD ( 15.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sasha Levin , Vladimir Murzin , Jonathan Corbet , Marc Zyngier , Catalin Marinas , Bhupesh Sharma , kexec mailing list , LKML , James Morris , linux-mm , James Morse , "Eric W. Biederman" , Matthias Brugger , will@kernel.org, Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Aug 19, 2019 at 12:33:31PM -0400, Pavel Tatashin wrote: > On Mon, Aug 19, 2019 at 11:58 AM Mark Rutland wrote: > > On Fri, Aug 16, 2019 at 10:46:18PM -0400, Pavel Tatashin wrote: > > > trans_table_create_copy() and trans_table_map_page() are going to be > > > the basis for public interface of new subsystem that handles page > > > tables for cases which are between kernels: kexec, and hibernate. > > > > While the architecture uses the term 'translation table', in the kernel > > we generally use 'pgdir' or 'pgd' to refer to the tables, so please keep > > to that naming scheme. > > The idea is to have a unique name space for new subsystem of page > tables that are used between kernels: > between stage 1 and stage 2 kexec kernel, and similarly between > kernels during hibernate boot process. > > I picked: "trans_table" that stands for transitional page table: > meaning they are used only during transition between worlds. > > All public functions in this subsystem will have trans_table_* prefix, > and page directory will be named: "trans_table". If this is confusing, > I can either use a different prefix, or describe what "trans_table" > stand for in trans_table.h/.c Ok. I think that "trans_table" is unfortunately confusing, as it clashes with the architecture terminology, and differs from what we have elsewhere. I think that "trans_pgd" would be better, as that better aligns with what we have elsewhere, and avoids the ambiguity. Thanks, Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel