From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E7B2C3A59E for ; Wed, 21 Aug 2019 11:58:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2F342206BB for ; Wed, 21 Aug 2019 11:58:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WcnEuIQY"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="ErsoLiwF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2F342206BB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Z5U3Hos/wruia4nZsX4w2S96A+hfE0VSqmKWZ0OGNlc=; b=WcnEuIQYGDFVhX48ZSyHCAT/d AFWEiDWeWgfxg2UiFLD84WZnLUqsCus6If/Y0kTOr1ebtHSYoP83nadFPI2GWCJ0JdvaQ80U6qOrE SSWUSYzEBaU3FBoRsIQ3akXuR8I6JFRPufEcgyNEBTFcR9sZGizjVg6tQVa73GWei5zAHJqSjwYf4 SDTbsOVQrfiCGssa+NKY5HuCg8ekaPZ+Iv4/Ff5S36gFk4Apdvtqz4zQ8FOPocdODch7tOo1EoUDA 7/8x4H+oUD5r2Jt1YuyNOw951jFVdG9MEZgLykFsAjYak/sLiWcgsskBo9OZjCwFjEt0vwUuFkfIp g5uOzltMA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i0PFo-0000Mr-1E; Wed, 21 Aug 2019 11:58:16 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i0PFG-0000Gx-TW for linux-arm-kernel@lists.infradead.org; Wed, 21 Aug 2019 11:58:03 +0000 Received: from localhost (lfbn-1-17395-211.w86-250.abo.wanadoo.fr [86.250.200.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9B17C206BB; Wed, 21 Aug 2019 11:57:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566388661; bh=vzV50aK7lDvwz6lMyupuXqdrTQf9pceOREc9MLPjXDA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ErsoLiwFvVa4rb4uLVibjPKKg37prkawlSogG246Bql64GbTFVcbjAdJEsqfxdtpg t/T9fuApibipBMV5XIlwzJERndrgD1LMe2CEi1NiuSyrE3AAwO3y0t9vgPxVknuhr2 XIHNqq7kTNCvuIxF5g/OL1vLp3iqYReP6SqQdaso= Date: Wed, 21 Aug 2019 13:57:38 +0200 From: Maxime Ripard To: Sakari Ailus Subject: Re: [PATCH v7 1/5] dt-bindings: media: Add Allwinner A10 CSI binding Message-ID: <20190821115738.3amrk5td544mhpwd@flea> References: <20190820114849.GD5123@paasikivi.fi.intel.com> MIME-Version: 1.0 In-Reply-To: <20190820114849.GD5123@paasikivi.fi.intel.com> User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190821_045745_810147_BFD221FD X-CRM114-Status: GOOD ( 22.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Rob Herring , linux-kernel@vger.kernel.org, Chen-Yu Tsai , Rob Herring , Hans Verkuil , Laurent Pinchart , Thomas Petazzoni , Mauro Carvalho Chehab , Frank Rowand , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: multipart/mixed; boundary="===============0365528672027695102==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============0365528672027695102== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6ow4c2sufu6lsmjk" Content-Disposition: inline --6ow4c2sufu6lsmjk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Sakari, On Tue, Aug 20, 2019 at 02:48:49PM +0300, Sakari Ailus wrote: > Hi Maxime, > > On Tue, Aug 20, 2019 at 01:24:32PM +0200, Maxime Ripard wrote: > > From: Maxime Ripard > > > > The Allwinner A10 CMOS Sensor Interface is a camera capture interface also > > used in later (A10s, A13, A20, R8 and GR8) SoCs. > > > > On some SoCs, like the A10, there's multiple instances of that controller, > > with one instance supporting more channels and having an ISP. > > > > Reviewed-by: Rob Herring > > Signed-off-by: Maxime Ripard > > --- > > Documentation/devicetree/bindings/media/allwinner,sun4i-a10-csi.yaml | 107 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++- > > 1 file changed, 107 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/media/allwinner,sun4i-a10-csi.yaml > > > > diff --git a/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-csi.yaml b/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-csi.yaml > > new file mode 100644 > > index 000000000000..9000bca344f9 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-csi.yaml > > @@ -0,0 +1,107 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/arm/allwinner,sun4i-a10-csi.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Allwinner A10 CMOS Sensor Interface (CSI) Device Tree Bindings > > + > > +maintainers: > > + - Chen-Yu Tsai > > + - Maxime Ripard > > + > > +description: |- > > + The Allwinner A10 and later has a CMOS Sensor Interface to retrieve > > + frames from a parallel or BT656 sensor. > > + > > +properties: > > + compatible: > > + const: allwinner,sun7i-a20-csi0 > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > + > > + clocks: > > + items: > > + - description: The CSI interface clock > > + - description: The CSI module clock > > + - description: The CSI ISP clock > > + - description: The CSI DRAM clock > > + > > + clock-names: > > + items: > > + - const: bus > > + - const: mod > > + - const: isp > > + - const: ram > > + > > + resets: > > + maxItems: 1 > > + > > + port: > > + type: object > > + additionalProperties: false > > + > > + properties: > > + endpoint: > > + properties: > > + bus-width: > > + const: 8 > > + description: Number of data lines actively used. > > Are other values supported? If not, you could omit this. It can also support 16 bits data input, but this description is redundant anyway, I'll remove it. > > + > > + data-active: true > > + hsync-active: true > > + pclk-sample: true > > + remote-endpoint: true > > + vsync-active: true > > + > > + required: > > + - bus-width > > + - data-active > > + - hsync-active > > + - pclk-sample > > + - remote-endpoint > > + - vsync-active > > Some of these are not allowed in the Bt.656 mode (vsync-active and > hsync-active) while they're required in Bt.601 mode. Is there a way to tell > that in YAML-based bindings? You could, but that would be more suited in another schemas. The way schemas works is that you can have several layers of them, and each being validated in isolation from the others. Here, we're just listing the values usable by that binding, and it will be used only to validate that binding. Eventually, we'll want to have a video-interfaces schemas that will apply to all the OF graph users, with those constraints defined. This way, we can avoid a lot of duplication and just have the binding description. I guess I could just have the remote endpoint being required, and the rest will be in the generic part. > Similarly, video-interfaces.txt should be referenced from here, shouldn't > it? Sure. Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --6ow4c2sufu6lsmjk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXV0xsgAKCRDj7w1vZxhR xZRVAQCiMCXGC+Jhj5UArGqGUPo8RfUmzov8i8LF6Y+puf29bQD9FukZcvSbUwWP 7Nb97AhXzuzAohNb4SnGTSQI6zT4lQQ= =wBTw -----END PGP SIGNATURE----- --6ow4c2sufu6lsmjk-- --===============0365528672027695102== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============0365528672027695102==--