From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D289AC3A59E for ; Wed, 21 Aug 2019 15:15:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A753322DD3 for ; Wed, 21 Aug 2019 15:15:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FSiIzrOL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A753322DD3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5W/gEne+Y2qWFhyT/EDmmvV+l9RhKN85pdPV6CCadzA=; b=FSiIzrOLI/qfAY WSE+gEyO9ieL36kH5wnAag0PdqhUxsJySgKA4qYmI3GYGMP5gGDsYynHnsmlf6sVuZhdqv6bwlpWf dniPfsjrVs8upNupkQs8MVrgDAJ2XRSnqadIxpn1s8IX08teNFZjinjGQKyU3WKoJJcsj+ROXcfNr /3ApDPSp5u8dV7B1r0QJXvzp6yygiLg8h702nW76a0B8sUghlmqU2fki59ct62tUv2Z+SXchsjfir hseW+nYkt3/WnS4tEUh5hSiysnyanQg+aUX0seq9MLkisB1PZcT7xv/YlM3djHCKF7a18XYWBoSZl Vq0MxHv7WuAX+utqPgYw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i0SKx-0006hu-4W; Wed, 21 Aug 2019 15:15:47 +0000 Received: from willy by bombadil.infradead.org with local (Exim 4.92 #3 (Red Hat Linux)) id 1i0SKu-0006hk-DY; Wed, 21 Aug 2019 15:15:44 +0000 Date: Wed, 21 Aug 2019 08:15:44 -0700 From: Matthew Wilcox To: Mike Rapoport Subject: Re: [PATCH] mm: consolidate pgtable_cache_init() and pgd_cache_init() Message-ID: <20190821151544.GC28819@bombadil.infradead.org> References: <1566400018-15607-1-git-send-email-rppt@linux.ibm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1566400018-15607-1-git-send-email-rppt@linux.ibm.com> User-Agent: Mutt/1.11.4 (2019-03-13) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Catalin Marinas , x86@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Ingo Molnar , Borislav Petkov , Andrew Morton , Will Deacon , Thomas Gleixner , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Aug 21, 2019 at 06:06:58PM +0300, Mike Rapoport wrote: > +++ b/arch/alpha/include/asm/pgtable.h > @@ -362,7 +362,6 @@ extern void paging_init(void); > /* > * No page table caches to initialise > */ > -#define pgtable_cache_init() do { } while (0) Delete the comment too? > +++ b/arch/arc/include/asm/pgtable.h > @@ -398,7 +398,6 @@ void update_mmu_cache(struct vm_area_struct *vma, unsigned long address, > /* > * No page table caches to initialise > */ > -#define pgtable_cache_init() do { } while (0) ditto > +++ b/arch/arm/include/asm/pgtable.h > @@ -368,7 +368,6 @@ static inline pte_t pte_modify(pte_t pte, pgprot_t newprot) > #define HAVE_ARCH_UNMAPPED_AREA > #define HAVE_ARCH_UNMAPPED_AREA_TOPDOWN > > -#define pgtable_cache_init() do { } while (0) > > #endif /* !__ASSEMBLY__ */ delete one of the two blank lines? > +++ b/arch/c6x/include/asm/pgtable.h > @@ -62,7 +62,6 @@ extern unsigned long empty_zero_page; > /* > * No page table caches to initialise > */ > -#define pgtable_cache_init() do { } while (0) delete comment ... more of these. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel