From: Chester Lin <clin@suse.com>
To: "linux@armlinux.org.uk" <linux@armlinux.org.uk>,
"rppt@linux.ibm.com" <rppt@linux.ibm.com>,
"ard.biesheuvel@linaro.org" <ard.biesheuvel@linaro.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"geert@linux-m68k.org" <geert@linux-m68k.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"mark.rutland@arm.com" <mark.rutland@arm.com>
Cc: Joey Lee <JLee@suse.com>, Gary Lin <GLin@suse.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"guillaume.gardet@arm.com" <guillaume.gardet@arm.com>
Subject: Re: [PATCH] arm: skip nomap memblocks while finding the lowmem/highmem boundary
Date: Thu, 22 Aug 2019 03:59:42 +0000 [thread overview]
Message-ID: <20190822035920.GA27154@linux-8mug> (raw)
In-Reply-To: <20190822034425.25899-1-clin@suse.com>
On Thu, Aug 22, 2019 at 11:45:34AM +0800, Chester Lin wrote:
> adjust_lowmem_bounds() checks every memblocks in order to find the boundary
> between lowmem and highmem. However some memblocks could be marked as NOMAP
> so they are not used by kernel, which should be skipped while calculating
> the boundary.
>
> Signed-off-by: Chester Lin <clin@suse.com>
> ---
> arch/arm/mm/mmu.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm/mm/mmu.c b/arch/arm/mm/mmu.c
> index 426d9085396b..b86dba44d828 100644
> --- a/arch/arm/mm/mmu.c
> +++ b/arch/arm/mm/mmu.c
> @@ -1181,6 +1181,9 @@ void __init adjust_lowmem_bounds(void)
> phys_addr_t block_start = reg->base;
> phys_addr_t block_end = reg->base + reg->size;
>
> + if (memblock_is_nomap(reg))
> + continue;
> +
> if (reg->base < vmalloc_limit) {
> if (block_end > lowmem_limit)
> /*
> --
> 2.22.0
>
Hi Russell, Mike and Ard,
Per the discussion in the thread "[PATH] efi/arm: fix allocation failure ...",
(https://lkml.org/lkml/2019/8/21/163), I presume that the change to disregard
NOMAP memblocks in adjust_lowmem_bounds() should be separated as a single patch.
Please let me know if any suggestion, thank you.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-08-22 4:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-22 3:45 [PATCH] arm: skip nomap memblocks while finding the lowmem/highmem boundary Chester Lin
2019-08-22 3:59 ` Chester Lin [this message]
2019-08-22 6:44 ` Mike Rapoport
2019-08-22 6:46 ` Ard Biesheuvel
2019-08-22 6:40 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190822035920.GA27154@linux-8mug \
--to=clin@suse.com \
--cc=GLin@suse.com \
--cc=JLee@suse.com \
--cc=akpm@linux-foundation.org \
--cc=ard.biesheuvel@linaro.org \
--cc=geert@linux-m68k.org \
--cc=guillaume.gardet@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=rppt@linux.ibm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox