From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E417C3A589 for ; Fri, 23 Aug 2019 04:29:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 113AD2341E for ; Fri, 23 Aug 2019 04:29:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FcO5+GD7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 113AD2341E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gondor.apana.org.au Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sZ6bzW04QJUCeK9x0Ccx1rl1jzwppIXjmb33WPAXPiQ=; b=FcO5+GD7Q+QiFn Z2tNXx7O8VcPWEtArR1si7zqPNbfz5kNfTGOCynWhtjGBySrFxrhVtcHPxrMZc0My1aUdtX3r5cUU jYN3vVpxthrmMaLUre3rXk+DW4m9Zrjod+NyWZmJpwv5REUIhbElSuWLNRxhdJM0t6jB9RaKhj96N e/dA8zvT0cAMS5vhsX77+eJ0Z/2pQko59n8htSYx0rapKDw/uZ141q9m9c1KAwZzXUZgVqdso/Ogd SYLegNuBGHWz0fqfy6d6MkmILNc0D8r09BsxmoxzieUkLeBp6ql/Zx+r+QZQwKRMFDH0+jiLWAk9r MDx/MUKoip7pPzJcfEkQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i11CC-0001na-Js; Fri, 23 Aug 2019 04:29:04 +0000 Received: from helcar.hmeau.com ([216.24.177.18] helo=fornost.hmeau.com) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i11C6-0001cg-RD for linux-arm-kernel@lists.infradead.org; Fri, 23 Aug 2019 04:29:02 +0000 Received: from gondolin.me.apana.org.au ([192.168.0.6] helo=gondolin.hengli.com.au) by fornost.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1i11At-0006rg-Aj; Fri, 23 Aug 2019 14:27:43 +1000 Received: from herbert by gondolin.hengli.com.au with local (Exim 4.80) (envelope-from ) id 1i11AE-0004RC-MF; Fri, 23 Aug 2019 14:27:02 +1000 Date: Fri, 23 Aug 2019 14:27:02 +1000 From: Herbert Xu To: "boojin.kim" Subject: Re: [PATCH 6/9] dm crypt: support diskcipher Message-ID: <20190823042702.GA17034@gondor.apana.org.au> References: <017901d5596a$1df3a590$59daf0b0$@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <017901d5596a$1df3a590$59daf0b0$@samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190822_212900_397255_0B383182 X-CRM114-Status: UNSURE ( 9.35 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 'Ulf Hansson' , 'Mike Snitzer' , dm-devel@redhat.com, 'Andreas Dilger' , 'Alasdair Kergon' , 'Eric Biggers' , linux-samsung-soc@vger.kernel.org, 'Krzysztof Kozlowski' , 'Jaehoon Chung' , 'Kukjin Kim' , linux-ext4@vger.kernel.org, 'Chao Yu' , linux-block@vger.kernel.org, linux-fscrypt@vger.kernel.org, 'Jaegeuk Kim' , linux-arm-kernel@lists.infradead.org, 'Jens Axboe' , "'Theodore Y. Ts'o'" , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-crypto@vger.kernel.org, linux-fsdevel@vger.kernel.org, "'David S. Miller'" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 23, 2019 at 01:20:37PM +0900, boojin.kim wrote: > > If yes, I think the following API needs to be added to skcipher: > - _set(): BIO submitter (dm-crypt, f2fs, ext4) sets cipher to BIO. > - _mergeable(): Block layer checks if two BIOs have the same cipher. > - _get(): Storage driver gets cipher from BIO. > - _set_crypt(): Storage driver gets crypto information from cipher and > writes it on the descriptor of Storage controller. > Is it acceptable to skcipher ? No. If you're after total offload then the crypto API is not for you. What we can support is the offloading of encryption/decryption over many sectors. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel