From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8068AC3A5A2 for ; Fri, 23 Aug 2019 10:37:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4E44A2166E for ; Fri, 23 Aug 2019 10:37:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="N/5lCI9r"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="T1iJyU/i" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4E44A2166E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2wr31PbwR/oNg7oKD7BFsnTQxOr0O1UK7IQzifIDeHc=; b=N/5lCI9rzuu7Gn 8B6gidX+C72rABAjqXCS1ia/s/dH/nkP/KReRyz/wyxgStpb7AFRK05UDcj3tCpF/WHlAM8AQMHlN fwWG/Ewa6OqlGFtXlF4KZtkQBmpwj8Bv4ZtsZU6VJmy2qS8dvcoZIe8pexADaEXp7CcVVX6brZ9XW GRMosM1p7AFZpQ0IeZSX//gaXAndSeQ6n8pTjKoi35ijz+fqeidkHVa5KeQ77Wmmn8SQedJ/YHMiY edElxOAjYbKa43oBqIpxXK4J5fG2Xq6Uw1MaEHsLCLG2FFqsbfLqeqjnDzgoC0KXFJ895UT8DKVJ3 JWcK2hVUci673bj9Omfw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i16wr-0000pQ-UI; Fri, 23 Aug 2019 10:37:37 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:3201:214:fdff:fe10:1be6]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i16wm-0000oz-T8 for linux-arm-kernel@lists.infradead.org; Fri, 23 Aug 2019 10:37:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=B9eC/SwMJI5wiLehGZuNUOPWsE6j+AyjN0GvMo8gtyU=; b=T1iJyU/i9x2rnee8Nc30yXEbn b4M1dmKyjCguakhSrpU6MivpFpuJOVelgMwGVtVrc0kQk+Hujc/VPcjZXH6p6H4qK2UstUU/s5Ojl KG1E3U5ZmdRmtaKye78/jJ4qBiRNQDLbBEx8DjhZPZH1agfp9dS+ELhAKPkv2JRaMAs23qkMfDue2 3oCcXrTBDHVlWrG03tpnxvSj6M0V5Y+Eejd6ESfr4xcfTqq4BFLnzOUQ+2zTshQjY8jsVJFTwEfFv JRvrFRvWPmpDWIxaZJ9scQddSdG65ZJXIUZXlj9/saC4dQaWXcDib7fX+7jWsuvq6PWLJF+E+x4Na gjBirzRPw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:60050) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1i16wF-00045J-L4; Fri, 23 Aug 2019 11:36:59 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1i16wA-00009v-LB; Fri, 23 Aug 2019 11:36:54 +0100 Date: Fri, 23 Aug 2019 11:36:54 +0100 From: Russell King - ARM Linux admin To: Chris Clayton Subject: Re: Regression in 5.3-rc1 and later Message-ID: <20190823103654.GX13294@shell.armlinux.org.uk> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190823_033732_947327_15948685 X-CRM114-Status: GOOD ( 30.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, vincenzo.frascino@arm.com, linux-mips@vger.kernel.org, linux-kselftest@vger.kernel.org, arnd@arndb.de, huw@codeweavers.com, andre.przywara@arm.com, daniel.lezcano@linaro.org, will.deacon@arm.com, LKML , ralf@linux-mips.org, salyzyn@android.com, paul.burton@mips.com, linux@rasmusvillemoes.dk, 0x7f454c46@gmail.com, catalin.marinas@arm.com, pcc@google.com, tglx@linutronix.de, sthotton@marvell.com, shuah@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, To everyone on the long Cc list... What's happening with this? I was about to merge the patches for 32-bit ARM, which I don't want to do if doing so will cause this regression on 32-bit ARM as well. Thanks. On Thu, Aug 22, 2019 at 07:57:59AM +0100, Chris Clayton wrote: > Hi everyone, > > Firstly, apologies to anyone on the long cc list that turns out not to be particularly interested in the following, but > you were all marked as cc'd in the commit message below. > > I've found a problem that isn't present in 5.2 series or 4.19 series kernels, and seems to have arrived in 5.3-rc1. The > problem is that if I suspend (to ram) my laptop, on resume 14 minutes or more after suspending, I have no networking > functionality. If I resume the laptop after 13 minutes or less, networking works fine. I haven't tried to get finer > grained timings between 13 and 14 minutes, but can do if it would help. > > ifconfig shows that wlan0 is still up and still has its assigned ip address but, for instance, a ping of any other > device on my network, fails as does pinging, say, kernel.org. I've tried "downing" the network with (/sbin/ifdown) and > unloading the iwlmvm module and then reloading the module and "upping" (/sbin/ifup) the network, but my network is still > unusable. I should add that the problem also manifests if I hibernate the laptop, although my testing of this has been > minimal. I can do more if required. > > As I say, the problem first appears in 5.3-rc1, so I've bisected between 5.2.0 and 5.3-rc1 and that concluded with: > > [chris:~/kernel/linux]$ git bisect good > 7ac8707479886c75f353bfb6a8273f423cfccb23 is the first bad commit > commit 7ac8707479886c75f353bfb6a8273f423cfccb23 > Author: Vincenzo Frascino > Date: Fri Jun 21 10:52:49 2019 +0100 > > x86/vdso: Switch to generic vDSO implementation > > The x86 vDSO library requires some adaptations to take advantage of the > newly introduced generic vDSO library. > > Introduce the following changes: > - Modification of vdso.c to be compliant with the common vdso datapage > - Use of lib/vdso for gettimeofday > > [ tglx: Massaged changelog and cleaned up the function signature formatting ] > > Signed-off-by: Vincenzo Frascino > Signed-off-by: Thomas Gleixner > Cc: linux-arch@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-mips@vger.kernel.org > Cc: linux-kselftest@vger.kernel.org > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Arnd Bergmann > Cc: Russell King > Cc: Ralf Baechle > Cc: Paul Burton > Cc: Daniel Lezcano > Cc: Mark Salyzyn > Cc: Peter Collingbourne > Cc: Shuah Khan > Cc: Dmitry Safonov <0x7f454c46@gmail.com> > Cc: Rasmus Villemoes > Cc: Huw Davies > Cc: Shijith Thotton > Cc: Andre Przywara > Link: https://lkml.kernel.org/r/20190621095252.32307-23-vincenzo.frascino@arm.com > > arch/x86/Kconfig | 3 + > arch/x86/entry/vdso/Makefile | 9 ++ > arch/x86/entry/vdso/vclock_gettime.c | 245 ++++--------------------------- > arch/x86/entry/vdso/vdsox32.lds.S | 1 + > arch/x86/entry/vsyscall/Makefile | 2 - > arch/x86/entry/vsyscall/vsyscall_gtod.c | 83 ----------- > arch/x86/include/asm/pvclock.h | 2 +- > arch/x86/include/asm/vdso/gettimeofday.h | 191 ++++++++++++++++++++++++ > arch/x86/include/asm/vdso/vsyscall.h | 44 ++++++ > arch/x86/include/asm/vgtod.h | 75 +--------- > arch/x86/include/asm/vvar.h | 7 +- > arch/x86/kernel/pvclock.c | 1 + > 12 files changed, 284 insertions(+), 379 deletions(-) > delete mode 100644 arch/x86/entry/vsyscall/vsyscall_gtod.c > create mode 100644 arch/x86/include/asm/vdso/gettimeofday.h > create mode 100644 arch/x86/include/asm/vdso/vsyscall.h > > To confirm my bisection was correct, I did a git checkout of 7ac8707479886c75f353bfb6a8273f423cfccb2. As expected, the > kernel exhibited the problem I've described. However, a kernel built at the immediately preceding (parent?) commit > (bfe801ebe84f42b4666d3f0adde90f504d56e35b) has a working network after a (>= 14minute) suspend/resume cycle. > > As the module name implies, I'm using wireless networking. The hardware is detected as "Intel(R) Wireless-AC 9260 > 160MHz, REV=0x324" by iwlwifi. > > I'm more than happy to provide additional diagnostics (but may need a little hand-holding) and to apply diagnostic or > fix patches, but please cc me on any reply as I'm not subscribed to any of the kernel-related mailing lists. > > Chris > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel